zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-11 14:14:36 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
34 Commits
Author SHA1 Message Date
Andres Olivares 5290273035 Reland "[module.json extensions] layer_viewer" 
This reverts commit a74cf29ae2.

Reason for revert: The original CL was failing as a side effect of an issue solved in https://chromium.googlesource.com/devtools/devtools-frontend/+/a1ee70e85e999910e91c5d8f79825a038546d9ae .

Original change's description:
> Revert "[module.json extensions] layer_viewer"
>
> This reverts commit 7d6613389b.
>
> Reason for revert: suspect for bot failure (https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/DevTools%20Linux/4109/overview)
>
> Original change's description:
> > [module.json extensions] layer_viewer
> >
> > Bug: 1134103
> > Change-Id: Ida938d827c207d52e8f3e8aa051e0449ae1e527b
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2650520
> > Commit-Queue: Andres Olivares <andoli@chromium.org>
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
>
> TBR=tvanderlippe@chromium.org,andoli@chromium.org
>
> Change-Id: Ic874958cc3c6f691a679f1c94ab70931e9748f02
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1134103
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2653088
> Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>

TBR=tvanderlippe@chromium.org,wolfi@chromium.org,andoli@chromium.org

Bug: 1134103
Change-Id: Ie3bf12a81e60b7aa8b20cae8e39fe795c35200fa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2655627
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-28 14:43:29 +00:00
Wolfgang Beyer a74cf29ae2 Revert "[module.json extensions] layer_viewer" 
This reverts commit 7d6613389b.

Reason for revert: suspect for bot failure (https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/DevTools%20Linux/4109/overview)

Original change's description:
> [module.json extensions] layer_viewer
>
> Bug: 1134103
> Change-Id: Ida938d827c207d52e8f3e8aa051e0449ae1e527b
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2650520
> Commit-Queue: Andres Olivares <andoli@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=tvanderlippe@chromium.org,andoli@chromium.org

Change-Id: Ic874958cc3c6f691a679f1c94ab70931e9748f02
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1134103
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2653088
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-01-27 18:02:05 +00:00
Andres Olivares 7d6613389b [module.json extensions] layer_viewer 
Bug: 1134103
Change-Id: Ida938d827c207d52e8f3e8aa051e0449ae1e527b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2650520
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-27 14:45:00 +00:00
Andres Olivares 3027aefe4c [module.json extensions] webauthn 
Bug: 1134103
Change-Id: I36846e7de6a7375a9fe7b331f68cf765b81c5975
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2642896
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-22 23:54:59 +00:00
Andres Olivares 63c33dcf10 [module.json extensions] web_audio 
Bug: 1134103
Change-Id: I0f3a80a0a52dfd3849da99beba055a3f7d78f38c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2640604
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-22 14:35:23 +00:00
Andres Olivares 19dfb4b4fd [module.json extensions] timeline views 
Bug: 1134103
Change-Id: I168d621048b93f00b16b6f7d4fd11d2e4bb4f031
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631963
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-21 19:29:18 +00:00
Andres Olivares f4a1581a5c [module.json extensions] performance_monitor 
Bug: 1134103
Change-Id: Ic8d7d8fbb1b469bf4afec4bcde8ee47b773c5234
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2638016
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-21 17:45:29 +00:00
Andres Olivares c1d799da95 [module.json extensions] mobile_throttling 
Bug: 1134103
Change-Id: Ib06c6f895da5c3f4be30a337644cd37de9cf9016
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635830
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-21 02:46:23 +00:00
Andres Olivares 69a9225db5 [module.json extensions] media 
Bug: 1134103
Change-Id: Idc48e3c02a4b2c97dd651bd29d492bf8773f59cc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2633018
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-20 14:01:10 +00:00
Andres Olivares fe25667745 [module.json extensions] lighthouse 
Bug: 1134103
Change-Id: Ic4799907f8b3b29b6c51bf9f908c994be88b72ed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2630309
Reviewed-by: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2021-01-19 16:22:39 +00:00
Andres Olivares 0ed100f0df [module.json extensions] layers 
Bug: 1134103
Change-Id: I52bef8418bc7f103a2d4e301ce548597b3dbb73f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2630308
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-19 15:16:27 +00:00
Andres Olivares f2a99e868d [module.json extensions] help views 
Bug: 1134103
Change-Id: I797fc82b277511f0aa11cb365c7dfd0f933b4ef4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629728
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 20:31:36 +00:00
Andres Olivares 5135060ac7 [module.json extensions] issues views 
Bug: 1134103
Change-Id: I0a919093cf3463f248a50aaf3152c903928570af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2630305
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 18:29:56 +00:00
Andres Olivares 49a36a120b [module.json extensions] resources views 
Bug: 1134103
Change-Id: Idb39a93006a87a885800b7e668e015fa7d65b37a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631962
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 14:39:26 +00:00
Andres Olivares 3100aca993 [module.json extensions] inspector_main views 
Bug: 1134103
Change-Id: I469e5c7799f8286a41d7ecd59354ac6a91aaa8d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629730
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 14:45:10 +00:00
Tim van der Lippe 6d5bdf4f7e [module.json extensions] developer_resources 
R=andoli@chromium.org

Bug: 1134103
Change-Id: I433c9a8d02541ace0fbf7662f6689faaa7f0607a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2612856
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-01-13 12:40:02 +00:00
Tim van der Lippe 6d21034c1b [module.json extensions] animation 
R=andoli@chromium.org

Bug: 1134103
Change-Id: I40dd16d7e5ddc9c3b1a879bdda0b9d0de13fdf20
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2612854
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-01-13 10:35:02 +00:00
Tim van der Lippe 6dd4b0c912 [module.json extensions] Security 
This also fixes a bug where `build_release_applications` wasn't
rebuilding when changes would be made to devtools_app.js

R=andoli@chromium.org

Bug: 1134103
Change-Id: I50831c41e0ce7c04ddeb0c1a44acd51436ef92b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2593143
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-01-05 12:14:09 +00:00
Andres Olivares 8b204e1e02 Change sources and profiler meta files imports to shell.js 
'sources' and 'profiler' are delcared as modules of the 'shell' app
instead of 'devtools_app', thus the side effect imports of their meta
files must be located in shell.js not in devtools_app.js.

This CL corrects the location of these imports as their misplacement
prevents the appropiate loading of the dependencies of the 'shell' app.

Fixed: 1159888
Change-Id: I441149b657d86be4587c22843c7836be2f578e92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2599754
Auto-Submit: Andres Olivares <andoli@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2020-12-21 15:53:26 +00:00
Andres Olivares f1c7fd55a5 [module.json extensions] Migrate profiler views 
Bug: 1134103
Change-Id: Iee95736b9604d3b0fb7d065ecc37b92758fa1156
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2589758
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-16 21:51:45 +00:00
Tim van der Lippe 9e5d60a44d [module.json extensions] Accessibility 
R=andoli@chromium.org

Bug: 1134103
Change-Id: I4f84afb3ad98939096360aa385e6605374f69186
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2593141
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2020-12-16 14:52:20 +00:00
Tim van der Lippe 4b527cff8b [module.json extensions] emulation 
R=andoli@chromium.org

Bug: 1134103
Change-Id: I23be42ec86fbcab1f7a5f62972fcb73a296fb961
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2587017
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2020-12-14 16:24:06 +00:00
Tim van der Lippe 28d5ad7efb [module.json extensions] css_overview 
R=andoli@chromium.org

Bug: 1134103
Change-Id: Icef477bfebec409bdcb7fa1d2af6d5d034968b9d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2587020
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2020-12-14 16:06:46 +00:00
Andres Olivares 70b668a4fd [module.json extensions] Migrate network views 
Bug: 1134103
Change-Id: I3bcc8c238bf0ec2734236777ed696067846aa7a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577165
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-10 17:14:28 +00:00
Andres Olivares fd431fb765 [module.json extensions] sources views 
Bug: 1134103
Change-Id: I1f050156edc6c0500aa19dc18f43d7463541128b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2584524
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-10 16:42:44 +00:00
Tim van der Lippe 08ecb1751c [module.json extensions] browser_debugger views 
R=andoli@chromium.org

Bug: 1134103
Change-Id: I6751bbf874b4e42b4650398d8d5c121e748fed6e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2565573
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-01 13:20:55 +00:00
Tim van der Lippe 26b7dab721 Reland "Migrate elements/ extensions of type 'view'" 
This reverts commit ed2a064ac1.

Reason for revert: Autoroller issues have been addressed in separate CLs

Original change's description:
> Revert "Migrate elements/ extensions of type 'view'"
>
> This reverts commit e9b95b83fe.
>
> Reason for revert: Breaks Autoroller when trying to roll to Chromium 
>
> Original change's description:
> > Migrate elements/ extensions of type 'view'
> >
> > Bug:1134103
> > Change-Id: I800a19dc9b721ea17e3241f387eb7af70cabca85
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2552055
> > Commit-Queue: Andres Olivares <andoli@chromium.org>
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
>
> TBR=tvanderlippe@chromium.org,andoli@chromium.org
>
> Change-Id: I7852464be52dec0e0b8f413c2841e2e01474ede5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1134103
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2555599
> Commit-Queue: Andres Olivares <andoli@chromium.org>
> Reviewed-by: Andres Olivares <andoli@chromium.org>

Bug: 1134103
Change-Id: I1ea4832c76ebf034ee901df4b70ea937d420e2e4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557046
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-25 14:04:47 +00:00
Andres Olivares ed2a064ac1 Revert "Migrate elements/ extensions of type 'view'" 
This reverts commit e9b95b83fe.

Reason for revert: Breaks Autoroller when trying to roll to Chromium 

Original change's description:
> Migrate elements/ extensions of type 'view'
>
> Bug:1134103
> Change-Id: I800a19dc9b721ea17e3241f387eb7af70cabca85
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2552055
> Commit-Queue: Andres Olivares <andoli@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=tvanderlippe@chromium.org,andoli@chromium.org

Change-Id: I7852464be52dec0e0b8f413c2841e2e01474ede5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1134103
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2555599
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2020-11-23 22:08:38 +00:00
Andres Olivares e9b95b83fe Migrate elements/ extensions of type 'view' 
Bug:1134103
Change-Id: I800a19dc9b721ea17e3241f387eb7af70cabca85
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2552055
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-23 15:48:56 +00:00
Tim van der Lippe 3387bd4064 Move startup files to GN 
There previously were two special files that were handled
by `build_release_applications`: root.js and RuntimeInstantiator.js.
Both files are explicitly part of the startup process of DevTools
and its various entrypoints.

To remove the copying from `build_release_applications`, we have
to move these to the relevant `devtools_entrypoint`. Since a
`devtools_entrypoints` bundles all subdirectories, we can't keep
these files in `front_end/` directly. Instead, we move these files
to `startup/` to denote their special-casing in the startup process.

Next to that, we have to fix all usages of these files in the entrypoints.
For all JavaScript entrypoint files, all side-effect legacy files
that are loaded by `startup.js` (previously known as `root.js` and renamed
to prevent confusion with the `root/` module) are removed. All
"additional" legacy files that a particular entrypoint requires are
still loaded as-is.

The RuntimeInstantiator is moved to become an implementation detail
of `startup/`. Therefore, all of the usages that were previously
importing from `RuntimeInstantiator` now import via `startup.js`.

In the end, the special-casing of these files are removed and renamed
for clarity. In the future, we want to remove the complicated
entrypoints startup process, but we are not ready for that yet.
That will require additional cleanups with `resources` in `module.json`
before that change can happen.

R=aerotwist@chromium.org

Bug: 1131500
Change-Id: I198d5a62d2aab70f842c68d9b4c0871fde1587a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2485072
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-10-20 12:55:34 +00:00
Tim van der Lippe 6d51bf00ea Factor out Runtime to root/Runtime.js 
front_end/Runtime.js was doing multiple things: it was instantiating
side-effecty descriptors and initializing applications, as well as
storing all state for the modules/extensions, etc...

To support proper ES Modules, we need to separate these. root/Runtime.js
contains simple classes that store the data and can be retrieved, as well
as some helper functions that will load the respective data.

The RuntimeInstantiator.js code includes the start functions used in the
entrypoints themselves. They will use an instance of the Runtime to
properly load the application.

Along the way, I also fixed various TypeScript errors, mostly around
incorrect or missing type definitions.

R=aerotwist@chromium.org,jacktfranklin@chromium.org

Bug: 1011811
Change-Id: If3ddea9267813691b3faeb6ea4b0cf64edbde1f4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107523
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-03-18 12:19:29 +00:00
Tim van der Lippe e894e9c586 Stop rewriting html entrypoints 
This adds the necessary ES imports to the various entrypoints to
properly load their dependencies. This means that we can stop rewriting
the HTML entrypoints and simply copy them over to the build directory.

Bug: 1046596
Change-Id: If1182ed051a22cc2bb0c77456456ab039f63cec2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2035791
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-03-04 17:19:45 +00:00
Tim van der Lippe 99e59b8c29 Migrate Runtime.js to ESM 
Introduce a new namespace "Root" to be able to disambiguate between
Runtime the namespace and Runtime the object.

roll CodeMirror
The above line is necessary to fix the presubmit, which complains
about CodeMirror changes. This is only updating a type reference.

Bug: 1006759
Change-Id: I04941d9f18649701060e3035f7eeb2ef3abb51e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829708
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#701257}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 17cc008cf6ad28c6e8c07c638a1b380ca30e7f79
 2019-09-30 20:00:59 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2. 
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
 2018-04-07 15:32:37 +00:00