zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-09 05:08:28 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
19 Commits
Author SHA1 Message Date
Tim van der Lippe d7cfd14814 Fix no-implicit-coercion errors in front_end/ 
R=jacktfranklin@chromium.org

No-Presubmit: True
Bug: 1082789
Change-Id: Ic77884bf7e9b5dc74053915b3b10699368841b66
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2595268
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-07 12:40:16 +00:00
Tim van der Lippe 2e38eeaf9f Remove all comments with only the unrestricted annotation 
The unrestricted annotation is Closure-specific and can be removed.
This patch removes all comments with only the unrestricted annotation
in them.

R=szuend@chromium.org

No-Presubmit: True
Bug: 1011811
Change-Id: Iba0723644f53f5307c3077d341271af86becc32a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569758
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-02 15:25:32 +00:00
Jan Scheffler 4f5c3741c2 [ts] Type-check sdk/DOMModel.js 
R=aerotwist@chromium.org

Bug: chromium:1011811
Change-Id: I406644adf44a299aa6ee6953001f1892b190ddc7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2463346
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-10-29 10:28:00 +00:00
Tim van der Lippe d3f78cef84 Typecheck elements/DOMPath.js with TypeScript 
R=szuend@chromium.org

Bug: 1011811
Change-Id: Ic1e99cc4e5249244a605b62a820ffea3671aa654
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2440506
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-09-30 16:30:48 +00:00
Paul Lewis 90faf09ce9 Update Closure Compiler and fix associated errors 
Change-Id: I07cc1ea6b1b135571359136dfdec120ab4649b9e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2388060
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-02 08:41:50 +00:00
Paul Lewis 6d4ebb2006 Reland "Reland "Updates elements to devtools_module"" 
This reverts commit 340bd16cd3.

Reason for revert: devtools_pre_built no longer makes hardlinks

Original change's description:
> Revert "Reland "Updates elements to devtools_module""
> 
> This reverts commit 04858cf7dd.
> 
> Reason for revert: This seems to trigger the known issue that 
> TSC is rewriting source files because of left-over hard-links.
> See https://ci.chromium.org/p/devtools-frontend/builders/ci/Stand-alone%20Linux/2582
> 
> To reproduce locally, check out the commit before this revision,
> do a clean build, then check out this revision, and do a build.
> This will succeed but rewrite source files (which it shouldn't).
> 
> 
> Original change's description:
> > Reland "Updates elements to devtools_module"
> > 
> > This reverts commit 22d876ca02.
> > 
> > Reason for revert: Build issues on bots should be fixed
> > 
> > Original change's description:
> > > Revert "Updates elements to devtools_module"
> > > 
> > > This reverts commit 81e818fad8.
> > > 
> > > Reason for revert: Anticipating build errors on bots
> > > 
> > > Original change's description:
> > > > Updates elements to devtools_module
> > > > 
> > > > Bug: 1101738
> > > > Change-Id: I294d366c95a3b5dc7ac5b757855846a7b31ac60b
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2329779
> > > > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > > > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> > > 
> > > TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
> > > 
> > > Change-Id: I3e36a1520e34be3ce1779ecdf2b4cead6a293971
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1101738
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332815
> > > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> > > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> > 
> > TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
> > 
> > # Not skipping CQ checks because this is a reland.
> > 
> > Bug: 1101738
> > Change-Id: Ia0d06bb75f2610459f4d0b31ff6b770b1031d982
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2335060
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> 
> TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
> 
> Change-Id: Iabfbe2aad94033078eac41338d64ca069f49332f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1101738
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2335273
> Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>

TBR=sigurds@chromium.org,aerotwist@chromium.org,jacktfranklin@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1101738
Change-Id: I42579d6cac06ec45377789253588ba94ee72a226
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2336715
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-08-10 09:15:45 +00:00
Sigurd Schneider 340bd16cd3 Revert "Reland "Updates elements to devtools_module"" 
This reverts commit 04858cf7dd.

Reason for revert: This seems to trigger the known issue that 
TSC is rewriting source files because of left-over hard-links.
See https://ci.chromium.org/p/devtools-frontend/builders/ci/Stand-alone%20Linux/2582

To reproduce locally, check out the commit before this revision,
do a clean build, then check out this revision, and do a build.
This will succeed but rewrite source files (which it shouldn't).


Original change's description:
> Reland "Updates elements to devtools_module"
> 
> This reverts commit 22d876ca02.
> 
> Reason for revert: Build issues on bots should be fixed
> 
> Original change's description:
> > Revert "Updates elements to devtools_module"
> > 
> > This reverts commit 81e818fad8.
> > 
> > Reason for revert: Anticipating build errors on bots
> > 
> > Original change's description:
> > > Updates elements to devtools_module
> > > 
> > > Bug: 1101738
> > > Change-Id: I294d366c95a3b5dc7ac5b757855846a7b31ac60b
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2329779
> > > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> > 
> > TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
> > 
> > Change-Id: I3e36a1520e34be3ce1779ecdf2b4cead6a293971
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1101738
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332815
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> 
> TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
> 
> # Not skipping CQ checks because this is a reland.
> 
> Bug: 1101738
> Change-Id: Ia0d06bb75f2610459f4d0b31ff6b770b1031d982
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2335060
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>

TBR=aerotwist@chromium.org,jacktfranklin@chromium.org

Change-Id: Iabfbe2aad94033078eac41338d64ca069f49332f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1101738
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2335273
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-08-03 14:47:19 +00:00
Paul Lewis 04858cf7dd Reland "Updates elements to devtools_module" 
This reverts commit 22d876ca02.

Reason for revert: Build issues on bots should be fixed

Original change's description:
> Revert "Updates elements to devtools_module"
> 
> This reverts commit 81e818fad8.
> 
> Reason for revert: Anticipating build errors on bots
> 
> Original change's description:
> > Updates elements to devtools_module
> > 
> > Bug: 1101738
> > Change-Id: I294d366c95a3b5dc7ac5b757855846a7b31ac60b
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2329779
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> 
> TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
> 
> Change-Id: I3e36a1520e34be3ce1779ecdf2b4cead6a293971
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1101738
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332815
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>

TBR=aerotwist@chromium.org,jacktfranklin@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1101738
Change-Id: Ia0d06bb75f2610459f4d0b31ff6b770b1031d982
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2335060
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-08-03 14:01:07 +00:00
Paul Lewis 22d876ca02 Revert "Updates elements to devtools_module" 
This reverts commit 81e818fad8.

Reason for revert: Anticipating build errors on bots

Original change's description:
> Updates elements to devtools_module
> 
> Bug: 1101738
> Change-Id: I294d366c95a3b5dc7ac5b757855846a7b31ac60b
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2329779
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>

TBR=aerotwist@chromium.org,jacktfranklin@chromium.org

Change-Id: I3e36a1520e34be3ce1779ecdf2b4cead6a293971
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1101738
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332815
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-08-03 11:24:30 +00:00
Paul Lewis 81e818fad8 Updates elements to devtools_module 
Bug: 1101738
Change-Id: I294d366c95a3b5dc7ac5b757855846a7b31ac60b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2329779
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-08-03 11:07:47 +00:00
Tim van der Lippe 97611c9403 Migrate elements/ to import cross-module 
Bug: 1006759
Change-Id: I253ab8e4768cf57aa017dca98dfff851eeec8cec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2052169
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-13 14:26:58 +00:00
Tim van der Lippe aabc830090 Migrate elements/ to use ES-imports 
This moves the side-effects to elements-legacy.js (which is lazily
loaded by the Runtime) and resolves all internal references using
ES-imports.

Bug: 1006759
Change-Id: I911a3a31f12e68488c9cd8d807ef03a9c7286668
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1960447
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-12-10 16:00:15 +00:00
Tim van der Lippe 13f71fb5e7 Reland "Migrate elements/ to ESM" 
This reverts commit 9fd15ddbd0.

Reason for revert: Fixed browser tests loading behavior

Original change's description:
> Revert "Migrate elements/ to ESM"
>
> This reverts commit 8fefb2ca13.
>
> Reason for revert: broke browsertest https://ci.chromium.org/p/chromium/builders/try/linux-rel/250464 and blocking roll.
>
> Original change's description:
> > Migrate elements/ to ESM
> >
> > Bug: 1006759
> > Change-Id: Ie9144a22562eb3ae3341a285f5ad16f3d630896c
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1934212
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
>
> TBR=aerotwist@chromium.org,tvanderlippe@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1006759
> Change-Id: I16a1fd9851391a6080c5376ca35866402b0bc445
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1937027
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>

Change-Id: Iba84f5230f20a86b2de75b84115fcb10aeea534e
Bug: 1006759
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1937029
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-11-29 13:04:20 +00:00
Yang Guo 9fd15ddbd0 Revert "Migrate elements/ to ESM" 
This reverts commit 8fefb2ca13.

Reason for revert: broke browsertest https://ci.chromium.org/p/chromium/builders/try/linux-rel/250464 and blocking roll.

Original change's description:
> Migrate elements/ to ESM
> 
> Bug: 1006759
> Change-Id: Ie9144a22562eb3ae3341a285f5ad16f3d630896c
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1934212
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=aerotwist@chromium.org,tvanderlippe@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1006759
Change-Id: I16a1fd9851391a6080c5376ca35866402b0bc445
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1937027
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2019-11-26 16:48:06 +00:00
Tim van der Lippe 8fefb2ca13 Migrate elements/ to ESM 
Bug: 1006759
Change-Id: Ie9144a22562eb3ae3341a285f5ad16f3d630896c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1934212
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-11-25 15:18:14 +00:00
Tim van der Lippe 1d6e57a0e3 Always add braces to single-line if-statements 
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.

This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.

Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
 2019-09-30 11:55:34 +00:00
Mathias Bynens 6b5621bb77 Improve copy JS path functionality 
This patch simplifies DOMPath.js by using CSS.escape to produce
valid CSS identifiers, instead of a custom (and subtly broken)
implementation.

Similarly, instead of custom logic, JSON.stringify is now used to
produce valid JavaScript string literals.

Bug: chromium:930625
Change-Id: I4462cca6b41ae1a0b1232c4517e02fb171bbccad
Reviewed-on: https://chromium-review.googlesource.com/c/1464719
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#631337}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 39d011cffef144bc7cf3d019c248c8032e9fe5d2
 2019-02-12 19:36:54 +00:00
Andrey Lushnikov c197ddf043 DevTools: copy JS path 
This patch introduces a new 'Copy js path' option to the context
menu that allows to get a JavaScript reference to the object
in the DOM Tree. This comes handy when dealing with Shadow DOM
trees.

R=dgozman

Change-Id: I07a77597f88b6cc500baed8ae9ee097b35d79b4f
Reviewed-on: https://chromium-review.googlesource.com/c/1300756
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#606723}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: be8b1dc6dcc9c479f3df1aa11bf542e3a9790ae7
 2018-11-09 03:25:59 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2. 
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
 2018-04-07 15:32:37 +00:00