zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-09 21:28:43 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
60 Commits
Author SHA1 Message Date
Andres Olivares 67e43a2bd1 [module.json extensions] @Common.Linkifier 
Bug: 1134103
Change-Id: I89498b6fc1424cbc9d8a0705224765d245eca274
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2691511
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-12 22:47:40 +00:00
Andres Olivares 11d439730a [module.json extensions] @UI.Renderer 
Bug: 1134103
Change-Id: I0b78854156c640d4bac87af262ec7849099dc076
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2687697
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-12 21:41:17 +00:00
Andres Olivares 55a674e37b [module.json extensions] @Elements.MarkerDecorator 
Bug: 1134103
Change-Id: I22853ec55c30125951a02a87983c58036a48af15
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2688204
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-12 20:58:09 +00:00
Andres Olivares 43c2d9f322 [module.json extensions] @UI.ToolbarItem.Provider Part 2 
Bug: 1134103
Change-Id: I1674bd9bcc12f19aa51405d9fd8ef6a9c7965331
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2684120
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-10 18:55:36 +00:00
Andres Olivares 2877d1c0f0 [module.json extensions] Add support for @Common.Revealer 
Bug: 1134103
Change-Id: Iabd6346d15b864b7b0003f67c963d6b0c0373f2d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678612
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-09 15:16:50 +00:00
Simon Zünd 6efb6287b5 Reland "[module.json extensions] Migrate @ViewLocationResolver in elements/" 
This reverts commit 3abe4703fa.

Reason for revert: The original CL was reverted in the course of investigating a CQ Tree closure. As the CL was not the cause we can safely reland.

Original change's description:
> Revert "[module.json extensions] Migrate @ViewLocationResolver in elements/"
>
> This reverts commit 29da6d23a9.
>
> Reason for revert: Reverting due to red tree. Low chance that this CL is the actual cause for the outage but we should confirm we reverting.
>
> Original change's description:
> > [module.json extensions] Migrate @ViewLocationResolver in elements/
> >
> > Bug: 1134103
> > Change-Id: I631b35747ede06d4d5377e09e3700e9d58ee2ac8
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629176
> > Commit-Queue: Andres Olivares <andoli@chromium.org>
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> > Auto-Submit: Andres Olivares <andoli@chromium.org>
>
> TBR=tvanderlippe@chromium.org,andoli@chromium.org
>
> Change-Id: Ibc9cadba9680e65355801359f42960ea4d6b4921
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1134103
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631107
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

TBR=szuend@chromium.org,tvanderlippe@chromium.org,andoli@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1134103
Change-Id: I0585f3deab8c7140b5e0668cf8dc79b214b76873
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631110
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-01-15 13:12:30 +00:00
Simon Zünd 3abe4703fa Revert "[module.json extensions] Migrate @ViewLocationResolver in elements/" 
This reverts commit 29da6d23a9.

Reason for revert: Reverting due to red tree. Low chance that this CL is the actual cause for the outage but we should confirm we reverting.

Original change's description:
> [module.json extensions] Migrate @ViewLocationResolver in elements/
>
> Bug: 1134103
> Change-Id: I631b35747ede06d4d5377e09e3700e9d58ee2ac8
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629176
> Commit-Queue: Andres Olivares <andoli@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Auto-Submit: Andres Olivares <andoli@chromium.org>

TBR=tvanderlippe@chromium.org,andoli@chromium.org

Change-Id: Ibc9cadba9680e65355801359f42960ea4d6b4921
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1134103
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631107
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-01-15 09:01:18 +00:00
Andres Olivares 29da6d23a9 [module.json extensions] Migrate @ViewLocationResolver in elements/ 
Bug: 1134103
Change-Id: I631b35747ede06d4d5377e09e3700e9d58ee2ac8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629176
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
 2021-01-14 22:03:38 +00:00
Tim van der Lippe 460e19b668 [module.json extensions] Add support for ContextMenu providers 
Modules can now register their contextMenu providers in the meta
files. The ContextMenu will now request each registered provider
alongside the previously registered providers from the runtime.

Note that a contextmenu provider will eagerly load its module, to
load the definition of the provider itself. Ideally we don't perform
this work at once (we currently load *all* modules that have a
contextmenu provider as soon as the user opens a contextmenu), but
we will punt that to a follow-up to clean up.

Lastly, some cleanups were performed in `show()` to use async-await
and handle the array of Promises that return an array of Providers.

R=andoli@chromium.org

Bug: 1134103
Change-Id: Idb15be2b6f4c9d8c6fb663f548580620500b076d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569768
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2020-12-08 12:15:12 +00:00
Andres Olivares 4c68008935 Migrate elements/ extensions of type 'setting' 
Bug:1134103
Change-Id: I61e2523ad9ada88b8c00c07bb388d5834128f92c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560765
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-01 07:22:16 +00:00
Andres Olivares 5bae823824 Migrate elements/ extensions of type 'action' 
Bug:1134103
Change-Id: I688a7e80af736d295c1e24f252b4bd73977a451f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2558061
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-30 15:18:19 +00:00
Yisi 3383020812 Add shortcut key for "Duplicate element" in Element panel 
This CL add shortcut key is bound to DevTools -> Settings -> Shortcuts,
by default the Shift+Alt+Down(Windows)/Shift+Option+Down(Mac) shortcut key is used, which is consistent with Visual Studio Code.

In the future we can also add Shift+Alt+Up.

Screenshot: https://i.imgur.com/VkgNuZY.png

Bug: 1150797
Change-Id: I7712639c7c18274f2c6feba7d1b0e3518073ce2f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560318
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
 2020-11-26 15:02:03 +00:00
Tim van der Lippe 26b7dab721 Reland "Migrate elements/ extensions of type 'view'" 
This reverts commit ed2a064ac1.

Reason for revert: Autoroller issues have been addressed in separate CLs

Original change's description:
> Revert "Migrate elements/ extensions of type 'view'"
>
> This reverts commit e9b95b83fe.
>
> Reason for revert: Breaks Autoroller when trying to roll to Chromium 
>
> Original change's description:
> > Migrate elements/ extensions of type 'view'
> >
> > Bug:1134103
> > Change-Id: I800a19dc9b721ea17e3241f387eb7af70cabca85
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2552055
> > Commit-Queue: Andres Olivares <andoli@chromium.org>
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
>
> TBR=tvanderlippe@chromium.org,andoli@chromium.org
>
> Change-Id: I7852464be52dec0e0b8f413c2841e2e01474ede5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1134103
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2555599
> Commit-Queue: Andres Olivares <andoli@chromium.org>
> Reviewed-by: Andres Olivares <andoli@chromium.org>

Bug: 1134103
Change-Id: I1ea4832c76ebf034ee901df4b70ea937d420e2e4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557046
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-25 14:04:47 +00:00
Tim van der Lippe 7dcef88d8b Remove skip_compilation from module.json files 
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I4c4fd280adb4f5f7b327239d08d80b2cb98b203b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560248
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-25 13:19:08 +00:00
Andres Olivares ed2a064ac1 Revert "Migrate elements/ extensions of type 'view'" 
This reverts commit e9b95b83fe.

Reason for revert: Breaks Autoroller when trying to roll to Chromium 

Original change's description:
> Migrate elements/ extensions of type 'view'
>
> Bug:1134103
> Change-Id: I800a19dc9b721ea17e3241f387eb7af70cabca85
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2552055
> Commit-Queue: Andres Olivares <andoli@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=tvanderlippe@chromium.org,andoli@chromium.org

Change-Id: I7852464be52dec0e0b8f413c2841e2e01474ede5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1134103
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2555599
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2020-11-23 22:08:38 +00:00
Andres Olivares e9b95b83fe Migrate elements/ extensions of type 'view' 
Bug:1134103
Change-Id: I800a19dc9b721ea17e3241f387eb7af70cabca85
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2552055
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-23 15:48:56 +00:00
Brandon Goddard e895ddd0e9 Screenshot: disable screenshot command in PWA 
Previously, users could use the command prompt menu to select
screenshot tools such as "take area screenshot" and "take full
"screenshot".

However, in modes where the devtools cannot be
docked, such as PWA, the device mode that handles the
screenshot is never created, so the screenshot actions don't do
anything.

This CL disables the screenshot commands using the same "can_dock"
check as the emulation mode, so that screenshots cannot be attempted
in this non-supported case.

Before: https://imgur.com/WtwI7oV
After: https://imgur.com/aknzgtH

Bug: 1151059
Change-Id: I758f1ca3c0d3b4ad9575e6a4a1a38e0919d45584
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2551377
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Reviewed-by: Brian Cui <brcui@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
 2020-11-20 17:05:22 +00:00
Tim van der Lippe 78d75b5456 Use TypeScript-authored files in elements/ 
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: Ia5d0a37c1b73bb7551ec64c97bf7bfc80cb6b3b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2545820
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-11-18 12:57:38 +00:00
Paul Lewis 1f7a820653 [unit test] Fix remaining non-entrypoint imports 
Bug: 1148296
Change-Id: If6673aff7755e78b29d4a602fac1baa84e4890e3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2536408
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-11-13 15:19:21 +00:00
Paul Lewis d31a011b35 [unit test] Remap Elements tests to use entrypoint 
Change-Id: I92005bdff317b678a8f8cc5191f0e18058369056
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2527041
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-11-10 11:49:46 +00:00
Changhao Han 8655e96a00 Move CSSAngle-related files from elements/ to inline_editor/ 
In the future, I expect more type components to reside in inline_editor/
because it's where current type-component-like components live, e.g.
ColorSwatch, BezierSwatch, etc.

Bug: chromium:1126178
Change-Id: Icfc9553c5f3e54ef94e04de50cda8b7ef7a9bc8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2509573
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
 2020-10-30 11:25:26 +00:00
Alex Rudenko 4504e3a359 Show icons explaining flexbox-direction:row in Styles panel 
This CL adds an icon for the flex-direction: row property that
shows up when editing the styles. The icon is automatically rotated
based on the element's direction. The feature is behind a new experiment
flag called cssFlexboxFeatures.

Video: https://i.imgur.com/EE9LKj1.mp4
Backend CL for metrics: https://crrev.com/c/2485268

Bug: 1139945
Change-Id: I674215f62b2de6fd2f14884974eda186ad39ce3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2485081
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-10-23 13:34:31 +00:00
Tim van der Lippe 46e1bcace9 Remove pre_generates_legacy from module.json files 
This was a temporary flag used during the build_release_applications
to GN migration.

R=aerotwist@chromium.org

Bug: 1131500
Change-Id: I8a772bcc4bee31dbd3270bf7ef62d8c97941024a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484716
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-10-19 16:12:09 +00:00
Tim van der Lippe ead1fa43d0 Move remaining legacy files to GN 
R=aerotwist@chromium.org

Bug: 1131500
Change-Id: Ibb247dd02a5032604824517be4276c4b83c8fc8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2479140
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-10-19 09:25:50 +00:00
Changhao Han a67320cd7c CSS <angle> component 
Design doc: https://docs.google.com/document/d/1CvsRHYzEYO2ESLvferomPjqlnseVwnxp6Tb_WoXvfOE/edit#

Screencast run 1: https://imgur.com/a/73cBBZW

Screencast run 2: https://imgur.com/a/NSbMb0a

Bug: chromium:1126178
Change-Id: Id667caf1fafe0b47a8f9094846dd054d3abf264d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2372546
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-10-16 15:42:07 +00:00
Kateryna Prokopenko 704e6d67c1 Icon component 
Add a new web-component to simplify adding new/working with icons in DevTools

Bug: chromium:1126031
Change-Id: I37462cad34dae443ea2949fc8f736aa1614b3aa8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2401167
Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-10-14 15:04:42 +00:00
Changhao Han bb4af12377 Complete ARIA tree support to Computed pane 
This CL fixes two issues:
1. The traditional list of Computed styles could not be navigated via
ARIA tree keyboard navigations, due to recent componentization changes.
2. The grouped list was not ARIA-tree-navigatable either.

Bug: chromium:1125511, chromium:1125958
Change-Id: I2fd29ccf7e85019615d5a9fe7fab7647a44c02e9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403320
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2020-09-11 09:06:46 +00:00
Kateryna Prokopenko f6a55ca8e6 Add elements component 
Create Elements panel linking component

Bug: chromium:1114694
Change-Id: I1df751c6f2553191d7ab66978b8e320b2e123459
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2362581
Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-10 07:57:22 +00:00
Tim van der Lippe cac65d4fa0 Remove skip_rollup 
This was a temporary flag as part of the devtools_entrypoint migration.
Since that migration has concluded, we can now remove all references
to it and clean up `build_release_applications.py`.

R=jacktfranklin@chromium.org,aerotwist@chromium.org

Bug: 1101738
Change-Id: I3ef9ec1a99bc9fc1758532124db22b3b4b1a5e2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391140
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-08 15:44:09 +00:00
Changhao Han 0a98cc54ea Implements grouped Computed styles in the Computed tab 
Design doc: https://goo.gle/devtools-computed-styles

Screencast: https://imgur.com/a/n8Y7jXH

Updated screencast for expanding by default: https://imgur.com/a/0CUnlch

Bug: chromium:1096230, chromium:1084673, chromium:1106251
Change-Id: Ib6f22de5f96cb7e35fe60730c186cbde7d2905fe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2360377
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2020-08-21 21:30:00 +00:00
Alex Rudenko 5d93c7e064 Move Layout pane to the 3rd position in the sidebar 
This CL makes the Layout pane more prominent by moving it to the
3rd position in the sidebar.

Screenshot: https://i.imgur.com/MOwlx6q.png

Bug: 1109177
Change-Id: I4837644d815eee8a57848bd4a92501556d56f4dd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2366732
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
 2020-08-21 07:49:37 +00:00
Tim van der Lippe b36c2d9991 Revert "Remove Properties subpane from Elements panel" 
This reverts commit 5f6928b957.

Reason for revert: User feedback has largely been that they want to reinstate the panel. Even though we don't think the current UX is ideal, given the strong messaging from users we are adding the panel back. In a future version of DevTools, we are going to improve the workflow for inspecting properties of elements

Original change's description:
> Remove Properties subpane from Elements panel
>
> The subpane is replaced by a deprecation message guiding users to
> the `console.dir($0)` feature that already exists in DevTools.
>
> At a later point in time we should remove the deprecation
> message as a whole.
>
> Design doc: https://docs.google.com/document/d/16-PSJSb6BE9Wx2Nn9rYtQOCiDa9-cLwr3R7gk0MirvM/edit?usp=sharing
> Screenshot: https://imgur.com/a/v4wYE3R
>
> R=​aerotwist@chromium.org
>
> Change-Id: I137d3f338e4b99ef4de15ced618007991da172ef
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2157037
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>

Change-Id: I03e2bc62feab1b5399e055d6f8d01eef51927c88
Fixed: 1105205, 1116085
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2366782
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2020-08-20 13:14:05 +00:00
Alex Rudenko 320d83cddb Fix LayoutPane icon appearance in dark mode 
Fixed the Reveal element icon in the dark mode and, as a drive-by,
extracts LayoutPane's CSS into a separate file (+ 1 problem fixed
by CSS linter).

Bug: 1109177
Change-Id: Iaa02d93aae6f74aab520e70093584870e4fa5c46
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2364356
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-08-20 06:47:24 +00:00
Changhao Han d2454323cb TS-componentize Computed tab's style property and style trace elements 
This also helps future work, for example, Computed style grouping,
to be TS-componentized as well.

Bug: chromium:1106251, chromium:1096230
Change-Id: I2f8a977f4e3f701905354cb4edb15702cb8cd2a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2336723
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-08-11 13:52:51 +00:00
Alex Rudenko a39d214440 Layout pane 
This CL adds a new layout panel to the sidebar in Elements. Currently,
the pane only displays CSS Grid settings. In the future, the list of
all CSS grids will show up above the settings. The new panel is behind
the CSS Grid experiment flag.

Screenshot: https://i.imgur.com/T5Kd5Wi.png

Bug: 1109177
Change-Id: I7b5620ce6818df68d1f9cb36975be3679ca16837
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2317315
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Peter Müller <petermueller@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-08-11 05:46:01 +00:00
Jack Franklin 84d986f9a1 Rename NewElementsBreadcrumbs => ElementsBreadcrumbs 
Now it's landed and stable, let's remove the `New` prefix.

Change-Id: I27a77b134edbdbd96fc1e129b2958dbff1a0855a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2306156
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-07-21 14:56:12 +00:00
Tim van der Lippe 37512b0d25 Remove empty script arrays from module.json files 
If the module uses `modules` to load the JavaScript files, then
we can remove the `scripts` array altogether. Note that there
are still some modules left that use `scripts`, most notably
the `lighthouse_worker`, which is a remote module.

R=aerotwist@chromium.org

Bug: 1105476
Change-Id: Ie303e9835f5ce6d42ccae7b3a305d8f3df1af84c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2302597
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-07-17 10:05:33 +00:00
Jack Franklin 187489319e Reland "Ship new ElementsBreadcrumbs to production" 
This reverts commit 8794ac6b44.

Reason for revert: Fixed issue with missing file that caused browser tests to fail.

Original change's description:
> Revert "Ship new ElementsBreadcrumbs to production"
>
> This reverts commit d8d96d5f0a.
>
> Reason for revert: Breaks browser_tests: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874686472852976032/+/steps/browser_tests/0/logs/Deterministic_failure:_SitePerProcessDevToolsSanityTest.InspectElement__status_FAILURE_/0
>
> Confirmed locally on a Linux Debug build that this is the offending CL.
>
> Original change's description:
> > Ship new ElementsBreadcrumbs to production
> >
> > This CL ships the new elements breadcrumbs component to production,
> > replacing the old legacy breadcrumbs with the new custom element that
> > we've built to replace it.
> >
> > Note that I haven't renamed the file from `NewElementsBreadcrumbs`. I wanted to
> > keep the diff on this CL clear and easy to follow. I plan to follow this up
> > with another CL that does the renaming.
> >
> > Light mode & dark mode screenshots: https://imgur.com/a/UyF4ktY
> >
> > Change-Id: I5c3df09456101ce03072f3eeb27f6a1c568cf9c7
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2297395
> > Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
>
> TBR=aerotwist@chromium.org,tvanderlippe@chromium.org,jacktfranklin@chromium.org
>
> Change-Id: I62be4e9e3bd1fc328733ded3fff377ffd50e2d81
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2300491
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

TBR=aerotwist@chromium.org,szuend@chromium.org,tvanderlippe@chromium.org,jacktfranklin@chromium.org


Change-Id: Iae6aa0ce84a57312a29d79344059f887f337c5bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2300494
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-07-16 10:21:51 +00:00
Simon Zünd 8794ac6b44 Revert "Ship new ElementsBreadcrumbs to production" 
This reverts commit d8d96d5f0a.

Reason for revert: Breaks browser_tests: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874686472852976032/+/steps/browser_tests/0/logs/Deterministic_failure:_SitePerProcessDevToolsSanityTest.InspectElement__status_FAILURE_/0

Confirmed locally on a Linux Debug build that this is the offending CL.

Original change's description:
> Ship new ElementsBreadcrumbs to production
> 
> This CL ships the new elements breadcrumbs component to production,
> replacing the old legacy breadcrumbs with the new custom element that
> we've built to replace it.
> 
> Note that I haven't renamed the file from `NewElementsBreadcrumbs`. I wanted to
> keep the diff on this CL clear and easy to follow. I plan to follow this up
> with another CL that does the renaming.
> 
> Light mode & dark mode screenshots: https://imgur.com/a/UyF4ktY
> 
> Change-Id: I5c3df09456101ce03072f3eeb27f6a1c568cf9c7
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2297395
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=aerotwist@chromium.org,tvanderlippe@chromium.org,jacktfranklin@chromium.org

Change-Id: I62be4e9e3bd1fc328733ded3fff377ffd50e2d81
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2300491
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-07-16 07:14:53 +00:00
Jack Franklin d8d96d5f0a Ship new ElementsBreadcrumbs to production 
This CL ships the new elements breadcrumbs component to production,
replacing the old legacy breadcrumbs with the new custom element that
we've built to replace it.

Note that I haven't renamed the file from `NewElementsBreadcrumbs`. I wanted to
keep the diff on this CL clear and easy to follow. I plan to follow this up
with another CL that does the renaming.

Light mode & dark mode screenshots: https://imgur.com/a/UyF4ktY

Change-Id: I5c3df09456101ce03072f3eeb27f6a1c568cf9c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2297395
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-07-15 15:15:15 +00:00
Tim van der Lippe c33de4fd55 Add support for skip_rollup in module.json 
For folders that already have a `devtools_entrypoint` target, we
should skip Rollup as part of `build_release_applications.py`. To
remove the hardcoded list of skipped folders and enable
parallelization of a fixit to migrate all folders, we have to put
the information in the `module.json` instead.

Once all folders are migrated to `devtools_entrypoint`, we can remove
the field and the Rollup logic in `build_release_applications.py`.

R=aerotwist@chromium.org

Bug: 1101738
Change-Id: Ibadab13e87cf28622c40896a56f6ed18cc34bea2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2284838
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-07-10 08:49:48 +00:00
Changhao Han 006b8c05bc Implement Adorner custom element with public API from ElementsTreeElement 
Design doc: https://goo.gle/devtools-adorners

Bug: chromium:1066772
Change-Id: I8b31705471baf7612ac8ed8c305637c366796cf5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2151458
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-04-27 20:04:01 +00:00
Tim van der Lippe 5f6928b957 Remove Properties subpane from Elements panel 
The subpane is replaced by a deprecation message guiding users to
the `console.dir($0)` feature that already exists in DevTools.

At a later point in time we should remove the deprecation
message as a whole.

Design doc: https://docs.google.com/document/d/16-PSJSb6BE9Wx2Nn9rYtQOCiDa9-cLwr3R7gk0MirvM/edit?usp=sharing
Screenshot: https://imgur.com/a/v4wYE3R

R=aerotwist@chromium.org

Change-Id: I137d3f338e4b99ef4de15ced618007991da172ef
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2157037
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-04-22 13:02:19 +00:00
Alex Rudenko 1ebbb30be2 Enable image preview in styles panel 
This change adds image preview functionality to the styles panel
including the computed styles view. The preview functionality within
ElementsPanel is removed because it seems unused (equivalent code
in ElementsTreeOutline handles the previews).

Screenshot: https://i.imgur.com/TIU3Rg3.png

Fixed: 1040019
Change-Id: I6e387826de908df74ea6e5d7a89e2293291e692b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2156347
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-04-20 15:43:46 +00:00
Mathias Bynens 5e43b27e8b Reformat module.json files 
This patch makes it so that all module.json files use the same
consistent indentation that matches .editorconfig and the rest
of the codebase. At the request of reviewers, one such file
(front_end/emulated_devices/module.json) has been excluded
from this patch. It will be reformatted in a separate CL.

Note that this patch does not “roll CodeMirror”, although a
pre-commit hook forces me to include that phrase in the commit
message because the module.json file in the relevant folder is
modified.

Bug: chromium:1070492
Change-Id: Ib31ed5232461e2f80bf05f31105fc919f6639b0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127007
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-04-14 05:35:23 +00:00
Jack Lynch b110942f5c Ensure that all actions have categories 
To support custom shortcuts, this updates the module.schema.json to
require actions to have categories and adds categories to existing
actions. It also renames the existing "DevTools" category to "Global."

Custom shortcuts design doc: https://docs.google.com/document/d/1oOPSWPxCHvMoBZ0Fw9jwFZt6gP4lrsrsl8DEAp-Hy7o/edit#heading=h.2xpjzz3fl1ju

Bug: 174309
Change-Id: I0860f040e19502b4c47301356b52a2f12166dee5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2101972
Reviewed-by: Shane Clifford <shanejc@microsoft.com>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
 2020-03-18 00:50:58 +00:00
Jack Lynch 61f8ad8b69 Add titles for all actions 
This CL adds titles to the actions that don't yet have them (most do) to
support future custom keyboard shortcut work.

Bug: 174309
Change-Id: Ic2aa408c82d863369427f13e5330530d948138b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2085476
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Jose Leal <joselea@microsoft.com>
Reviewed-by: Brian Cui <brcui@microsoft.com>
 2020-03-05 21:09:45 +00:00
Tim van der Lippe aabc830090 Migrate elements/ to use ES-imports 
This moves the side-effects to elements-legacy.js (which is lazily
loaded by the Runtime) and resolves all internal references using
ES-imports.

Bug: 1006759
Change-Id: I911a3a31f12e68488c9cd8d807ef03a9c7286668
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1960447
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-12-10 16:00:15 +00:00
Tim van der Lippe 13f71fb5e7 Reland "Migrate elements/ to ESM" 
This reverts commit 9fd15ddbd0.

Reason for revert: Fixed browser tests loading behavior

Original change's description:
> Revert "Migrate elements/ to ESM"
>
> This reverts commit 8fefb2ca13.
>
> Reason for revert: broke browsertest https://ci.chromium.org/p/chromium/builders/try/linux-rel/250464 and blocking roll.
>
> Original change's description:
> > Migrate elements/ to ESM
> >
> > Bug: 1006759
> > Change-Id: Ie9144a22562eb3ae3341a285f5ad16f3d630896c
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1934212
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
>
> TBR=aerotwist@chromium.org,tvanderlippe@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1006759
> Change-Id: I16a1fd9851391a6080c5376ca35866402b0bc445
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1937027
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>

Change-Id: Iba84f5230f20a86b2de75b84115fcb10aeea534e
Bug: 1006759
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1937029
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-11-29 13:04:20 +00:00
Yang Guo 9fd15ddbd0 Revert "Migrate elements/ to ESM" 
This reverts commit 8fefb2ca13.

Reason for revert: broke browsertest https://ci.chromium.org/p/chromium/builders/try/linux-rel/250464 and blocking roll.

Original change's description:
> Migrate elements/ to ESM
> 
> Bug: 1006759
> Change-Id: Ie9144a22562eb3ae3341a285f5ad16f3d630896c
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1934212
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=aerotwist@chromium.org,tvanderlippe@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1006759
Change-Id: I16a1fd9851391a6080c5376ca35866402b0bc445
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1937027
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2019-11-26 16:48:06 +00:00