Commit Graph
6 Commits
Author SHA1 Message Date
Tim van der Lippe 5e1aeb0577 Remove suppress annotations
All of these were Closure-specific.

R=szuend@chromium.org

No-Presubmit: True
Bug: 1011811
Change-Id: Ia580e21cd3b06f532bb5a63a770ccfa3d7c796ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569761
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2020-12-02 17:27:02 +00:00
Tim van der Lippe 8b068ffba1 Remove initialization of globals in Runtime
We initialize the globals in the `-legacy.js` files and therefore
don't require the additional assignments in the Runtime itself.

R=jacktfranklin@chromium.org

Bug: 1127902
Fixed: 1058320
Change-Id: Id6c13d9f2b9d781bfab73957621324335d394a2b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2410225
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-09-15 12:08:12 +00:00
Paul Lewis a68f7832ad [Global] Update refs to SDK.isolateManager & SDK.domModelUndoStack
Bug: 1006759
Change-Id: Ic620e62e0e24b5cd6bf16a0dfd6dfd1a2fdf7725
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019139
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-01-24 14:32:08 +00:00
Tim van der Lippe 83f02be257 Standardize license headers
Many of the license headers were incorrect or corrupted. To prepare for
a check that verifies correct license headers are added to source code,
we should fix up the existing license headers to use the correct format.

The license headers that include non-Google/non-Chromium authors are
left as-is.

Change-Id: Iab9bdc41d815ac7ab07ccacf44818f3b56a75230
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016745
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
2020-01-23 13:00:41 +00:00
Tim van der Lippe 1d6e57a0e3 Always add braces to single-line if-statements
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.

This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.

Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
2019-09-30 11:55:34 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2.
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00