Jack Franklin
49a9481a74
Lint color usage in background and border-* properties.
...
The list of CSS properties we check for colors wasn't thorough and
didn't include `border-left/right/top/bottom` or `background` on its
own. This CL fixes that and disables the rule for any current
violations.
Bug: 1152736
Change-Id: Ic732d653fdfab0462a04dc891bcece1f44e5d471
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676157
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
2021-02-05 15:39:39 +00:00
Jack Franklin
8064d3ba7a
Lint against non-theme-color variables
...
This CL turns on the use_theme_colors stylelint rule which enforces that
any colors use variables defined in our codebase.
There are many, many violations, unsurprisingly (about 1500), so for now
I have disabled every single violation. The goal of the dark mode
migration will be in part to remove all violations of this rule.
Additionally, new code going forwards should adhere to the rule and not
add the comment to disable the warning.
Bug: 1152736
Change-Id: I51372724ea51485daef3d4f75b7d3f60a7c8016f
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2671323
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2021-02-03 11:02:09 +00:00
Peter Müller
661b3a4411
Device preview: replace PNG icons with SVGs
...
Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1099211
To improve color contrast of the drag handles and to reduce file size some PNG icons are replaced by SVG files.
Before: https://imgur.com/a/23KY36e
After: https://imgur.com/a/RvK3mHe
Change-Id: Iad71e4081ebe2ba2151dc6a0b2d0e1a8e00ac449
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2375194
Commit-Queue: Peter Müller <petermueller@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-08-26 17:51:53 +00:00
Jack Franklin
5853a0e578
Fix stylelint issues in emulation CSS files
...
I was going to do one-per-CL but all of them had very few warnings and
issues that needed fixing, so didn't think the overhead of 4 CLs was
worth it.
Bug: chromium:1083142
Change-Id: I7850be17c42f0b30530e6ceeab4c6903ad1429da
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2288701
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
2020-07-10 10:20:09 +00:00
Mathias Bynens
ca9fa2d73f
Consistently format CSS color and opacity values
...
- Prefer the modern comma-free CSS color function syntax over the
legacy syntax. [1]
- Explicitly use the `deg` suffix for angle values in colors, to
clarify the range.
- Explicitly use the `%` suffix for percentages instead of formatting
the value as a number, again to clarify the range.
[1]: https://twitter.com/mathias/status/1253242715304857601
[2]: https://goo.gle/devtools-css-color
Bug: chromium:1083142
Fixed: chromium:1073885
Change-Id: I8e1582a2dee3553a61df88564051ea84c2011d76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209091
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Auto-Submit: Mathias Bynens <mathias@chromium.org >
2020-05-19 16:50:26 +00:00
Mathias Bynens
b0c1f4bce2
Fix stylelint-config-standard violations
...
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Changhao Han <changhaohan@chromium.org >
Auto-Submit: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
2020-05-15 17:05:27 +00:00
Blink Reformat
4c46d0969f
The Great Blink mv for source files, part 2.
...
Move and rename files.
NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true
Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org >
Commit-Queue: Blink Reformat <blink-reformat@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00
Jack Franklin