Commit Graph
111 Commits
Author SHA1 Message Date
Sigurd Schneider c65995a229 Roll protocol and adapt tests
Corresponding back-end CL: https://crrev.com/c/2584499

DISABLE_THIRD_PARTY_CHECK=protocol update pending

Bug: chromium:1170548, chromium:1142606
Change-Id: Ied86cccacceb08db16deea512dafcbd7b5f5dbc2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2698829
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2021-02-17 09:03:39 +00:00
Benedikt Meurer 53e299550a Roll js_protocol.pdl (wasmvalue subtype).
DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: chromium:1170282, chromium:1071432, chromium:1159402
Change-Id: I9ede1780652634ec2a683bebcc36fd0247d181bc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2690534
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
2021-02-11 16:42:28 +00:00
Sigurd Schneider 3d4b67d7f6 Update protocol
DISABLE_THIRD_PARTY_CHECK=Protocol update

Bug: None
Change-Id: I9de989e7664d6b33193c7a86dcb254631a89514a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2686654
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
2021-02-10 11:15:40 +00:00
Alex Rudenko 268a0e2103 Update CDP
Contains the result of running:

scripts/deps/roll_deps.py && npm run generate-protocol-resources
in the devtools frontend repo.

DISABLE_THIRD_PARTY_CHECK=cdp update

Bug: chromium:1155460
Change-Id: Ic05169899ad8414a8102654b55dfe53cfd85602c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2662823
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2021-02-01 11:56:24 +00:00
Maks Orlovich 3e146e838f Roll proto changes
DISABLE_THIRD_PARTY_CHECK=Chromium DEPS roll

Bug: None
Change-Id: Iebc8bb4b2d79d1a0cbdf8eb580cc968114dae7db
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2656947
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2021-01-29 06:40:23 +00:00
Sigurd Schneider 92517e5a5e Update protocol
DISABLE_THIRD_PARTY_CHECK=Protocol update

Bug: chromium:1051466
Change-Id: I9b68a46b2bf8525b7b9e3ff4236536251d8a1ae5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2656239
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2021-01-28 15:42:38 +00:00
Sigurd Schneider 10892493bb Update DevTools Chromium DEPS.
DISABLE_THIRD_PARTY_CHECK=This CL includes a protocol update

TBR=machenbach@chromium.org,liviurau@chromium.org

Bug: chromium:1169693, chromium:1051466
Change-Id: I3d461b183350813f5a3d200c60e0bbde62553254
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2650087
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
2021-01-26 15:29:45 +00:00
Yoichi Osato 52fcc528ca Protocol update
Related changes in chromium:
 crrev.com/c/2631814
This CL also adds minimal override to address type script.

DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: chromium:1152290
Change-Id: Icc1ed2d0898ed695af7266ab950ee7ec4ef2aa5a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2649469
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Yoichi Osato <yoichio@chromium.org>
2021-01-26 07:50:18 +00:00
Ella Ge 0a62ce0e2d Roll browser_protocol.pdl
To include backend pdl change in crrev.com/c/2568749

DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: 1147479
Change-Id: I0a1fda3fc0442b785dcd360a23e2fe69178202c5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2646577
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
2021-01-25 15:03:14 +00:00
Simon Zünd 2b3b5ea939 Roll deps from Chromium into DevTools
This CL is the result of running roll_deps.py and
npm run generate-protocol-resources.

DISABLE_THIRD_PARTY_CHECK=Chromium deps roll

R=wolfi@chromium.org

Change-Id: I534b1589cb9f9db64b47e13ff364aeba91868bb3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2641770
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2021-01-21 10:22:13 +00:00
Andrey Kosyakov 5fccb46378 Roll browser_protocol.pdl
... to include http://crrev.com/c/2639393

DISABLE_THIRD_PARTY_CHECK=protocol update

BUG: 1152089
Change-Id: Iaf7a5ed1a15bb3befc8e4c12ee8082d41c7f3177
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2641150
Auto-Submit: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
2021-01-21 07:11:03 +00:00
Simon Zünd ccdfc9bed1 Roll deps from Chromium into DevTools
This CL is the result of running roll_deps.py and
npm run generate-protocol-resources.

Additionally, cookie unit tests are adjusted to include a new property.

DISABLE_THIRD_PARTY_CHECK=Chromium deps roll

R=wolfi@chromium.org

Change-Id: Ifb2d7b4bc6839de2a6fe269ebfe918f43f21d1b4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2619610
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2021-01-11 13:00:56 +00:00
Benedikt Meurer 51690fcadb Roll js_protocol.pdl ('wasm' type and 'executeWasmEvaluator' removal).
DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: chromium:1162062, chromium:1159402
Change-Id: I5321aa8750b9ecb22b3f5eee3278b3a3f3ccc45f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2617698
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
2021-01-08 07:18:07 +00:00
Andrey Kosyakov b961d44fa6 Roll js_protocol.pdl to include ExecutionContextDescription.uniqueId
Drive-by: roll inspector_protocol to fix pdl.py problem

DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: v8:11268, chromium:1101897
Change-Id: I8c0be131e521d996fb718ee381fe67f14dfe737d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2602555
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
2020-12-24 05:30:57 +00:00
Sigurd Schneider 316b70a0e9 Update protocol
DISABLE_THIRD_PARTY_CHECK=protocol update

Change-Id: I4483652972deafbae6b8fb3302a20a3ed17cf48b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2597297
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2020-12-17 09:18:55 +00:00
Yoichi Osato 2d4ece5291 Protocol update
Related changes in chromium:
 crrev.com/c/2576862
 crrev.com/c/2505345

DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: chromium:1152290
Change-Id: I7ce0da4187d515ac29a4064f86d563a4d09ab97f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2576992
Auto-Submit: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2020-12-08 06:48:51 +00:00
Sigurd Schneider c870c46ba4 Don't generate types for deprecated Console domain
The runtime definitions are explicitly skipped here:
https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/scripts/build/code_generator_frontend.py;l=202;drc=8e12f92229028121fd0cfa1a3c39825a228f341c

This means that if someone tries to access the values at runtime,
an error occurs. Removing the definition altogether is the
safest option.

Bug: chromium:1153099
Change-Id: Icc17caa99ebc68e4466ea309bf2a06b4c8cd71fe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2575092
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2020-12-07 12:20:01 +00:00
Benedikt Meurer dead315abb Add webassemblymemory subtype.
This needs to roll before we add the subtype to the V8 inspector, as
otherwise the console will print errors when logging a
WebAssembly.Memory.

DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: chromium:1155566
Change-Id: I62a4a21eba7479a91630599915c3c4b9e52d2659
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2575083
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
2020-12-07 09:07:59 +00:00
Simon Zünd a37afbf4ab Roll deps from Chromium into DevTools
Generated by:
 1) './scripts/deps/roll_deps.py'
 2) 'npm run generate-protocol-resources'

Manual modifications to make TS happy:
 - AccessibilityStrings.js, add UI strings for the new enum value.
 - NetworkManager.js, implement empty handlers for new protocl events.

DISABLE_THIRD_PARTY_CHECK=Manual roll

Change-Id: I570c0a4e24ced581edc78fff8d3c0f1d4485ba42
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566794
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2020-12-01 10:55:15 +00:00
Sigurd Schneider 063545441e Update protocol
DISABLE_THIRD_PARTY_CHECK=protocol update

Also introduces a new resource type (otherwise the front-end
type checks break).

Change-Id: I088058e25881b097b1d0f7d63cef391dcce50434
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2562341
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
2020-11-26 15:51:24 +00:00
Sigurd Schneider 66497ccc5f Generate inlined enums for protocol events in Protocol.<domain>
Previously, only inlined enums for commands were generated. This allows
several twin definitions to be removed from the front-end code, easing
the maintainance burdon of having to keep them in sync. See e.g.
https://crrev.com/c/2562339

Change-Id: I48ad1082ae8ecd3a657f61530e1795c61792ac56
Bug: chromium:1153099
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2562338
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-11-26 14:39:54 +00:00
Alex Rudenko c88c76b465 Implement APCA contrast in inspector overlay
This CL adds APCA contrast to the overlay and reduces some code
duplication between the frontend and the overlay.
APCA contrast will be shown if the experiment is enabled.

Depends on the backend CL: https://crrev.com/c/2545509

Bug: 1121900
Change-Id: I663116289cf4df6358f2aff83a857de06aac901d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2546705
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2020-11-20 17:03:21 +00:00
Alex Rudenko 7b66decf2b Update CDP
Contains the result of running:

scripts/deps/roll_deps.py && npm run generate-protocol-resources
in the devtools frontend repo.

DISABLE_THIRD_PARTY_CHECK=cdp update

Bug: 1121900
Change-Id: I6679e4c779d9d400860e4398eace34ee2fc6c421
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2550690
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2020-11-20 13:17:28 +00:00
Wolfgang Beyer 51ee90469d Update DevTools protocol
DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: 1139949
Change-Id: Id718e8e6c605983be17887ac8fefde0ee2b3c92c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2549789
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
2020-11-19 12:10:14 +00:00
Alfonso Castaño 7a13f66803 Protocol update for Breakpoints on Trusted Type violation
DISABLE_THIRD_PARTY_CHECK=<reason>
Backend_CL:https://chromium-review.googlesource.com/c/chromium/src/+/2517519
Bug: chromium:1142804
Change-Id: I192ae8b2fb2e0b9f072a4a3c54e5d580883fe10c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2520824
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
2020-11-18 16:24:33 +00:00
Alex Rudenko 42bab2c79c Roll deps and update protocol definitions
This CL contains the result of running:

scripts/deps/roll_deps.py && npm run generate-protocol-resources

DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: 1145997
Change-Id: I604eb0af3b1ba1ba124335a9c06b6afd2d8873d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2544139
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2020-11-17 13:44:59 +00:00
Alfonso Castaño dd0530c078 Introduce CSPViolation as pause reason (Devtools)
This CL adds the CSPViolation pause reason.
Such an enum will be used to enable breakpoints on Trusted Type violations.

DISABLE_THIRD_PARTY_CHECK=protocol update

Design doc: https://docs.google.com/document/d/1rlRtq_Ai0leS9sqlRvoOL5RNc1BR6Q1yAVvLLJFasMA/
Backend CL: https://chromium-review.googlesource.com/c/v8/v8/+/2519513
Follow-up CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2517571
Bug: chromium:1142804
Change-Id: I9936bd120658f115b035fad7e60d531535b14693
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2520827
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
2020-11-17 10:18:38 +00:00
Wolfgang Beyer a36129e3ea Update protocol to handle new CDP event
Updates protocol including dispatchers to handle newly added
`Page.documentOpen` CDP event.

Backend CL: https://crrev.com/c/2498482

Bug: chromium:1140540, chromium:1140481

DISABLE_THIRD_PARTY_CHECK=protocol update

Change-Id: Idf75e9101508923f83abb2525116611b4e2ff7a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2507793
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
2020-11-13 08:59:33 +00:00
Patrick Brosset e3cdc109f4 Rolling DevTools deps
This change is the result of running
scripts/deps/roll_deps.py && npm run generate-protocol-resources
in the devtools frontend repo.

This is needed to bring over a protocol change I made recently for the
flex overlay.

DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: 1139949
Change-Id: I5598cedfdcdca52110b1ac240d42c85faa72b080
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2532734
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
2020-11-12 10:54:40 +00:00
Patrick Brosset 84c06414bb Rolling DevTools deps
This change is the result of running
scripts/deps/roll_deps.py && npm run generate-protocol-resources
in the devtools frontend repo.

This is needed to bring over a protocol change I made recently for the
new flex overlay.

DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: 1139949
Change-Id: I6e5d95fd4786c06d19ef5ede866b92b60b3f5a3f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2520534
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
2020-11-05 11:37:31 +00:00
Sigurd Schneider 953916c4e1 Update browser_protocol.pdl
DISABLE_THIRD_PARTY_CHECK=Update protocol

Back-end CL: https://crrev.com/c/2514378

Bug: chromium:1139899
Change-Id: Ic0193dbb7a4c217ccbe8217b90c3ae96afb347d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2514440
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2020-11-04 15:23:28 +00:00
Alex Rudenko 288d902a06 Roll deps and update protocol definitions
This CL contains the result of running:

scripts/deps/roll_deps.py && npm run generate-protocol-resources

DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: 1130556
Change-Id: I6525e0f23a1702645cceb70e0255f75f648364b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2510390
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2020-10-30 15:22:58 +00:00
Sigurd Schneider 0fa81964c2 Update protocol definitions
DISABLE_THIRD_PARTY_CHECK=Update Protocol Definitions

Chromium CL: https://crrev.com/c/2497444

Bug: chromium:1141824
Change-Id: I39cea613f3e796f604b14973376ff6c9e3f64c3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2505902
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2020-10-29 11:54:32 +00:00
Songtao Xia 160e3844d9 Roll-deps and generate protocol resources.
To bring in newest CDP changes manually.

Result of roll_deps and generate_protocol_resources.

DISABLE_THIRD_PARTY_CHECK=Update protocol

Change-Id: I11407f3870c58dec74e5a8670023a670ea4afc98
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2497529
Commit-Queue: Songtao Xia <soxia@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-10-27 02:15:07 +00:00
Sigurd Schneider 7854287f1b Update browser_protocol.pdl
DISABLE_THIRD_PARTY_CHECK=actual protocol update

Change-Id: I9e2e893e58215e4beb29b74a969240f09440cbe4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2489423
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2020-10-21 08:47:35 +00:00
Alfonso Castaño 1227ffd795 Add isReportOnly field to CSP Issue messages in CDP
DISABLE_THIRD_PARTY_CHECK=<Introduce report-only field in CDP issues>

Bug: chromium:1139223
Change-Id: I7e315fd6645b4db50b2989e8e6da0afd26577e1c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484720
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
2020-10-20 16:17:24 +00:00
Tim van der Lippe 3c7eedcd60 Remove all definitions of usesObjectNotation
This was a temporary method, used during the migration to use
objects in dispatcher callbacks. Since all dispatchers now receive
the event as an object, we can remove these temporary methods.

R=aerotwist@chromium.org

Fixed: 1138492
Bug: 1011811
Change-Id: Ib7fbfae567ebc9b2be0a5d760458e5b0c7edc12e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484723
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-10-20 10:59:51 +00:00
Sigurd Schneider 9e2b7e3211 Update protocol
DISABLE_THIRD_PARTY_CHECK=protocol update

Change-Id: Ie33d7bba7b4948c31b7d388e16aea88ca653e6c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2470624
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2020-10-14 09:25:40 +00:00
Simon Zünd 16639e3411 Update DevTools protocol
DISABLE_THIRD_PARTY_CHECK="protocol update"

Change-Id: Iea06233eb9daaf06a773e79c049bcef42e673fb5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2466180
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2020-10-13 07:51:28 +00:00
Patrick Brosset e9448dfbe9 Rolling DevTools deps
This change is the result of running
scripts/deps/roll_deps.py && npm run generate-protocol-resources
in the devtools frontend repo.

This is needed to bring over a protocol change I made recently for the
initiator object to also contain column information.

DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: 1134064
Change-Id: Ic8c6aa6e7e0939ecffcef980988fc0a0c48b24d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2451694
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
2020-10-06 12:28:34 +00:00
Wolfgang Beyer 5893cf5633 Update protocol
DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: chromium:1107766
Change-Id: I6c3f0ca9d5b5493bf6241dc7fd3901fa44ba0f72
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2440478
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
2020-10-01 10:56:06 +00:00
Sigurd Schneider 97aa888172 Update DevTools protocol
DISABLE_THIRD_PARTY_CHECK=protcol update

Bug: chromium:1069378
Change-Id: I35d2a4d783c9fa8eb041622aebe12a161ba216d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2428891
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2020-09-24 15:47:26 +00:00
Sigurd Schneider fcd0fd47bd Update protocol
DISABLE_THIRD_PARTY_CHECK=Actually updates the protocol

Bug: chromium:1051466
Change-Id: I26fecdee83f0b640b0c60b2a3940b070690f4bf8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2416508
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2020-09-21 12:20:30 +00:00
Patrick Brosset 6f3b86ef7f Rolling DevTools deps
This CL is the result of running the roll_Deps.py script.

DISABLE_THIRD_PARTY_CHECK=Update protocol

Change-Id: I7d284adfc099e80493fed0810f60462bae3dad10
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2413039
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
2020-09-16 16:36:07 +00:00
Tim van der Lippe 662c01bba2 Remove ProtocolProxyApiWorkaround
The upstream issue has been fixed in TypeScript 4 and therefore this workaround
is no longer necessary.

R=sigurds@chromium.org

Change-Id: I4a831566f3a7f7756f8938668c38e5fabe2ca14c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2367947
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
2020-08-21 14:10:19 +00:00
Sigurd Schneider 8277d4dd06 Update protocol defintions
DISABLE_THIRD_PARTY_CHECK=update protocol

Bug: chromium:1051466
Change-Id: I87d34a672f73936d46741a947f83c21f195fdedd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2364595
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2020-08-19 15:56:58 +00:00
Sigurd Schneider 141bdf7164 Update protocol
DISABLE_THIRD_PARTY_CHECK=protocol update

Bug: chromium:1051466
Change-Id: I2222517db877e10681511a9d967e41ba12244bad
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2362572
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2020-08-18 15:23:38 +00:00
Alex Rudenko 70bcd61734 Update CDP
Contains the result of `scripts/deps/roll_deps.py && npm run generate-protocol-resources`

DISABLE_THIRD_PARTY_CHECK=Update protocol

Change-Id: I74e32fac3a156b5fe9056f7751ba1cc179bb26d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2349173
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2020-08-11 12:52:41 +00:00
Paul Lewis 6d4ebb2006 Reland "Reland "Updates elements to devtools_module""
This reverts commit 340bd16cd3.

Reason for revert: devtools_pre_built no longer makes hardlinks

Original change's description:
> Revert "Reland "Updates elements to devtools_module""
> 
> This reverts commit 04858cf7dd.
> 
> Reason for revert: This seems to trigger the known issue that 
> TSC is rewriting source files because of left-over hard-links.
> See https://ci.chromium.org/p/devtools-frontend/builders/ci/Stand-alone%20Linux/2582
> 
> To reproduce locally, check out the commit before this revision,
> do a clean build, then check out this revision, and do a build.
> This will succeed but rewrite source files (which it shouldn't).
> 
> 
> Original change's description:
> > Reland "Updates elements to devtools_module"
> > 
> > This reverts commit 22d876ca02.
> > 
> > Reason for revert: Build issues on bots should be fixed
> > 
> > Original change's description:
> > > Revert "Updates elements to devtools_module"
> > > 
> > > This reverts commit 81e818fad8.
> > > 
> > > Reason for revert: Anticipating build errors on bots
> > > 
> > > Original change's description:
> > > > Updates elements to devtools_module
> > > > 
> > > > Bug: 1101738
> > > > Change-Id: I294d366c95a3b5dc7ac5b757855846a7b31ac60b
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2329779
> > > > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > > > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> > > 
> > > TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
> > > 
> > > Change-Id: I3e36a1520e34be3ce1779ecdf2b4cead6a293971
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1101738
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332815
> > > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> > > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> > 
> > TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
> > 
> > # Not skipping CQ checks because this is a reland.
> > 
> > Bug: 1101738
> > Change-Id: Ia0d06bb75f2610459f4d0b31ff6b770b1031d982
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2335060
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> 
> TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
> 
> Change-Id: Iabfbe2aad94033078eac41338d64ca069f49332f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1101738
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2335273
> Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>

TBR=sigurds@chromium.org,aerotwist@chromium.org,jacktfranklin@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1101738
Change-Id: I42579d6cac06ec45377789253588ba94ee72a226
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2336715
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-08-10 09:15:45 +00:00
Kateryna Prokopenko 37009c358b [issues] Protocol update for element handling
DISABLE_THIRD_PARTY_CHECK=<Add element handling>

Bug: chromium:1082628
Change-Id: I8f3a6c9c91aaf075fe7a7b4b2eedc2fec04a87fe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2288700
Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2020-08-06 14:24:17 +00:00