This CL turns on the use_theme_colors stylelint rule which enforces that
any colors use variables defined in our codebase.
There are many, many violations, unsurprisingly (about 1500), so for now
I have disabled every single violation. The goal of the dark mode
migration will be in part to remove all violations of this rule.
Additionally, new code going forwards should adhere to the rule and not
add the comment to disable the warning.
Bug: 1152736
Change-Id: I51372724ea51485daef3d4f75b7d3f60a7c8016f
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2671323
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
The What's New tool (internally known as the Help module)
features a list of release notes where each release note is a link to
an external document.
Before: https://imgur.com/a/nJNVMb9
After: https://imgur.com/a/81FLMr3
A light border and margin have been added to each entry in the list
to better distinguish the individual entries. In high contrast mode,
the border color changes to blue on hover to mimic button behavior.
The text color has also been changed to hyperlink text color to
indicate each note is an external link.
Change-Id: Iaa7514a2a2b86ec3e08b50c36b5ae26972310f96
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2032381
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Jack Lynch <jalyn@microsoft.com>
Commit-Queue: Brian Cui <brcui@microsoft.com>
This CL improves the accessibility of the What's New Tool
to better support keyboard navigation and screen readers.
- Release note list now has a label corresponding to the release note
header that is read aloud when the list is accessed.
- Release note list item contents have been modified to be a single
x-link element that wraps both the title and subtitle,
instead of two x-link elements for title and subtitle.
This allows the title and subtitle to be treated as a single list
element accessible by pressing the tab key and read aloud together,
instead of two list elements read separately and requiring
the tab key to be pressed twice.
- Keyboard access to the image link is disabled, as clicking on it
links to the same page as the Learn More button but otherwise
lacks a description of its own.
Before: https://i.imgur.com/CeUE3it.gif
After: https://i.imgur.com/sX9lW1E.gif
Bug: 963183
Change-Id: I0e209c445f9ee6915f7dc0274437d70d9d9adf0b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1968014
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
Commit-Queue: Brian Cui <brcui@microsoft.com>
Jack Franklin
