Jack Franklin
49a9481a74
Lint color usage in background and border-* properties.
...
The list of CSS properties we check for colors wasn't thorough and
didn't include `border-left/right/top/bottom` or `background` on its
own. This CL fixes that and disables the rule for any current
violations.
Bug: 1152736
Change-Id: Ic732d653fdfab0462a04dc891bcece1f44e5d471
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676157
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
2021-02-05 15:39:39 +00:00
Jack Franklin
8064d3ba7a
Lint against non-theme-color variables
...
This CL turns on the use_theme_colors stylelint rule which enforces that
any colors use variables defined in our codebase.
There are many, many violations, unsurprisingly (about 1500), so for now
I have disabled every single violation. The goal of the dark mode
migration will be in part to remove all violations of this rule.
Additionally, new code going forwards should adhere to the rule and not
add the comment to disable the warning.
Bug: 1152736
Change-Id: I51372724ea51485daef3d4f75b7d3f60a7c8016f
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2671323
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2021-02-03 11:02:09 +00:00
Jack Franklin
fd9dfaa5e7
[Dark mode] replace #fff background-color
...
This CL searches for CSS that matches:
- background: #fff
- background: #ffffff
- background: #white
- background-color: #fff
- background-color: #ffffff
- background-color: #white
And replaces the declaration with var(--color-background) from the new
set of color variables.
Bug: 1152736
Change-Id: Ia0575ccfa4e23c92fd4f83e6c911236dbb893fea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577559
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2021-01-11 16:18:06 +00:00
Michael Liao
59450acba8
[Font Editor]: Changing font weight for section titles
...
Issue:
- Font Editor section titles are unusually bold - doesn't fit other heading conventions in the DevTools
Changes:
- change section title font weight to be normal
Before: https://imgur.com/HN64Jqp
After: https://imgur.com/uugug1S
Bug: 1163821
Change-Id: I062ed8efb3101ccb93aa195e13bd993ae4bdc420
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2613795
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Michael Liao <michael.liao@microsoft.com >
2021-01-08 18:47:07 +00:00
Michael Liao
6035f4a583
[Font Editor Prototype]: Implements Experimental Typography CSS Editor in Styles Pane
...
Reference Document: https://docs.google.com/document/d/1zvmKDfdgVgL-QX2W4nKfgoeG_69YDF0AsLerIzL3rPE/edit?usp=sharing
Explainer: https://docs.google.com/document/d/1TmvbZuJR4fHuViE0X23y_1kUT43qt98mdj5GZxWf_W0/edit
Bug: 1093229
Change-Id: I0a8d049bd564a5ba547466067a12185565af7820
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2305613
Commit-Queue: Michael Liao <michael.liao@microsoft.com >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Songtao Xia <soxia@microsoft.com >
Reviewed-by: Tony Ross <tross@microsoft.com >
Reviewed-by: Shane Clifford <shanejc@microsoft.com >
2020-12-01 19:54:05 +00:00
Jack Franklin