zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-09 21:28:43 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
54 Commits
Author SHA1 Message Date
Jack Franklin 6b7065cfd3 [DarkMode] inputTimeline.css 
Bug: chromium:1152736
Change-Id: I8c1a64b049ce5142ac184e5f5121e7f7e289cb94
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692770
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-02-16 09:38:59 +00:00
Peter Marshall 428508ab36 [l10n] Remove unused ModuleUIStrings files 
As directories are migrated to the new -meta files, they no longer
need their ModuleUIStrings file.

Bug: 1136655
Change-Id: Iae983195fa24f6262d1d47d6093e82f4ce3df537
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2686658
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-10 16:37:51 +00:00
Tim van der Lippe f1d02ad898 Remove sdk/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: Ic4d840aff08bcbc4b5aaf4f98e1a7e8a5c7882f6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2682479
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-02-09 16:00:18 +00:00
Tim van der Lippe 5c423509db Remove i18n/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: I700e6d5fc8941ef54d4af10af01989ddf62165cc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676144
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-02-05 10:48:08 +00:00
Peter Marshall f2e07d7ca8 [l10n] Ensure .ts files are checked for LocV1 calls 
.ts files go through a different code path to .js files and weren't
subject to a migrated directory check, meaning .ts files could still
contain ls`` calls even when their containing directory had been
migrated already.

This fixes the existing violations and adds the check for .ts files
so that presubmit will complain in the future.

Fixed: 1174505
Change-Id: Ic76c4c0634ac279bb27a131f891d3a3b9490c3f4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2673829
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-02-05 10:18:58 +00:00
Sigurd Schneider 1576186355 Enforce member delimiters 
This CL enforces member delimiters following
https://google.github.io/styleguide/tsguide.html#member-property-declarations

Bug: chromium:1057042
Change-Id: I2553aeebb8187235cdf0e7f0585da36ea53388bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2672032
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-04 09:03:57 +00:00
Sigurd Schneider 9c07567fdd Properly enable dangling comma conventions in TypeScript 
The eslint rule 'comma-dangle' isn't enough to enforce dangling
commas in TypeScript, we must use '@typescript-eslint/comma-dangle'
instead.

Bug: chromium:1174055
Change-Id: I589e1016ab578c965b54f17da3eab7ea542a2f7a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2672028
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-03 14:01:11 +00:00
Andres Olivares a7b7b4946a Reland "[module.json extensions] input actions" 
This reverts commit 6d0c7a8f26.

Reason for revert: The original CL was failing as a side effect of an issue solved in https://chromium.googlesource.com/devtools/devtools-frontend/+/a1ee70e85e999910e91c5d8f79825a038546d9ae .

Original change's description:
> Revert "[module.json extensions] input actions"
>
> This reverts commit 5d81b459ad.
>
> Reason for revert: suspect for bot failure (https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/DevTools%20Linux/4109/overview)
>
> Original change's description:
> > [module.json extensions] input actions
> >
> > Bug: 1134103
> > Change-Id: I61171ea3ac69b2123f0f604527f6ad5df8c3911c
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2650515
> > Commit-Queue: Andres Olivares <andoli@chromium.org>
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
>
> TBR=tvanderlippe@chromium.org,andoli@chromium.org
>
> Change-Id: Ib4e25bf1a27bd4a079eaedc6b75631b9b4bc3993
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1134103
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2653091
> Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>

TBR=tvanderlippe@chromium.org,wolfi@chromium.org,andoli@chromium.org

Bug: 1134103
Change-Id: Id557985dd9a298549deff3746e944794066fdcf2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2656116
Reviewed-by: Andres Olivares <andoli@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2021-01-28 16:56:41 +00:00
Wolfgang Beyer 6d0c7a8f26 Revert "[module.json extensions] input actions" 
This reverts commit 5d81b459ad.

Reason for revert: suspect for bot failure (https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/DevTools%20Linux/4109/overview)

Original change's description:
> [module.json extensions] input actions
>
> Bug: 1134103
> Change-Id: I61171ea3ac69b2123f0f604527f6ad5df8c3911c
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2650515
> Commit-Queue: Andres Olivares <andoli@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=tvanderlippe@chromium.org,andoli@chromium.org

Change-Id: Ib4e25bf1a27bd4a079eaedc6b75631b9b4bc3993
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1134103
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2653091
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-01-27 18:04:01 +00:00
Andres Olivares 5d81b459ad [module.json extensions] input actions 
Bug: 1134103
Change-Id: I61171ea3ac69b2123f0f604527f6ad5df8c3911c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2650515
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-27 13:59:50 +00:00
Andres Olivares f138902e8f Change commandPrompt type to LocalizedString in ViewRegistration 
Bug: 1169065, 1134103
Change-Id: If647a6f51309f87f3da8a895c96db463494554d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2642909
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-25 18:00:55 +00:00
Andres Olivares 4ce36a5a37 [module.json extensions] Wrap localizable fields in anonymous functions 
To be able to localize extensions' strings at declaration using the i18n
v2 model in meta files, we opt to wrap such fields in callbacks as the
i18n API cannot be invoked directly at declaration because it hasn't
been configured by the time the meta files are loaded.

Bug: 1134103
Change-Id: I432f3854f724b8c5b94993ce3ddd469f657c1014
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635820
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 19:04:06 +00:00
Jan Scheffler 86e4bd2600 [JSDOC2TS]: Migrate input 
Bug: chromium:1158760
Change-Id: I750a19ecfdfc7ca59929cb3d178f06b33d8b084d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2630946
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 19:00:19 +00:00
Andres Olivares f125cbd2cc [module.json extensions] input views 
Bug: 1134103
Change-Id: Ia9ea0ccad3064a3c80a9902206a4b977b908df86
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629729
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-15 14:33:00 +00:00
Tim van der Lippe d7cfd14814 Fix no-implicit-coercion errors in front_end/ 
R=jacktfranklin@chromium.org

No-Presubmit: True
Bug: 1082789
Change-Id: Ic77884bf7e9b5dc74053915b3b10699368841b66
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2595268
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-07 12:40:16 +00:00
Christy Chen 87d9ffc323 [Loc] Migrate input to Localization V2 
Bug: 1136655
Change-Id: I7d8b1c34aaea07b896ec913faf141381422c3bd6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2580848
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-09 17:59:07 +00:00
Tim van der Lippe e4d64e7ae0 Remove unrestricted from comments that include other annotations 
For all comments that contained both the unrestricted annotation
and any other potential annotation, remove only the unrestricted
annotation.

R=szuend@chromium.org

No-Presubmit: True
Bug: 1011811
Change-Id: I27dd67f657cdb1a9233d768eea81cabe2591f5f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569759
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-02 15:31:52 +00:00
Tim van der Lippe 7dcef88d8b Remove skip_compilation from module.json files 
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I4c4fd280adb4f5f7b327239d08d80b2cb98b203b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560248
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-25 13:19:08 +00:00
vidorteg af634bcc6c [Loc] Migrate animation panel to Localization V2 
- Migrate animation panel to use Localization V2 APIs.
- Removed animation grdps

Tested with en-XL.json
https://imgur.com/a/eVERZjZ

Bug: 1136655
Change-Id: I71fdcff68757b13ed72d735644ef09c6609f54d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548263
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-11-21 02:28:13 +00:00
Tim van der Lippe c128b354ef Use TypeScript-authored files in input/ 
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I3b8ab44fc5a10b5ecaef9b3b5c40f73cd9deb35f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2546716
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-19 17:24:44 +00:00
Tim van der Lippe 54a335279b Typecheck input/InputTimeline.js with TypeScript 
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I8716b6a9a93eee019bca5e5e0d62299175da74f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2546714
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-11-18 17:00:12 +00:00
Andres Olivares 6ff6d04308 Refactor ui/Action.js into ui/ActionRegistration.js and update dependencies accordingly 
Bug: 1134103
Change-Id: I2ed7656af264f60c45f1a4143c14203afdbf6f68
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2521638
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-17 16:58:16 +00:00
Jack Franklin 71519f8efb Introduce enableLegacyPatching flag for CSS patching 
As part of the dark mode migration we are adding
`enableLegacyPatching:true` to all call sites of `appendStyle` (and
related methods). If a user passes `false` for that flag, no CSS colour
patching will occur.

This CL is therefore a no-op from a user's perspective as we pass `true`
on every call to maintain existing behaviour, but once we start
migrating we will turn the option to `false`. Long term, once all code
is migrated and the old patching is removed, we will remove this flag
entirely once again.

Bug: 1122511
Change-Id: I76b818e83b7d5ee0175e1548759373f53481e0ab
No-Presubmit: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2516345
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-03 14:11:46 +00:00
Tim van der Lippe 4efa41ab8e Typecheck input/InputModel.js with TypeScript 
R=sigurds@chromium.org

Bug: 1011811
Change-Id: I21a7edeae07024c75596ef6b37b7138d364e2f8e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2502615
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-10-28 11:52:34 +00:00
Yang Guo ef36cec5b9 Apply governance change 
DISABLE_THIRD_PARTY_CHECK=no code changes
R=bmeurer@chromium.org

Change-Id: I2477c36f5ef2494ccae3efae3f1aee942f365fec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2489420
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-10-21 07:54:15 +00:00
Tim van der Lippe 46e1bcace9 Remove pre_generates_legacy from module.json files 
This was a temporary flag used during the build_release_applications
to GN migration.

R=aerotwist@chromium.org

Bug: 1131500
Change-Id: I8a772bcc4bee31dbd3270bf7ef62d8c97941024a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484716
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-10-19 16:12:09 +00:00
Tim van der Lippe 42fbb0aca2 Move legacy files from model modules to GN 
R=aerotwist@chromium.org

Bug: 1131500
Change-Id: I28b598c770801947eace05164e5308c621f5407a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2476334
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-10-16 10:58:47 +00:00
Tim van der Lippe cac65d4fa0 Remove skip_rollup 
This was a temporary flag as part of the devtools_entrypoint migration.
Since that migration has concluded, we can now remove all references
to it and clean up `build_release_applications.py`.

R=jacktfranklin@chromium.org,aerotwist@chromium.org

Bug: 1101738
Change-Id: I3ef9ec1a99bc9fc1758532124db22b3b4b1a5e2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391140
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-08 15:44:09 +00:00
Tim van der Lippe 19a45dfd55 Remove is_legacy_javascript_entrypoint 
This removes the now-obsolete is_legacy_javascript_entrypoint build flag,
which was used as part of the devtools_entrypoint migration.

This uncovered that accessibility was still using devtools_pre_built
and a file was missing from the GRD variable.

R=aerotwist@chromium.org,jacktfranklin@chromium.org

Fixed: 1101738
Change-Id: Ie1556ccc1d1563c855417de18e896308de0cfe19
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2356305
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-08-28 12:32:29 +00:00
Tim van der Lippe 177c0b260b [globals] UI.ActionRegistry 
R=jacktfranklin@chromium.org

Bug: 1058320
Change-Id: I86fdc670c6667f37bfced2d9068106ec553d2210
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2364370
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-08-19 15:24:18 +00:00
Jan Scheffler da950e3d54 Migrate front_end/input to devtools_entrypoint 
R=aerotwist@chromium.org, jacktfranklin@chromium.org

Bug: 1101738
Change-Id: Iec811144cf8f0da52a4af14735b91bac1b5c42ad
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332216
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-08-03 17:03:48 +00:00
Tim van der Lippe 37512b0d25 Remove empty script arrays from module.json files 
If the module uses `modules` to load the JavaScript files, then
we can remove the `scripts` array altogether. Note that there
are still some modules left that use `scripts`, most notably
the `lighthouse_worker`, which is a remote module.

R=aerotwist@chromium.org

Bug: 1105476
Change-Id: Ie303e9835f5ce6d42ccae7b3a305d8f3df1af84c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2302597
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-07-17 10:05:33 +00:00
Tim van der Lippe 1b2c52bbfa Remove tvanderlippe@ as explicit OWNER from several front_end subfolders 
As part of the initial seeding of the OWNERS, the automated scripts added
myself as OWNERS to pretty much every single folder in `front_end/`. This
is an artifact of the widespread infrastructure I have done, with in
particular the ES Modules migration that touched every single file in
DevTools.

In the past few weeks, several times I have received CLs were I was asked
to perform a domain review on the feature in question. Most of the time,
I have no knowledge of that particular feature.

To reduce confusion and roundtrips asking for different domain reviewers,
I removed myself as explicit OWNERS of these files. Note that I can still
use my INFRA_OWNERS to land changes, but as usual these are infra-only.
E.g. these will include the larger refactorings that span multiple features,
but not a single feature in particular.

I have kept myself OWNERS of folders that are part of the core
architecture of DevTools, as I am comfortable reviewing these as domain
reviewer.

R=yangguo@chromium.org,aerotwist@chromium.org

Change-Id: Ib1be70b97c5395498795b4b28ce7001731305d41
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2282516
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2020-07-06 12:36:21 +00:00
Yang Guo fc2a45b993 Seed more owners 
DISABLE_THIRD_PARTY_CHECK=Adding OWNERS files

Bug: chromium:1082687
Change-Id: If9a388bd7bfbd10374f601c35f18ca40289e0da4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2236401
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Shane Clifford <shanejc@microsoft.com>
Reviewed-by: Leo Lee <leolee@microsoft.com>
 2020-06-10 07:56:51 +00:00
Simon Zünd 2c704cdc72 [cleanup] Move Date#toISO8601Compact to DateUtilities 
R=jacktfranklin@chromium.org

Bug: chromium:1050549
Change-Id: I445d6d0670ecfc2efa6ecae350b3bc48c1ddce96
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2228524
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-06-04 10:30:01 +00:00
Mathias Bynens b0c1f4bce2 Fix stylelint-config-standard violations 
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-05-15 17:05:27 +00:00
Mathias Bynens 5e43b27e8b Reformat module.json files 
This patch makes it so that all module.json files use the same
consistent indentation that matches .editorconfig and the rest
of the codebase. At the request of reviewers, one such file
(front_end/emulated_devices/module.json) has been excluded
from this patch. It will be reformatted in a separate CL.

Note that this patch does not “roll CodeMirror”, although a
pre-commit hook forces me to include that phrase in the commit
message because the module.json file in the relevant folder is
modified.

Bug: chromium:1070492
Change-Id: Ib31ed5232461e2f80bf05f31105fc919f6639b0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127007
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-04-14 05:35:23 +00:00
Jack Lynch 4ff1b1de0e Hide experimental actions 
Some actions are being loaded by the DevTools even though they depend on
code that's hidden behind an experiment. This can cause unhandled
exceptions if a user tries to execute one of them, and will pollute the
future custom keyboard shortcut list with unusable actions. To avoid
that, this CL adds experiment attributes to those actions.

Bug: 174309
Change-Id: I3da5661af95798fdaaafc08fcc6f4d393690a93f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2099437
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Jose Leal <joselea@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
 2020-03-27 01:27:49 +00:00
Paul Lewis 75c7d0decc [global] Remaps self.UI.viewManager 
Moves self.UI.viewManager to an instance() method.

Bug: 1058320
Change-Id: I0c444101da59ba9eba4745d1dc551bb8906a0a4f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107624
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-03-19 12:39:32 +00:00
Simon Zünd 182134236e Rename namespace import for protocol_client to ProtocolClient 
R=tvanderlippe@chromium.org

Bug: chromium:1011811
Change-Id: Idf3e9eb8f6d52db78f563de53b7576ec6c9b9cdc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107557
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-19 12:08:52 +00:00
Simon Zünd 3b0c540211 Rename front_end/protocol to front_end/protocol_client 
This CL is part of the work to switch over to the TypeScript compiler
for type checking.

R=tvanderlippe@chromium.org

Bug: chromium:1011811
Change-Id: Ic709a193b252df7e9027c00cf20d8afe525a215a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107539
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-18 18:06:20 +00:00
Tim van der Lippe 1cf8e42e6d Migrate typedefs in {event_listeners,extension,formatter,heap_snapshot_worker,help}-legacy.js 
Bug: 1006759
Change-Id: Ic2e3b5d8ece70a14cf067c79a14e3695382fa75b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2100910
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-03-12 17:37:01 +00:00
Paul Lewis daac106699 [global] Remaps self.SDK.targetManager 
This CL changes references to self.SDK.targetManager (the global
instance of SDK.SDKModel.TargetManager) over to
SDK.SDKModel.TargetManager.instance(). To keep both TypeScript and
Closure happy we must make a method on the TargetManager class itself,
since it only allows private constructors to be accessed by static
methods on the class.

Bug: 1058320
Change-Id: I6ca35024c21cf24254fd6273138a1ab3e163ee00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2088092
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-05 14:58:03 +00:00
Tim van der Lippe 37a35fff86 Reland "Typecheck Object.js" 
This reverts commit f996a1c537.

Reason for revert: Fixed incorrect refactoring in this CL.

Original change's description:
> Revert "Typecheck Object.js"
>
> This reverts commit 258665aca5.
>
> Reason for revert: Suspected of breaking the roll (https://crrev.com/c/2083712)
> Bot failure: https://ci.chromium.org/p/chromium/builders/try/linux-rel/322462?
>
> Original change's description:
> > Typecheck Object.js
> >
> > To typecheck the file Object.js with Typescript I had to fix the type errors from all other classes
> > that were using addEventListener or removeEventListener incinsistently.
> >
> >
> >
> > Bug: 1011811
> > Change-Id: I2fccbbd07ef3d9a581baa34233580bc6a9dbbfc3
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2079794
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Commit-Queue: Jose Leal <joselea@microsoft.com>
>
> TBR=szuend@chromium.org,joselea@microsoft.com,tvanderlippe@chromium.org,jacktfranklin@chromium.org
>
> Change-Id: I30e3d75eee463362107d6e6ad25df2b7d50f9d54
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1011811
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2081824
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

Bug: 1011811
Change-Id: I19ebbe0345a5c7380ed69d1ba2921adf0385228e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2084580
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-03 14:09:44 +00:00
Simon Zünd f996a1c537 Revert "Typecheck Object.js" 
This reverts commit 258665aca5.

Reason for revert: Suspected of breaking the roll (https://crrev.com/c/2083712)
Bot failure: https://ci.chromium.org/p/chromium/builders/try/linux-rel/322462?

Original change's description:
> Typecheck Object.js
> 
> To typecheck the file Object.js with Typescript I had to fix the type errors from all other classes
> that were using addEventListener or removeEventListener incinsistently.
> 
> 
> 
> Bug: 1011811
> Change-Id: I2fccbbd07ef3d9a581baa34233580bc6a9dbbfc3
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2079794
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Commit-Queue: Jose Leal <joselea@microsoft.com>

TBR=szuend@chromium.org,joselea@microsoft.com,tvanderlippe@chromium.org,jacktfranklin@chromium.org

Change-Id: I30e3d75eee463362107d6e6ad25df2b7d50f9d54
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1011811
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2081824
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-03-03 05:59:28 +00:00
Jose Leal Chapa 258665aca5 Typecheck Object.js 
To typecheck the file Object.js with Typescript I had to fix the type errors from all other classes
that were using addEventListener or removeEventListener incinsistently.



Bug: 1011811
Change-Id: I2fccbbd07ef3d9a581baa34233580bc6a9dbbfc3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2079794
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jose Leal <joselea@microsoft.com>
 2020-03-02 18:15:06 +00:00
Mathias Bynens 23ee1aad0a Reconfigure lint rule w.r.t. quotes 
We prefer single quotes by default, but still want to allow double
quotes in cases where that helps avoid quote-escaping, and also want
to allow template literals in cases where string interpolation is
used. For example:

    const a = 'xxx';  // ok
    const b = "xxx";  // not ok, should use single quotes
    const c = "xxx'xxx";  // ok, double quotes avoid an escape sequence
    const d = `xxx`;  // not ok, frivolous use of template literal
    const e = `xxx ${42}`;  // ok

Per https://github.com/eslint/eslint/issues/12976, setting
the `allowTemplateLiterals` option for the `quotes` lint rule to
`false` gives us the desired behavior.

Note that the above lint rules are auto-fixed when running the linter;
there should be no need to manually make any changes to appease the
linter.

Per review feedback, this patch also removes the following escape
sequences for printable non-ASCII symbols:

- U+00D7 → ×
- U+2026 → …
- U+2019 → ’

Chromium CL temporarily updating test expectations:
https://chromium-review.googlesource.com/c/chromium/src/+/2083147

Cq-Depend: chromium:2083147
Bug: chromium:1057042
Change-Id: Id6bec3f96ca694d2fbc07dd8629fce305a58df8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2082372
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
 2020-03-02 16:18:16 +00:00
Tim van der Lippe b1f2b6cce6 Remove typedefs from {object_ui,network,layer_viewer,input,inline_editor}-legacy.js 
Bug: 1006759
Change-Id: I617f10f94b969a49a6d24bf00ba4f24409aa6211
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2060293
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-20 17:26:46 +00:00
Tim van der Lippe 8ef250cfe1 Remove typedefs from {perf_ui,persistence,protocol}-legacy.js 
Bug: 1006759
Change-Id: I577e754f3e49f20d44d2028a4872fac0dce05782
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2060290
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-02-20 17:09:06 +00:00
Ella Ge d09f6c82c9 Add save&load to input panel 
This CL adds the save and load button to input panel.
Save button will save the tracing as a json format file.
Load button will open a file selection and load the selected file as
the tracing (using the TimelineLoader in Timeline model).

Change-Id: I670e8ac4417ee2d7756574a7cd8305de864974d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2055739
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-02-18 17:04:46 +00:00