Sigurd Schneider
118e44db78
Cleanup IssueAggregator after JSDOC -> TS
...
Bug: chromium:1072335
Change-Id: I7065122fb40a9a49ee1be8f38e2db96578469fa7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692772
Reviewed-by: Simon Zünd <szuend@chromium.org >
Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
2021-02-15 11:48:13 +00:00
Sigurd Schneider
0ddc59337e
Refactor IssueView to a separate file
...
This change refactors the IssueView to a separate file and converts
IssuesPane to TypeScript.
Bug: chromium:1072335
Change-Id: Ibb9a6944858730fd8efa72b6b6da78df3c1851d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678099
Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org >
2021-02-08 09:16:09 +00:00
Christy Chen
c62d7a4460
[Loc] Migrate issues to localization V2
...
Migrate issues panel
Tested with en-XL: https://imgur.com/a/kEhfKAt
Bug: 1136655
Change-Id: I8801bf6b84d2355612133b82d15640b656a3d82e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2675006
Commit-Queue: Christy Chen <chrche@microsoft.com >
Reviewed-by: Peter Marshall <petermarshall@chromium.org >
2021-02-04 10:55:57 +00:00
Sigurd Schneider
f63bcdb7e3
Support anonymous script locations in SAB issues..
...
..and associate locations without script id with the right target.
Previously, we only resolved locations by URL, which may be ambiguous
in case several targets (think cross-origin iframes) reference the
resource.
Bug: chromium:1051466, chromium:1158753, chromium:1082628, chromium:1082628
Change-Id: If20e371aec03266b53b8f33551be7f696a6336c9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2656240
Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org >
2021-01-29 08:37:13 +00:00
Sigurd Schneider
286466e0c8
Reland "Show issues on SAB instantiation"
...
This reverts commit b3759d720b .
Reason for revert: A chrome test binary roll changed e2e test
behavior between running CQ on the CL and landing it.
Original change's description:
> Revert "Show issues on SAB instantiation"
>
> This reverts commit f366a4ca99 .
>
> Reason for revert: Fails on a lot of CQ and trybots.
> E.g.: https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/5128/overview
>
> Original change's description:
> > Show issues on SAB instantiation
> >
> > Bug: chromium:1051466
> > Change-Id: I39f1110d370e3d5cca801112c2b776f697875d64
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2652505
> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
> > Reviewed-by: Wolfgang Beyer <wolfi@chromium.org >
>
> TBR=sigurds@chromium.org ,jacktfranklin@chromium.org ,wolfi@chromium.org
>
> Change-Id: I8a6a8b7aa57be0521615f9569bfdcad86463d8d0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1051466
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2655246
> Commit-Queue: Simon Zünd <szuend@chromium.org >
> Reviewed-by: Simon Zünd <szuend@chromium.org >
TBR=sigurds@chromium.org ,szuend@chromium.org ,jacktfranklin@chromium.org ,wolfi@chromium.org
# Not skipping CQ checks because this is a reland.
Bug: chromium:1051466
Change-Id: Id3858c9b38d4f0dbcbc47dcc86500e8e27258305
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2655248
Reviewed-by: Sigurd Schneider <sigurds@chromium.org >
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
2021-01-28 11:50:08 +00:00
Simon Zünd
b3759d720b
Revert "Show issues on SAB instantiation"
...
This reverts commit f366a4ca99 .
Reason for revert: Fails on a lot of CQ and trybots.
E.g.: https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/5128/overview
Original change's description:
> Show issues on SAB instantiation
>
> Bug: chromium:1051466
> Change-Id: I39f1110d370e3d5cca801112c2b776f697875d64
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2652505
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
> Reviewed-by: Wolfgang Beyer <wolfi@chromium.org >
TBR=sigurds@chromium.org ,jacktfranklin@chromium.org ,wolfi@chromium.org
Change-Id: I8a6a8b7aa57be0521615f9569bfdcad86463d8d0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1051466
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2655246
Commit-Queue: Simon Zünd <szuend@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
2021-01-28 10:02:18 +00:00
Sigurd Schneider
f366a4ca99
Show issues on SAB instantiation
...
Bug: chromium:1051466
Change-Id: I39f1110d370e3d5cca801112c2b776f697875d64
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2652505
Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org >
2021-01-28 08:52:47 +00:00