zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-11 14:14:36 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
46 Commits
Author SHA1 Message Date
Sigurd Schneider 982ec5a825 Add CORS RFC-1918 issue 
Bug: chromium:1128885
Change-Id: Ia4fc5ee0fd03ad568eccc374db787dc705ee3cef
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2687501
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-02-12 08:45:19 +00:00
Tim van der Lippe f1d02ad898 Remove sdk/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: Ic4d840aff08bcbc4b5aaf4f98e1a7e8a5c7882f6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2682479
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-02-09 16:00:18 +00:00
Andres Olivares c3b9beaf2e [module.json extensions] @Common.Revealer Part 1 
Bug: 1134103
Change-Id: If3f28f0b3787facc1c967b221eaadd286c02851c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2681887
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-09 15:39:32 +00:00
Tim van der Lippe 54780f2bca Remove platform/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: I036bc21f0ebf7f2e65c7d9a89281c1fbcb4a9033
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676156
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-05 13:39:48 +00:00
Tim van der Lippe 79e4d8531a Remove host/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: I3015c907604c739ee3d50a003f47faa6861215ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676145
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-02-05 10:55:28 +00:00
Tim van der Lippe 5c423509db Remove i18n/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: I700e6d5fc8941ef54d4af10af01989ddf62165cc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676144
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-02-05 10:48:08 +00:00
Tim van der Lippe 49f2cf1f4e Remove common/module.json 
R=andoli@chromium.org

Bug: 1127902
Change-Id: Ie7556606b481d34e32fc46f684fa21fc04e1bd2d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676143
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-02-05 10:44:28 +00:00
Alex Rudenko d6594130ef Report low contrast issues 
This CL adds the logic to trigger contrast checks on DevTools
startup or on page load events. The check is only triggered if
the corresponding experiment (contrastIssues) is enabled.
Deduplication of the reported issues happens in the IssueManager
on the frontend since the same issue might be reported twice
if there are multiple documents on the target page.

Bug: chromium:1155460
Change-Id: Ib0d5115c527ceb9da9d2ed2dfa48cfdca6f82f60
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2573360
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2021-02-04 12:39:48 +00:00
Christy Chen c62d7a4460 [Loc] Migrate issues to localization V2 
Migrate issues panel
Tested with en-XL: https://imgur.com/a/kEhfKAt


Bug: 1136655
Change-Id: I8801bf6b84d2355612133b82d15640b656a3d82e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2675006
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-02-04 10:55:57 +00:00
Ella Ge f2e77172e6 Add Trusted Web Activity issue 
This CL adds the Trusted Web Activity issue to devtools issue tab.

Issue descriptions:
http://doc/1nlYeWlwCOva7M9EoT6YKQZ4s-Ug8aXbQIp4Oc1cL8WE/

Bug: 1147479
Change-Id: I977fd008c40f7c2fa249d1c73d285db0c3d54b28
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2650237
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2021-02-01 15:56:58 +00:00
Sigurd Schneider 4ef25778f2 Migrate HeavyAd issues to Markdown 
Drive-by: Fix whitespace in sharedArrayBuffer description.

Bug: chromium:1125465
Change-Id: I148c18a0821ee1e208323b331e4ae8b17df08fc4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2656236
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-29 10:47:13 +00:00
Sigurd Schneider 286466e0c8 Reland "Show issues on SAB instantiation" 
This reverts commit b3759d720b.

Reason for revert: A chrome test binary roll changed e2e test
behavior between running CQ on the CL and landing it.

Original change's description:
> Revert "Show issues on SAB instantiation"
>
> This reverts commit f366a4ca99.
>
> Reason for revert: Fails on a lot of CQ and trybots.
> E.g.: https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/5128/overview
>
> Original change's description:
> > Show issues on SAB instantiation
> >
> > Bug: chromium:1051466
> > Change-Id: I39f1110d370e3d5cca801112c2b776f697875d64
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2652505
> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
>
> TBR=sigurds@chromium.org,jacktfranklin@chromium.org,wolfi@chromium.org
>
> Change-Id: I8a6a8b7aa57be0521615f9569bfdcad86463d8d0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1051466
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2655246
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

TBR=sigurds@chromium.org,szuend@chromium.org,jacktfranklin@chromium.org,wolfi@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: chromium:1051466
Change-Id: Id3858c9b38d4f0dbcbc47dcc86500e8e27258305
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2655248
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-01-28 11:50:08 +00:00
Simon Zünd b3759d720b Revert "Show issues on SAB instantiation" 
This reverts commit f366a4ca99.

Reason for revert: Fails on a lot of CQ and trybots.
E.g.: https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/5128/overview

Original change's description:
> Show issues on SAB instantiation
>
> Bug: chromium:1051466
> Change-Id: I39f1110d370e3d5cca801112c2b776f697875d64
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2652505
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>

TBR=sigurds@chromium.org,jacktfranklin@chromium.org,wolfi@chromium.org

Change-Id: I8a6a8b7aa57be0521615f9569bfdcad86463d8d0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1051466
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2655246
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-28 10:02:18 +00:00
Sigurd Schneider f366a4ca99 Show issues on SAB instantiation 
Bug: chromium:1051466
Change-Id: I39f1110d370e3d5cca801112c2b776f697875d64
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2652505
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-01-28 08:52:47 +00:00
Andres Olivares 5135060ac7 [module.json extensions] issues views 
Bug: 1134103
Change-Id: I0a919093cf3463f248a50aaf3152c903928570af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2630305
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 18:29:56 +00:00
Simon Zünd ffbee0e2c4 [issues] Migrate SameSite issues to markdown 3/3 
R=bingler@chromium.org, wolfi@chromium.org

Bug: chromium:1125465
Change-Id: I43d7c3a62983648c195649c5e560366d6c6c5b7b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2599553
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Steven Bingler <bingler@chromium.org>
 2020-12-22 07:43:17 +00:00
Simon Zünd 622b057c2e [issues] Migrate SameSite issues to markdown 2/* 
R=bingler@chromium.org, wolfi@chromium.org

Bug: chromium:1125465
Change-Id: Ia7ef6376101afef5da09dae760596b1e2aece42a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2599549
Reviewed-by: Steven Bingler <bingler@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-12-22 07:39:26 +00:00
Simon Zünd e4f5515d10 [issues] Migrate SameSite issues to markdown 1/* 
R=wolfi@chromium.org

Bug: chromium:1125465
Change-Id: I971ad3ca39dc8fd82b079456710c5b31b239e227
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2599545
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-12-21 10:15:35 +00:00
Sigurd Schneider 683143d8d5 Show an issue if a SAB is passed to postMessage 
Back-end CL: https://crrev.com/c/2593087

Bug: chromium:1051466
Change-Id: Iaf0a5f4df879406bc098cc5215110709fb979205
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2593127
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-12-17 15:43:16 +00:00
Alfonso Castaño b2302644f8 Display CSP Violations in a new tab drawer 
This CL introduces a new experimental tab drawer listing all CSP Violations.
It enables searching, sorting and filtering by categories of violations.

Design-doc: https://docs.google.com/document/d/1Zqd6Fq1g_Wb8Ies40OU1TSQ4f402cILFk4Nn_kP-_Cc/
Screenshot: https://i.imgur.com/ivAo61u.png
Bug: chromium:1137837
Change-Id: Ib7997b9ab59658871234ba557da8c20f50019311
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2538838
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Alfonso Castaño <alcastano@google.com>
 2020-12-01 15:12:35 +00:00
Tim van der Lippe 7dcef88d8b Remove skip_compilation from module.json files 
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I4c4fd280adb4f5f7b327239d08d80b2cb98b203b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560248
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-25 13:19:08 +00:00
Tim van der Lippe 801f27f7e0 Redirect front_end/marked to third_party/marked 
Since issues is now TypeScript-authored and is the only module
that was relying on Marked, we are no longer bound by marked
being in a direct subdirectory of front_end. Therefore, we
can treat it as lit-html and directly import from
third_party/marked instead.

To make sure that we don't bundle Marked in issues itself,
we have to update the Rollup logic to exclude it for now.
We will clean that up in a future Cl, where we are changing
the heuristic for "bundliness".

R=szuend@chromium.org,jacktfranklin@chromium.org

Bug: 1011811
Change-Id: Ieb40470a9efcd072ff5b360b7bd487f15df2a689
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2529157
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-11-11 14:45:09 +00:00
Simon Zünd 4ed2514ff4 [issues] Move first batch of SameSite issue descriptions to Markdown 
R=sigurds@chromium.org

Bug: chromium:1125465
Change-Id: Iff737d9de9435c330b8bfa09db418e78df748e70
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2525950
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-11-11 07:54:55 +00:00
Tim van der Lippe 2943c1a14b Use TypeScript-authored files in issues/ 
Since we have changed `build_release_applications` to ignore the files
listed in the `modules` array (
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2461783)
the files listed in `modules` are only used for Closure. This means
that if we remove the files from `modules`, Closure will no longer
know about it.

There is one caveat: the runtime still does the contains-check for
the legacy file. Therefore, we have to include the `issues-legacy.js`
file in the `modules` array (until we have removed its extensions, see
crbug.com/1134103). To ignore Closure warnings, we also have to
add the legacy file to the `skip_compilations` array.

Note that we can only do this for modules which satisfy these
requirements:
1. They are referenced directly by the entrypoint JSON files
2. There are no modules that are still type checked by Closure
that depend on this module
3. All files in this module are typechecked (e.g. TypeScriptified
JavaScript or TypeScript-authored) by TypeScript. In practice, this
means that there are no `@ts-nocheck` present in any file in this
module.

R=aerotwist@chromium.org,szuend@chromium.org

Bug: 1011811, 1127902
Change-Id: I348f2735312fc6147915a88b1377e85c02161d8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2512235
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-03 13:30:36 +00:00
Alfonso Castaño 30c3c74a29 Report Trusted Type violations in the Issues Tab (Frontend) 
This CL adds custom issues for Trusted Type violations (sink and policy) in the Issues Tab.

Screenshot: https://i.imgur.com/tE1zLtu.png, https://i.imgur.com/aFIkrrw.png
Bug: chromium:1137838
Change-Id: Ieddf8aa060851c8009d563b0d52c5c225d2f9c70
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2489425
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-10-28 13:04:14 +00:00
Sigurd Schneider ccdd933718 Reland "Use Markdown for Mixed Content related messages in the Issue tab" 
This reverts commit 8aba0177a4.

Reason for revert: This is a clean reland as it was accidentally reverted due to https://crbug.com/1140485

Original change's description:
> Revert "Use Markdown for Mixed Content related messages in the Issue tab"
>
> This reverts commit 682f30c53e.
>
> Reason for revert: crbug.com/1140485
>
> Original change's description:
> > Use Markdown for Mixed Content related messages in the Issue tab
> >
> > This CL refactors how Mixed Content issues are displayed
> >
> > Bug: chromium:1125465
> > Change-Id: I2e02c6238f7110979b68f865c385a5f6648b7d46
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484728
> > Commit-Queue: Alfonso Castaño <alcastano@google.com>
> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
>
> TBR=sigurds@chromium.org,alcastano@google.com
>
> Change-Id: I2b407aa7fc16f1bb0da299044afa638ff535c9b3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1125465
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2487286
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=sigurds@chromium.org,tvanderlippe@chromium.org,alcastano@google.com

# Not skipping CQ checks because this is a reland.

Bug: chromium:1125465
Change-Id: I4e08ff3a4010475e04543a1bb5accc422945c6e6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2489421
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-10-21 07:51:35 +00:00
Tim van der Lippe 8aba0177a4 Revert "Use Markdown for Mixed Content related messages in the Issue tab" 
This reverts commit 682f30c53e.

Reason for revert: crbug.com/1140485

Original change's description:
> Use Markdown for Mixed Content related messages in the Issue tab
>
> This CL refactors how Mixed Content issues are displayed
>
> Bug: chromium:1125465
> Change-Id: I2e02c6238f7110979b68f865c385a5f6648b7d46
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484728
> Commit-Queue: Alfonso Castaño <alcastano@google.com>
> Reviewed-by: Sigurd Schneider <sigurds@chromium.org>

TBR=sigurds@chromium.org,alcastano@google.com

Change-Id: I2b407aa7fc16f1bb0da299044afa638ff535c9b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1125465
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2487286
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-10-20 15:48:05 +00:00
Alfonso Castaño 682f30c53e Use Markdown for Mixed Content related messages in the Issue tab 
This CL refactors how Mixed Content issues are displayed

Bug: chromium:1125465
Change-Id: I2e02c6238f7110979b68f865c385a5f6648b7d46
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484728
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-10-20 10:37:11 +00:00
Tim van der Lippe 46e1bcace9 Remove pre_generates_legacy from module.json files 
This was a temporary flag used during the build_release_applications
to GN migration.

R=aerotwist@chromium.org

Bug: 1131500
Change-Id: I8a772bcc4bee31dbd3270bf7ef62d8c97941024a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484716
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-10-19 16:12:09 +00:00
Tim van der Lippe ead1fa43d0 Move remaining legacy files to GN 
R=aerotwist@chromium.org

Bug: 1131500
Change-Id: Ibb247dd02a5032604824517be4276c4b83c8fc8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2479140
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-10-19 09:25:50 +00:00
Alfonso Castaño c0e13563a9 Use Markdown for CSP related messages in the Issue tab 
This CL refactors how CSP issues are displayed

Bug: chromium:1125465
Change-Id: Iac1100091d4889f1c857deffe5e3bc37605ccd73
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2471276
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-10-15 09:08:03 +00:00
Simon Zünd 6ef0c8f432 Migrate COEP issue descriptions to use Markdown 
Screenshot: https://imgur.com/a/rcuuBhm

R=sigurds@chromium.org

Bug: chromium:1099162
Change-Id: I87a97f9c0fd29a8919c1e940093f06963bd71e43
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2308536
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-09-10 11:46:22 +00:00
Tim van der Lippe cac65d4fa0 Remove skip_rollup 
This was a temporary flag as part of the devtools_entrypoint migration.
Since that migration has concluded, we can now remove all references
to it and clean up `build_release_applications.py`.

R=jacktfranklin@chromium.org,aerotwist@chromium.org

Bug: 1101738
Change-Id: I3ef9ec1a99bc9fc1758532124db22b3b4b1a5e2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391140
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-08 15:44:09 +00:00
Simon Zünd 791d4882f5 [issues] Remove issues tab experiment 
The issues tab is configured as an experiment enabled by default since
M84. This CL removes the experiment all-together for M87.

R=sigurds@chromium.org

Bug: chromium:1072302
Change-Id: Idecb2bacf57f548b5e7fd1ab4d73bea415eac233
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2382854
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-08-31 13:49:33 +00:00
Simon Zünd c87611c71f Add support for Markdown issue descriptions 
This CL adds a new data structure {MarkdownIssueDescription} and a
helper function that turns the new structure into an
{IssueDescription}. Rendering is handled by the new Markdown component.

R=sigurds@chromium.org

Bug: chromium:1099162
Change-Id: I55a5585ce5d0ab16ddf3ed7fd925d0a94e5b9ad2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2306154
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-08-04 07:39:03 +00:00
Simon Zünd 3f17f423d4 Add basic Markdown rendering component 
This CL adds a basic web component than can render the Markdown AST
produced by 'marked'. The styles are currently tailored toward
rendering issue descriptions, as this is the main use case.

R=jacktfranklin@chromium.org

Bug: chromium:1099162, chromium:1108699
Change-Id: I6f5cc2e2b19e18022b21344f134701c6a31e8280
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2306153
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-07-29 12:56:21 +00:00
Simon Zünd 2675d65f66 Migrate issues module to use devtools_entrypoint 
R=aerotwist@chromium.org

Bug: chromium:1101738
Change-Id: Ib0bcccf13ee74cf41f76da0e2eb32b98a414232b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2308535
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-07-22 06:32:16 +00:00
Tim van der Lippe 37512b0d25 Remove empty script arrays from module.json files 
If the module uses `modules` to load the JavaScript files, then
we can remove the `scripts` array altogether. Note that there
are still some modules left that use `scripts`, most notably
the `lighthouse_worker`, which is a remote module.

R=aerotwist@chromium.org

Bug: 1105476
Change-Id: Ie303e9835f5ce6d42ccae7b3a305d8f3df1af84c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2302597
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-07-17 10:05:33 +00:00
Sigurd Schneider ba81851dad [issues] Add IssueManager abstraction 
This CL adds a central singleton that collects all issues from all
known targers. This singleton is then used by the issues view to
display issues.

This change enables correct handling of issues that arise from OOPIF
and worker sources.

Fixed: chromium:1073797
Change-Id: I75a8bb46d240f63df013c0b06506cad7fb2e5a8f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2168885
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-04-29 11:14:55 +00:00
Sigurd Schneider 80e9d2ce1c [issues] Introduce the IssueAggregator abstraction 
The IssueAggregator decouples issue aggregation from the SDK layer.
This is a pre-requisit for sourcing issues from multiple IssuesModels,
as aggregation is intended to work across models as well.

Bug: chromium:1073797
Change-Id: Ib25fb27e4baa802471edb83d1a043142dd086765
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165757
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-04-28 08:40:21 +00:00
Tony Ross c4fb400988 Add keyboard accessibility to Issues panel 
Converts display of issues to use TreeOutline allowing re-use of
built-in keyboard handling from that component. Redundant UI elements
such as expand/collapse toggles have been removed and the corresponding
equivalents in TreeOutline re-styled to match the existing Issues panel
design.

Also removes the height animation for opening/closing issues to avoid
clipping content (see https://imgur.com/a/iZJPyL0). This was an
existing issue for which re-implementing the broken behavior on top of
TreeOutline seemed out-of-scope. Follow-up work could consider re-adding
this animation in a way that doesn't clip content.

Bug: 1067773
Change-Id: Id6b1a3391efbc74139cc20d572c3fef038d3ecad
Gif: https://imgur.com/a/c9lZ3bm
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2144339
Commit-Queue: Tony Ross <tross@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: John Emau <John.Emau@microsoft.com>
 2020-04-16 16:20:23 +00:00
Mathias Bynens 5e43b27e8b Reformat module.json files 
This patch makes it so that all module.json files use the same
consistent indentation that matches .editorconfig and the rest
of the codebase. At the request of reviewers, one such file
(front_end/emulated_devices/module.json) has been excluded
from this patch. It will be reformatted in a separate CL.

Note that this patch does not “roll CodeMirror”, although a
pre-commit hook forces me to include that phrase in the commit
message because the module.json file in the relevant folder is
modified.

Bug: chromium:1070492
Change-Id: Ib31ed5232461e2f80bf05f31105fc919f6639b0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127007
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-04-14 05:35:23 +00:00
Simon Zünd a27ec02e9e Move 'issues' module from 'shell' to 'devtools_app' and 'worker_app' 
The issues module depends on the network module. As we do not want to
add the network module to shell, we lift the issues module "upwards"
into the two application configurations that 1) extend from shell and
2) have network available.

R=sigurds@chromium.org, tvanderlippe@chromium.org

Change-Id: Ic975edf871d1e9cd60a65aa0dc800564aa1b7931
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2123478
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-03-27 13:21:41 +00:00
Sigurd Schneider e46864c833 [Issues] Add revealer for issues 
This adds the possiblity to reveal an issue from anywhere in DevTools.
This is a prerequisit for linking to the issues panel from other places
in DevTools.

Bug: chromium:1057979
Change-Id: Ie23d85affa16d7f343906a57ffbabf5e0e2a8b65
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2084575
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-03-03 15:47:14 +00:00
Sigurd Schneider 73a2af3afa [issues-panel] Correctly update issues upon navigation 
Bug: chromium:1056284
Also-by: janscheffler@chromium.org
Change-Id: I6157d10de3333ad01487133fe5fb52d0ca5f8a6f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2075459
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
 2020-02-26 20:08:56 +00:00
Jan Scheffler 01005814aa Add Issues Drawer 
This cl adds a new drawer to surface issues collected from the audits
agent.

Screenshot: https://imgur.com/a/lEFCnjA
Design Doc: https://docs.google.com/document/d/1F6R5Bpb3qHNzGPNBSXwEJ_eP8L-anIj0WinxOIyAh54/

Bug: chromium:1039607
Change-Id: I59fb4ecddcdf6cc2c3ca7fa8c726209c8f20d51e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2000796
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-02-05 13:02:13 +00:00