This CL changes references to self.SDK.targetManager (the global
instance of SDK.SDKModel.TargetManager) over to
SDK.SDKModel.TargetManager.instance(). To keep both TypeScript and
Closure happy we must make a method on the TargetManager class itself,
since it only allows private constructors to be accessed by static
methods on the class.
Bug: 1058320
Change-Id: I6ca35024c21cf24254fd6273138a1ab3e163ee00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2088092
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
This is a reland of cef170cfe5
The change accidentally deleted a line that allowed for the overview timeline
highlighting of the currently selected node. This has been fixed.
Original change's description:
> Network A11y: Improve keyboarding experience of Network tool Datagrid
>
> This changes builds off of
> https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1881219
> in order to improve the keyboard accessibility
> of the Network tool Datagrid.
>
> Previously, the network tool ties selection of a node in the grid
> directly to opening the request sidepane. This makes it challenging for
> keyboard only users to view and navigate the network tool datagrid
> columns.
>
> This change separates selection from opening the sidepane, and fixes
> styling issues that affect the columns that were previously hidden
> behind the sidepane when a node is selected. Selected nodes are
> highlighted in the grid, and are "activated" using the enter key
> or a click in the primary column to open the sidepane.
>
> Before: https://imgur.com/U1PG6Hr
>
> After: https://imgur.com/eXgDE9D
>
> Bug: 963183
>
> Change-Id: I2c2629670624e807adb4cd9e9e9b75cdafbae7a5
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1881592
> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
> Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
> Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Bug: 963183
Change-Id: I4dfd0a67cd1fce6e6dd8066ceb84841d21191ef3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1896256
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.
This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.
Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
Tim van der Lippe