Previously recording of the network log was enabled when reloading and not persisted by a setting.
This CL introduces a new setting which persists the existing action, so that it can be toggled in the network settings. Also the setting is not re-enabled when the page will reload.
Bug: 1122580
Change-Id: I537a1072f6d1dca6ef88f1b507a23977763341a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2503513
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
This CL adds the ability (hidden behind an experiment) for users to
select a set of shortcuts to use, the two options initially being the
default shortcuts and shortcuts that match those from VS Code. A new
`keybindSets` array is added to binding objects in module.jsons,
allowing shortcuts to be filtered on launch much like the existing
platform option. Also like platform, if the keybindSets array is
undefined for a shortcut then that shortcut will be considered common to
all keybindSets.
In general, I left keybindSets undefined for default DevTools shortcuts
that do not conflict with VS Code shortcuts so that they remain common
shortcuts. When both the DevTools and VS Code define the same shortcut,
I add both sets to keybindSets.
This should only affect users who have opted into the custom keyboard
shortcuts experiment. If a user with the experiment enabled selects VS
Code shortcuts and then turns the experiment off, ShortcutRegistry will
reset the shortcuts to the DevTools default on next launch.
Enumerating the differences between VS Code and the DevTools default
shortcuts uncovered some workflows that we'd like to add shortcuts for
that do not currently have actions in the DevTools, such as save as and
find/replace. I plan to add those in future CLs.
Due to problems with ListWidget's accessibility, I have to manually add
aria roles to the list and list items. This is a temporary state of
affairs until this tab is changed to use ListControl rather than
ListWidget for better accessibility. Since the ListWidget here contains
no editable items and is only marked as a list, there are no keyboard
navigation or focus management requirements to worry about yet.
I have put up a telemetry CL here so that we can evaluate the success of
the feature:
https://chromium-review.googlesource.com/c/chromium/src/+/2172132
Screenshots:
https://i.imgur.com/ka0VEyM.pnghttps://i.imgur.com/CG8hAro.png
Custom shortcuts design doc: https://docs.google.com/document/d/1oOPSWPxCHvMoBZ0Fw9jwFZt6gP4lrsrsl8DEAp-Hy7o/edit#
Bug: 174309
Change-Id: I0e3484eb2712c945121cc7b68e14a1a98f858bab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2095859
Reviewed-by: John Emau <John.Emau@microsoft.com>
Reviewed-by: Songtao Xia <soxia@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
This CL adds a central singleton that collects all issues from all
known targers. This singleton is then used by the issues view to
display issues.
This change enables correct handling of issues that arise from OOPIF
and worker sources.
Fixed: chromium:1073797
Change-Id: I75a8bb46d240f63df013c0b06506cad7fb2e5a8f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2168885
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
This patch makes it so that all module.json files use the same
consistent indentation that matches .editorconfig and the rest
of the codebase. At the request of reviewers, one such file
(front_end/emulated_devices/module.json) has been excluded
from this patch. It will be reformatted in a separate CL.
Note that this patch does not “roll CodeMirror”, although a
pre-commit hook forces me to include that phrase in the commit
message because the module.json file in the relevant folder is
modified.
Bug: chromium:1070492
Change-Id: Ib31ed5232461e2f80bf05f31105fc919f6639b0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127007
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Issue: In the network tool, there is a pop up for stack traces that appears
when you hover over the initiator column. This info is not available
anywhere else, and is not keyboard accessible.
This changes: add a new tab to the network item view, similar to the
Timings tab and Waterfall column (which is available when hovering over the
waterfall, but also accessible when selecting a network request to view).
Bug: 963183, 842488
workflow gif: https://imgur.com/a/wmdNYXE
Change-Id: Ib2f23b924a06e687acd362ccf4d6764f8a996559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742990
Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#702125}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0d0cae574b458c3d4bd7f6f254f74f6f2442b710
Before this patch, DevTools didn't distinguish between toggleable
actions and regular actions. When an action button was made, it was
always a toggle button. This worked because an untoggled button
and an untoggleable button are the same visually.
But for the accessibility tree, an untoggled button should have
aria-pressed=false, whereas an untogglable button should not have
aria-pressed at all. This means its important to distinguish
between toggleable and untoggleable actions.
This patch:
* Adds a new field to actions in module.json: toggleable.
* Dynamically returns the correct kind of button from createActionButton
* Refactors createLongPressActionButton into its own function.
Bug: 963183
Change-Id: Ie2ebbeab9d651b1823611d942bdc66e67ff293c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693175
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#677785}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 92cb5705086497ab2c5e042265a18f7c3bb07ffc
This patch replaces the TabbedPane in the binary websocket viewer with a
bottom toolbar which has a dropdown for which view you want and a copy
button. Since the feedback was positive in a UX meeting, I am removing
the experiment.
Screenshots: https://imgur.com/a/v2iH4mg
Bug: 605262
Change-Id: I9ee50fdf75e82043d85bf3ab6745ae79027ffc4f
Reviewed-on: https://chromium-review.googlesource.com/c/1449108
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#629025}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2a33c7ca1b2db81054aef98dcaed2912a14bccd5
SignedExchangeDevToolsProxy sends the SignedExchangeHeader and the certificate
information and the error messages to DevTools.
When the user clicks a signed exchange response in Network panel, these
information will be displayed in the Preview panel.
And the network grid view will show “from SignedExchange” in the size column of
the content of the signed exchange like “from disk cache”.
See the doc for more details: https://bit.ly/2HXVbCU
This CL depends on https://crrev.com/c/1029755
Bug: 830505
Change-Id: Ice3743f2e1675b6d604eeaba731ebd8494c2b5a1
Reviewed-on: https://chromium-review.googlesource.com/1004890
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#559363}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 705b2aa35e1523b1a00b6c8aa73b3a5f0c8e50b1
Andres Olivares
