This CL turns on the use_theme_colors stylelint rule which enforces that
any colors use variables defined in our codebase.
There are many, many violations, unsurprisingly (about 1500), so for now
I have disabled every single violation. The goal of the dark mode
migration will be in part to remove all violations of this rule.
Additionally, new code going forwards should adhere to the rule and not
add the comment to disable the warning.
Bug: 1152736
Change-Id: I51372724ea51485daef3d4f75b7d3f60a7c8016f
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2671323
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
This patch rewrites the request cookies view panel to include new
information about blocked cookies emitted by the new Network ExtraInfo
events, including:
- Splitting the cookie table into multiple tables to make it easier to
read.
- Modifying CookiesTable to highlight and add an icon to cookies which
were blocked.
- Fixing some bugs in RequestCookiesView and NetworkRequest which
caused the cookies panel to not appear when it should.
- Modifying SDK.Cookie and SDK.CookieParser to store blocking
information and the original cookie line.
Screenshots before: https://imgur.com/I7WBSgz
Screenshot after: https://imgur.com/uHTU3ID
Bug: 856777
Change-Id: I044aa7fcd4fe8db121fd7aaa13ff9d6cd829aae2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756252
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#694530}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4f13a2518b054a7e8d218aaf3213de2e1c74ea4e
Jack Franklin