Jack Franklin
49a9481a74
Lint color usage in background and border-* properties.
...
The list of CSS properties we check for colors wasn't thorough and
didn't include `border-left/right/top/bottom` or `background` on its
own. This CL fixes that and disables the rule for any current
violations.
Bug: 1152736
Change-Id: Ic732d653fdfab0462a04dc891bcece1f44e5d471
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676157
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
2021-02-05 15:39:39 +00:00
Jack Franklin
8064d3ba7a
Lint against non-theme-color variables
...
This CL turns on the use_theme_colors stylelint rule which enforces that
any colors use variables defined in our codebase.
There are many, many violations, unsurprisingly (about 1500), so for now
I have disabled every single violation. The goal of the dark mode
migration will be in part to remove all violations of this rule.
Additionally, new code going forwards should adhere to the rule and not
add the comment to disable the warning.
Bug: 1152736
Change-Id: I51372724ea51485daef3d4f75b7d3f60a7c8016f
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2671323
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2021-02-03 11:02:09 +00:00
Jack Franklin
0d88cbb6fd
Ban named-colors in our CSS
...
Used
https://css-tricks.com/snippets/css/named-colors-and-hex-equivalents/ as
the reference and did a bunch of find and replaces. Should be no visible
changes; have checked by running DevTools locally and looking for
anything that looks off.
Note that system colors (e.g. HighlightText) are still permitted.
Fixed: chromium:1171775
Bug: chromium:1104187
Change-Id: I99c281886822deb5a5292ac8691a4f2f9e026428
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2656243
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2021-02-01 09:33:45 +00:00
Mathias Bynens
e071c96e5d
Format decoded X-Client-Data HTTP header values as code
...
This clarifies that this is the only content the header contains. See
the discussion here: https://crbug.com/1103854#c25
Screenshots:
- Before: https://i.imgur.com/LJHFIp9.png
- After: https://i.imgur.com/7mLKiEc.png
Note that these screenshots show this as a response header instead of a
request header, since that was easier to test. In real-world scenarios
it would be a request header instead, but the UI looks the same.
Bug: chromium:1103854
Change-Id: I06246ada6c61e8b8fc59c38760f79dc4357e0933
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2351775
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Commit-Queue: Mathias Bynens <mathias@chromium.org >
2020-08-13 05:13:50 +00:00
Mathias Bynens
4a0d19365c
Reland “De-obfuscate X-Client-Data header values in Network tab”
...
Reland of: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2316062
Screenshot: https://i.imgur.com/LJHFIp9.png
Note that the screenshot shows this as a response header instead of a
request header, since that was easier to test. In real-world scenarios
it would be a request header instead, but the UI looks the same.
CL preparing the ClientVariationsParser for use in the DevTools UI:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2316065
TBR=isherman@chromium.org ,mathias@chromium.org ,changhaohan@chromium.org ,alexrudenko@chromium.org
Bug: chromium:1103854
Change-Id: I6b959a1d57bcbc84f8571257a88fcbec805bf330
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2318257
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Ilya Sherman <isherman@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Mathias Bynens <mathias@chromium.org >
2020-07-28 06:54:51 +00:00
Mathias Bynens
43af8ef5d3
Revert "De-obfuscate X-Client-Data header values in Network tab"
...
This reverts commit d63cf4f023https://i.imgur.com/LJHFIp9.png
> Note that the screenshot shows this as a response header instead of a
> request header, since that was easier to test. In real-world scenarios
> it would be a request header instead, but the UI looks the same.
>
> CL preparing the ClientVariationsParser for use in the DevTools UI:
> https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2316065
>
> Bug: chromium:1103854
> Change-Id: Ifb63c011df2ea7af8aeb47dd615e2b20863a02c1
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2316062
> Reviewed-by: Ilya Sherman <isherman@chromium.org >
> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
> Reviewed-by: Changhao Han <changhaohan@chromium.org >
> Commit-Queue: Mathias Bynens <mathias@chromium.org >
TBR=isherman@chromium.org ,mathias@chromium.org ,changhaohan@chromium.org ,alexrudenko@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1103854
Change-Id: Id405f5991fd33a4dff5dd13c44da5ac3e67609cd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2318251
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Mathias Bynens <mathias@chromium.org >
2020-07-27 11:15:07 +00:00
Mathias Bynens
d63cf4f023
De-obfuscate X-Client-Data header values in Network tab
...
Screenshot: https://i.imgur.com/LJHFIp9.png
Note that the screenshot shows this as a response header instead of a
request header, since that was easier to test. In real-world scenarios
it would be a request header instead, but the UI looks the same.
CL preparing the ClientVariationsParser for use in the DevTools UI:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2316065
Bug: chromium:1103854
Change-Id: Ifb63c011df2ea7af8aeb47dd615e2b20863a02c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2316062
Reviewed-by: Ilya Sherman <isherman@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
Commit-Queue: Mathias Bynens <mathias@chromium.org >
2020-07-24 09:04:39 +00:00
Kim-Anh Tran
1c3a3da685
Fix stylelint-config-standard issues in network/requestHeadersTree.css
...
Bug: chromium:1083142
Cq-Exclude-Trybots: luci.devtools-frontend.try:devtools_frontend_mac_rel
Change-Id: I01b0a9b22ac89503d09d5f17e649143c87d1d489
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2282344
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-07-06 11:50:31 +00:00
Mathias Bynens
ca9fa2d73f
Consistently format CSS color and opacity values
...
- Prefer the modern comma-free CSS color function syntax over the
legacy syntax. [1]
- Explicitly use the `deg` suffix for angle values in colors, to
clarify the range.
- Explicitly use the `%` suffix for percentages instead of formatting
the value as a number, again to clarify the range.
[1]: https://twitter.com/mathias/status/1253242715304857601
[2]: https://goo.gle/devtools-css-color
Bug: chromium:1083142
Fixed: chromium:1073885
Change-Id: I8e1582a2dee3553a61df88564051ea84c2011d76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209091
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Auto-Submit: Mathias Bynens <mathias@chromium.org >
2020-05-19 16:50:26 +00:00
Mathias Bynens
b0c1f4bce2
Fix stylelint-config-standard violations
...
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Changhao Han <changhaohan@chromium.org >
Auto-Submit: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
2020-05-15 17:05:27 +00:00
Sigurd Schneider
cae7b53aee
[COEP] Improve error messages for COEP
...
This refactors the implementation and increases color contrast
for the messages.
Bug: chromium:1051473
Change-Id: I21ce4b306d84c6a74fc4182738ab56e6ca952bca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2089900
Reviewed-by: Peter Marshall <petermarshall@chromium.org >
Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
2020-03-06 12:04:15 +00:00
Sigurd Schneider
a2afe0b0d0
[COEP] Report detailed blocked reason for requests blocked by COEP
...
You can test this CL on
https://first-party-test-with-resource.glitch.me/
after activating 'Cross Origin Isolation' in chrome://flags
Screenshots: https://imgur.com/a/SCbC7Go
Bug: chromium:1051466
Change-Id: I65e3ad16d396623ac1dd93ffb962fffd04c85265
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2083095
Commit-Queue: Sigurd Schneider <sigurds@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-03-03 20:17:24 +00:00
Kham Udom
e22500101f
High contrast update for Network panels
...
The patch updates the common styles, not only for Network, but other
panels that uses data grid. It fixes the hover, focus and selected
states.
Fixed hover, focus and selected on all individual panels within
Network. Fixed the filter and the cursor and resize handle within
the timeline.
Before: https://imgur.com/a/HR5topn
After: https://imgur.com/a/Gpph5BI
Bug: 1048378
Change-Id: Id0715ac873826471b35a400895efa5c178a589d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2059527
Commit-Queue: Kham Udom <khamu@microsoft.com >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-02-18 07:19:36 +00:00
Mathias Bynens
9680e2e8b0
Drop -webkit-user-select in favor of user-select
...
Bug: chromium:1031475
Change-Id: Ibbf222135c97e79ae3be816216fec9675d643952
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1953613
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Changhao Han <changhaohan@chromium.org >
Auto-Submit: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
2019-12-06 10:31:53 +00:00
Blink Reformat
4c46d0969f
The Great Blink mv for source files, part 2.
...
Move and rename files.
NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true
Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org >
Commit-Queue: Blink Reformat <blink-reformat@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00
Jack Franklin
