Commit Graph
3 Commits
Author SHA1 Message Date
Sigurd Schneider cb2d45671e Enforce naming convention for properties
This CL enforces general camelCase naming for properties,
with the following exceptions:
  - public properties are allowed to have a leading underscore until
    we've migrated them (they were probably introduced by the
    JSDOC -> TS automated script).
  - static readonly class properties must use CONSTANT_CASE. For
    non-static readonly class properties camelCase is enforced,
    and I think this gives the right intuition.

Bug: chromium:1057042
Change-Id: I482b5b7cfe2b856e83fba8b78be222d60761db19
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692210
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2021-02-15 09:21:50 +00:00
Tim van der Lippe cf4ab40452 Update typescript-eslint to 4.15.0
This also fixes a bug in the PRESUBMIT that ensures that, whenever
we update typescript-eslint, we correctly rerun the full linter
check.

DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I016f73b26cd84cabf3171aba89c88a0d72820f1a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692165
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2021-02-12 15:42:37 +00:00
Jan Scheffler 18c0562076 [JSDOC2TS]: Migrate object_ui
Bug: chromium:1158760
Change-Id: I09b10e827e46728be3020fe0d0c7e339a80350b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2687506
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
2021-02-11 17:54:08 +00:00