Commit Graph
3 Commits
Author SHA1 Message Date
Tim van der Lippe d946df0c9c Add missing return types to function/method definitions
We will be turning on an ESLint rule to enforce the specification
of a return type in a follow-up CL.

R=jacktfranklin@chromium.org

Bug: 1057042
Change-Id: I56f67cf3fdafa0a867e8837f4d30d52ed1595351
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2587740
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-12-14 15:01:46 +00:00
Sigurd Schneider c57ccf2b7b Refactor ExpandableApplicationPanelTreeElement
Some classes in ApplicationPanelSidebar inherit from a class called
StorageCategoryTreeElement. That class name is from a time when the
Application panel was only about storage and is nowadays misleading.
This CL renames the class to ExpandableApplicationPanelTreeElement
and moves it to ApplicationPanelTreeElement.ts. This enables
moving other classes to separate files later on.

R=wolfi@chromium.org

Bug: chromium:1157484
Change-Id: I3121827da92830ceb1b5132489fd5b0ecedeaf63
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2587015
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2020-12-11 15:26:57 +00:00
Sigurd Schneider 721ef456ee Refactor ApplicationPanelTreeElement
Currently we have a large number of classes in ApplicationPanelSidebar
that all inherit (ultimately) from BaseStorageTreeElement. That class-
name is from a time when the Application panel was only about storage
and is nowadays misleading. This CL renames the class to
ApplicationPanelTreeElement and moves it to its own file. This enables
moving other classes to separate files as well.

Bug: chromium:1157484
Change-Id: Ibe4542774b15daee2e2f78d3499208d8d0c6d7c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2584922
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
2020-12-11 08:55:37 +00:00