Commit Graph
18 Commits
Author SHA1 Message Date
Vidal Guillermo Diazleal Ortega 0a997bb8b6 [Loc] Migrate resources(Aplication) to Localization V2
- Migrate resources(Aplication)to use Localization V2 APIs.
- Removed resources grdps

Tested with en-XL.json
https://imgur.com/a/hsH7AEm

Bug: 1136655
Change-Id: Iba7fef0b87f7aab7625f4e013f1a120baa268889
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2677336
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
2021-02-09 05:17:17 +00:00
Tim van der Lippe e4d64e7ae0 Remove unrestricted from comments that include other annotations
For all comments that contained both the unrestricted annotation
and any other potential annotation, remove only the unrestricted
annotation.

R=szuend@chromium.org

No-Presubmit: True
Bug: 1011811
Change-Id: I27dd67f657cdb1a9233d768eea81cabe2591f5f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569759
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2020-12-02 15:31:52 +00:00
Tim van der Lippe 2e38eeaf9f Remove all comments with only the unrestricted annotation
The unrestricted annotation is Closure-specific and can be removed.
This patch removes all comments with only the unrestricted annotation
in them.

R=szuend@chromium.org

No-Presubmit: True
Bug: 1011811
Change-Id: Iba0723644f53f5307c3077d341271af86becc32a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569758
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
2020-12-02 15:25:32 +00:00
Sigurd Schneider 1bb584afa0 [ts] Type-check resources/DatabaseTableView.js with TypeScript
Bug: chromium:1011811
Change-Id: Icb24d26561e7c8d577a6ee19141d4250b43ebcb1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2510389
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
2020-10-30 15:02:58 +00:00
Tim van der Lippe 3c7eedcd60 Remove all definitions of usesObjectNotation
This was a temporary method, used during the migration to use
objects in dispatcher callbacks. Since all dispatchers now receive
the event as an object, we can remove these temporary methods.

R=aerotwist@chromium.org

Fixed: 1138492
Bug: 1011811
Change-Id: Ib7fbfae567ebc9b2be0a5d760458e5b0c7edc12e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484723
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-10-20 10:59:51 +00:00
Wolfgang Beyer 469c2d2093 [TS] Port DatabaseModel.js to TypeScript
Bug: Bug: chromium:1011811, chromium:1138492
Change-Id: I2d9b885efeea25593b964fd8aa79f7328dd42546
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2475719
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
2020-10-16 05:49:17 +00:00
Jan Scheffler 52b1f359a3 Migrate front_end/resources to devtools_entrypoint
R=aerotwist@chromium.org, jacktfranklin@chromium.org

Bug: 1101738
Change-Id: I2a3e04996defaad7f77741f7e3fe985f283a4e61
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332225
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
2020-07-31 15:14:20 +00:00
Simon Zünd 182134236e Rename namespace import for protocol_client to ProtocolClient
R=tvanderlippe@chromium.org

Bug: chromium:1011811
Change-Id: Idf3e9eb8f6d52db78f563de53b7576ec6c9b9cdc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107557
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-03-19 12:08:52 +00:00
Simon Zünd 3b0c540211 Rename front_end/protocol to front_end/protocol_client
This CL is part of the work to switch over to the TypeScript compiler
for type checking.

R=tvanderlippe@chromium.org

Bug: chromium:1011811
Change-Id: Ic709a193b252df7e9027c00cf20d8afe525a215a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107539
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-03-18 18:06:20 +00:00
Tim van der Lippe 0efccf074b Migrate resources/ to import cross-module
Bug: 1006759
Change-Id: I95a6b04dcbac41ca56036e0ff7ae70f74e9fa8e8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2051994
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-02-12 16:07:52 +00:00
Paul Lewis ddf58342e0 Migrates resources/ to ESM internally
Bug: 1006759
Change-Id: I4176498edee62723421ce79639375f28a87bda0b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2002589
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-01-15 15:19:33 +00:00
Tim van der Lippe 097cdecdfc Migrate resources/ to ESM
Bug: 1006759
Change-Id: Idbbe06ab71b93bd2a2e2652f3ee4f5bd4b68f6ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1985673
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-01-06 15:02:33 +00:00
Tim van der Lippe c96ccd99f0 Remove unused globals
By using the script in crrev.com/c/devtools/devtools-frontend/+/1942289
we can prune all globals that are not actually global. Most of these are
internal private variables that are now module-scoped. Some variables
were also completely unused, which ESLint nicely reported.

Change-Id: I43689ac7544ad1239acc7d0eeec4dcd563d7fea9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1942290
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2019-11-29 16:38:40 +00:00
Tim van der Lippe 1d6e57a0e3 Always add braces to single-line if-statements
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.

This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.

Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
2019-09-30 11:55:34 +00:00
Joey Arhar a6abfa2519 [DevTools] Do not debug worker shadow pages
This change breaks pausing on start when inspecting a shared worker that
gets reloaded. More detail here: crbug.com/987024

Bug: 882467
Change-Id: I074b547996fd7f11d835fcebfdae32a4f7063a9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636110
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#685152}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5dc1be4c957563e073c462b39a934f23d02461d0
2019-08-08 12:23:00 +00:00
Sergey Poromov 47ac039a86 Revert "[DevTools] Await clearing methods in ClearStorageView"
This reverts commit fd3d8cadb7971e2934bd98130335d789398ac139.

Reason for revert: http/tests/devtools/indexeddb/live-update-indexeddb-content.js is flaky.

Findit suspects this CL to be the reason for the recent test flakiness. See the bug for more information.

Bug: 979503

Original change's description:
> [DevTools] Await clearing methods in ClearStorageView
> 
> Part 1 of adding garbage collection after clearing is done.
> 
> Change-Id: I7022c1d6d0d3c8cfabce7f57ba5f689c135b6395
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669175
> Reviewed-by: Erik Luo <luoe@chromium.org>
> Commit-Queue: Harley Li <hhli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#673083}

TBR=luoe@chromium.org,hhli@chromium.org

Change-Id: I5849695b3e5d2c3646303c2f49a801ffbc3ee15f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679704
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#673265}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5a63d041f4c585eaa540963686cc894a342e5de9
2019-06-28 09:28:22 +00:00
Harley Li 29943fa5b5 [DevTools] Await clearing methods in ClearStorageView
Part 1 of adding garbage collection after clearing is done.

Change-Id: I7022c1d6d0d3c8cfabce7f57ba5f689c135b6395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669175
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Harley Li <hhli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#673083}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fd3d8cadb7971e2934bd98130335d789398ac139
2019-06-27 22:13:31 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2.
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00