This bug was caused when the user passes in shorthand CSS properties
written in uppercase letters. The browser would not display the
'toggle-expandable' triangle indicating the availability of longhand
CSS properties.
The fix was to add toLowerCase() to the name argument inside of the
longhandsProperties() method. This allows the argument to be passed
into the longhands() method as a lowercase string, which then is able
to match the lowercase string and returns an array of longhand CSS
properties.
Screenshots:
- Before: https://i.imgur.com/qteeXcP.png
- After: https://i.imgur.com/Y9JzKQM.png
Fixed: chromium:918109
Change-Id: I018b3e7eccaa008ec2b9dbff101bb5681655e624
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2533305
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
To enable full parallelization of all files in sdk/, we can add the
@ts-nocheck annotation to all files. This suppresses existing
TypeScript errors in these files.
We can then one-by-one remove these annotations and fix the issues
reported in these files. This allows us to parallelize the work
and work on many files at the same time.
As a starter, I typechecked sdk/Connections.js to verify that
typechecking works while all other files are not checked yet.
I did do so by locally suppressing all TypeScript errors in
SDKModel.js and remove the `instance` method on `TargetManager`.
I then confirmed that rebuilding with TypeScript correctly
fails on the missing method, but does not require SDKModel.js
itself to be typechecked.
Bug: 1011811
Change-Id: I46de3839f7d837e951967dd932218bda00c6ad5b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2156352
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.
This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.
Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
Previously CSS that was not correctly parsed would not appear in the
styles sidebar. If a mistake was made when editing CSS in the sidebar,
the property being edited could dissapear because it would no longer
be parsed correctly.
Bug: 813435
Change-Id: I20cb6b1e977545693c3f75171479d8e9041d83d9
Reviewed-on: https://chromium-review.googlesource.com/1089295
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566196}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e328358f9e11cda5257454afba56dd2a7cd0b72
Jesus David Garcia Gomez
