This CL turns on the use_theme_colors stylelint rule which enforces that
any colors use variables defined in our codebase.
There are many, many violations, unsurprisingly (about 1500), so for now
I have disabled every single violation. The goal of the dark mode
migration will be in part to remove all violations of this rule.
Additionally, new code going forwards should adhere to the rule and not
add the comment to disable the warning.
Bug: 1152736
Change-Id: I51372724ea51485daef3d4f75b7d3f60a7c8016f
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2671323
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
This patch drops unnecessary -webkit- prefixes in CSS and enables
a lint check to enforce that prevent such properties from being
added in the future. Note that the use of vendor-prefixed CSS
properties is still accepted in cases where there is no standardized
and browser-supported alternative.
Bug: chromium:1104187
Change-Id: I29ae93d5a760c4f5037f20663754f448b5083235
Fixed: chromium:1031475
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2297386
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Security UX is experimenting with using a grey triangle warning for
non-secure site connections (crbug.com/997972). When this icon is
shown, DevTools Security panel's security overview should match the
state shown in the omnibox.
Previously, crrev.com/c/1874787 added the insecure-broken state to
the DevTools protocol, so this cl does the setup so that once the
insecure-broken state gets sent for the DANGEROUS security state
(crrev.com/c/1879498, which needs to be submitted after the frontend
changes) and non-secure connections get styled as kInsecure
(crrev.com/c/1877653), the triangle pointer will point to the correct
icon. For non-secure states, reuse the triangle icon but style it
differently depending on whether the state is HTTP or broken HTTPS.
Bug: 1008218
Change-Id: Ib893489a9d7c450892eff5e33bbbf3f2aef2e283
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880092
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Jack Franklin