This CL turns on the use_theme_colors stylelint rule which enforces that
any colors use variables defined in our codebase.
There are many, many violations, unsurprisingly (about 1500), so for now
I have disabled every single violation. The goal of the dark mode
migration will be in part to remove all violations of this rule.
Additionally, new code going forwards should adhere to the rule and not
add the comment to disable the warning.
Bug: 1152736
Change-Id: I51372724ea51485daef3d4f75b7d3f60a7c8016f
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2671323
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Security UX is experimenting with using a grey triangle warning for
non-secure site connections (crbug.com/997972). When this icon is
shown, DevTools Security panel's security overview should match the
state shown in the omnibox.
Previously, crrev.com/c/1874787 added the insecure-broken state to
the DevTools protocol, so this cl does the setup so that once the
insecure-broken state gets sent for the DANGEROUS security state
(crrev.com/c/1879498, which needs to be submitted after the frontend
changes) and non-secure connections get styled as kInsecure
(crrev.com/c/1877653), the triangle pointer will point to the correct
icon. For non-secure states, reuse the triangle icon but style it
differently depending on whether the state is HTTP or broken HTTPS.
Bug: 1008218
Change-Id: Ib893489a9d7c450892eff5e33bbbf3f2aef2e283
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880092
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
This patch adds a createTextLink method to create
text links and uses it in the security > origin view to
link to the network pane. It also adds "show more" and
"show less" classes for to the text link.
Bug: chromium:977423
Change-Id: If5ff95e5d26af3a20680e93e23e110b912a41de4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789531
Commit-Queue: Jan Scheffler <janscheffler@google.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#699635}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2d23c1d6ec05bae5d56cc417b90146d9064dde95
Changes:
Origin:
- 'Origin' text is now a header 1
- 'Connection' text is now a header 2
- 'Certificate' text is now a header 2
- 'Certificate Transparency' text is now a header 2
- 'Show more/less' and 'Show full details' links are now marked as buttons and are keyboard accessible
Overview:
- 'Security overview' text is now a header 1
- page security description is now a header 2
- 'View x in network panel' link is now marked as a button and is keyboard accessible
.devtools-link css changes:
https://imgur.com/a/9FtpsU4
link elements to button element change:
https://imgur.com/zSMcGVQ
CR Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=962686
Change-Id: I3a62e898d7135ace1d8a9c76dfdbad382c928500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606195
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#672600}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ec4778d2487334d68e9fdc9c55d95ab4b9bddf3f
These css rules used classes that don't exist anywhere in the
javascript. A script was written to find them, but manually checking
is still needed because some scripts generate class names by
string concatenation like 'icon-' + iconType
Change-Id: I15c4f26451b9fa371b366a8977021e2af7eca449
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618043
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#661630}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e6f259d6e2834c9b0e2cbb0fdd7c9703e1fc6968
The current coloring is:
Background: #fff or #f3f3f3 (DevTools background)
Title text: rgb(48, 57, 66) or #303942 (DevTools default)
Heading text: rgb(90, 90, 90) or #5a5a5a
Explanation text: #8c8c8c
Obsolete settings end up putting #8c8c8c over #f3f3f3 which rather low
contrast. The last two colors are only used in the security panel, so
they don't appear to come from some overall DevTools palette.
Darken everything up a notch. Match the heading text with the title and
DevTools default. (The title font is already much larger than the
heading font, so we retain visual hierachy.) That frees rgb(90, 90, 90)
for use with the explanation text, which is more readable over #f3f3f3
and is still lighter for visual hierarchy.
Screenshots: https://drive.google.com/open?id=1VQV2xVo1sVKJD0sIgj48W-d_SRJCZHpG
Bug: 889994
Change-Id: I539088f3026db4db2d50a5a27a3f6abf30da3e4f
Reviewed-on: https://chromium-review.googlesource.com/c/1255895
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602832}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 343b3cf56e929c08b2797b2dcf75a704fc4a5ce1
The security panel currently points out obsolete features in the form of a long
cumbersome sentence like:
The connection to this site uses TLS 1.2 (a strong protocol), ECDHE_RSA
with P-256 (a strong key exchange), and AES_256_CBC with HMAC-SHA-1 (an
obsolete cipher).
It is hard to pick out what is wrong, and it does not say what to use instead.
It also does not allow for new fields without being even more cumbersome. (The
server signature is missing.)
Replace this with *actionable* advice for the site administrator.
Implementation-wise this does the following:
- Replace "secure (strong TLS 1.2)" with "secure connection settings" to mirror
the existing "obsolete connection settings" text.
- Extend SecurityStyleExplanation with a list of recommendations. These show as
a list under the "obsolete" heading.
- With the secure/obsolete details moved to the recommendation list. Remove the
"(a strong protocol)" and "(an obsolete cipher)" parentheses and simplify the
top-level sentence.
- And with the cumbersome sentence fixed, *finally* unblock incorporating the
server signature into the secure/obsolete status. This CL thus additionally
routes the server signature out of //net and into the SecurityStyleExplanation
logic.
Screenshots: https://drive.google.com/open?id=1-JTy2aMWvKImrZSKrOWlUAG7WU2KKarg
This CL does not change the styling or other details of how the security style
explanations are presented, though it's been noted the contrast is too low, so
we may wish to fix the styling either as a follow-up or in this CL.
Bug: 889994
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I913679f77fd5fb0cf018c4a20c2f098effa32674
Reviewed-on: https://chromium-review.googlesource.com/c/1250164
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602557}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e7e073ef030ef6d51ea77878bbe9e46cd2007c41
Jack Franklin