Commit Graph
15 Commits
Author SHA1 Message Date
Tim van der Lippe 3d1ee59ce9 Add network as dependency of security
The security panel can link to show requests in the network panel,
but did not specify it as a dependency in its module.json. This
caused CSS resources of the network panel to not be loaded and
cause a distorted view of the network panel.

R=andoli@chromium.org

Fixed: 1168071
Change-Id: Ifa9f6179d79ad2ffd0927db86db681765b476e21
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2642347
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
2021-01-21 12:43:43 +00:00
Tim van der Lippe 6dd4b0c912 [module.json extensions] Security
This also fixes a bug where `build_release_applications` wasn't
rebuilding when changes would be made to devtools_app.js

R=andoli@chromium.org

Bug: 1134103
Change-Id: I50831c41e0ce7c04ddeb0c1a44acd51436ef92b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2593143
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
2021-01-05 12:14:09 +00:00
Tim van der Lippe 7dcef88d8b Remove skip_compilation from module.json files
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I4c4fd280adb4f5f7b327239d08d80b2cb98b203b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560248
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-11-25 13:19:08 +00:00
Kalon Hinds 438d44197a [Loc] Migrate security to Localization V2
Bug: 1136655
Change-Id: I77e776f00249eb97f49e24681d19722f500c4c86
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2546327
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
2020-11-19 01:34:11 +00:00
Tim van der Lippe c33da00600 Use TypeScript-authored files in security/
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I5608b2f8994db5488e698c14207f24c23ab07d28
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2520999
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-11-06 10:56:12 +00:00
Tim van der Lippe 46e1bcace9 Remove pre_generates_legacy from module.json files
This was a temporary flag used during the build_release_applications
to GN migration.

R=aerotwist@chromium.org

Bug: 1131500
Change-Id: I8a772bcc4bee31dbd3270bf7ef62d8c97941024a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484716
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-10-19 16:12:09 +00:00
Tim van der Lippe ead1fa43d0 Move remaining legacy files to GN
R=aerotwist@chromium.org

Bug: 1131500
Change-Id: Ibb247dd02a5032604824517be4276c4b83c8fc8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2479140
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-10-19 09:25:50 +00:00
Tim van der Lippe cac65d4fa0 Remove skip_rollup
This was a temporary flag as part of the devtools_entrypoint migration.
Since that migration has concluded, we can now remove all references
to it and clean up `build_release_applications.py`.

R=jacktfranklin@chromium.org,aerotwist@chromium.org

Bug: 1101738
Change-Id: I3ef9ec1a99bc9fc1758532124db22b3b4b1a5e2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391140
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-09-08 15:44:09 +00:00
Jan Scheffler 86ae5bdefd Migrate front_end/security to devtools_entrypoint
R=aerotwist@chromium.org, jacktfranklin@chromium.org

Bug: 1101738
Change-Id: Icc4d5ca1a1c8247f3a62df38a90b60c0725c883d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332223
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-07-31 16:44:50 +00:00
Tim van der Lippe 37512b0d25 Remove empty script arrays from module.json files
If the module uses `modules` to load the JavaScript files, then
we can remove the `scripts` array altogether. Note that there
are still some modules left that use `scripts`, most notably
the `lighthouse_worker`, which is a remote module.

R=aerotwist@chromium.org

Bug: 1105476
Change-Id: Ie303e9835f5ce6d42ccae7b3a305d8f3df1af84c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2302597
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-07-17 10:05:33 +00:00
Jose Leal Chapa 50e7bb5309 DevTools personalization - Make Security tab closeable
To be careful of not introducing breaking changes the closeable tabs work will be staggered in different CLs.
Each CL will target one single panel and will include new e2e tests that will validate:
- the panel is open by default
- the panel exists under More tools
- Closing the tab doesn't crash the devtools
- Reopening devtools persist the newly closed tab

Gif: https://imgur.com/a/LXM0ndg

Explainer:
https://docs.google.com/document/d/1TC1FxzSgRIaXmChpjL05T7sZuduRos3IDPDG5vCS1Oc/edit?usp=sharing

Overall layout personalization explainer:
https://docs.google.com/document/d/1oYBh3QeucgEV-n8BYDU_J-2wcLA4Kg1yku4jDDMcsro/edit?usp=sharing

Bug: 1074732
Change-Id: Idf4ef206c5a8b10fa73c2369394ec1ff09976e97
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2167137
Commit-Queue: Jose Leal <joselea@microsoft.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
Reviewed-by: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
2020-06-19 17:34:41 +00:00
Mathias Bynens 5e43b27e8b Reformat module.json files
This patch makes it so that all module.json files use the same
consistent indentation that matches .editorconfig and the rest
of the codebase. At the request of reviewers, one such file
(front_end/emulated_devices/module.json) has been excluded
from this patch. It will be reformatted in a separate CL.

Note that this patch does not “roll CodeMirror”, although a
pre-commit hook forces me to include that phrase in the commit
message because the module.json file in the relevant folder is
modified.

Bug: chromium:1070492
Change-Id: Ib31ed5232461e2f80bf05f31105fc919f6639b0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127007
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2020-04-14 05:35:23 +00:00
Paul Lewis 5168c98cc4 Migrates security/ to ESM internally
R=tvanderlippe@chromium.org

Bug: 1006759
Change-Id: I034fe172c1308b1c24950b6e6030e25c823f2571
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2002592
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-01-15 17:11:18 +00:00
Paul Lewis 53070929e0 Migrates security/ to esm
Bug: 1006759
Change-Id: I7adbedb2867848fb88395f8db20e6618b8428e8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1940227
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2019-11-28 10:53:14 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2.
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00