This CL turns on the use_theme_colors stylelint rule which enforces that
any colors use variables defined in our codebase.
There are many, many violations, unsurprisingly (about 1500), so for now
I have disabled every single violation. The goal of the dark mode
migration will be in part to remove all violations of this rule.
Additionally, new code going forwards should adhere to the rule and not
add the comment to disable the warning.
Bug: 1152736
Change-Id: I51372724ea51485daef3d4f75b7d3f60a7c8016f
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2671323
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
This patch adds a createTextLink method to create
text links and uses it in the security > origin view to
link to the network pane. It also adds "show more" and
"show less" classes for to the text link.
Bug: chromium:977423
Change-Id: If5ff95e5d26af3a20680e93e23e110b912a41de4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789531
Commit-Queue: Jan Scheffler <janscheffler@google.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#699635}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2d23c1d6ec05bae5d56cc417b90146d9064dde95
Changes:
Origin:
- 'Origin' text is now a header 1
- 'Connection' text is now a header 2
- 'Certificate' text is now a header 2
- 'Certificate Transparency' text is now a header 2
- 'Show more/less' and 'Show full details' links are now marked as buttons and are keyboard accessible
Overview:
- 'Security overview' text is now a header 1
- page security description is now a header 2
- 'View x in network panel' link is now marked as a button and is keyboard accessible
.devtools-link css changes:
https://imgur.com/a/9FtpsU4
link elements to button element change:
https://imgur.com/zSMcGVQ
CR Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=962686
Change-Id: I3a62e898d7135ace1d8a9c76dfdbad382c928500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606195
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#672600}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ec4778d2487334d68e9fdc9c55d95ab4b9bddf3f
Jack Franklin