zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-10 05:35:05 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
18 Commits
Author SHA1 Message Date
Jack Franklin 49a9481a74 Lint color usage in background and border-* properties. 
The list of CSS properties we check for colors wasn't thorough and
didn't include `border-left/right/top/bottom` or `background` on its
own. This CL fixes that and disables the rule for any current
violations.

Bug: 1152736
Change-Id: Ic732d653fdfab0462a04dc891bcece1f44e5d471
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2676157
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2021-02-05 15:39:39 +00:00
Jack Franklin 8064d3ba7a Lint against non-theme-color variables 
This CL turns on the use_theme_colors stylelint rule which enforces that
any colors use variables defined in our codebase.

There are many, many violations, unsurprisingly (about 1500), so for now
I have disabled every single violation. The goal of the dark mode
migration will be in part to remove all violations of this rule.

Additionally, new code going forwards should adhere to the rule and not
add the comment to disable the warning.

Bug: 1152736
Change-Id: I51372724ea51485daef3d4f75b7d3f60a7c8016f
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2671323
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-02-03 11:02:09 +00:00
Jack Franklin fd9dfaa5e7 [Dark mode] replace #fff background-color 
This CL searches for CSS that matches:

- background: #fff
- background: #ffffff
- background: #white
- background-color: #fff
- background-color: #ffffff
- background-color: #white

And replaces the declaration with var(--color-background) from the new
set of color variables.

Bug: 1152736
Change-Id: Ia0575ccfa4e23c92fd4f83e6c911236dbb893fea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577559
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-01-11 16:18:06 +00:00
WillHernandez e35f0c74e5 Prevent “Emulated Devices” text from wrapping 
This patch changes the styles for the “Emulated Devices” h1 to
prevent it from wrapping to the next line and clashing with the
"Add custom device” button when the DevTools window is resized.

Before: https://i.gyazo.com/62dd0014097d6c9dc6246fa9f6aaae1a.png
After: https://i.gyazo.com/0b67cba2d380b3b73b5b56ed755670a9.png

R=mathias@chromium.org

Fixed: 1137733
Change-Id: Ic5ba53d5434da309327d9cf8101d916aa3c2761f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2493185
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-10-27 16:53:16 +00:00
Luke Swiderski 0bb88ca7c1 Removed border-bottom from header, added border-top to container wrapper 
In order to stop the contents of settings-container-wrapper from scrolling over its parent header div when minimum font size is set to huge, I removed the border-bottom from the header element and instead added the same border to the container-wrapper top.  It looks exactly the same and solves the issue.

Added my name to the AUTHORS file

R=mathias@chromium.org

Screenshot before: https://imgur.com/a/izuiGha
Screenshot after:  https://imgur.com/a/lctJKj3

Bug: 1133677
Change-Id: I79c99dd04baf34a9a6c9fe6f623cf7f4964965b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2491926
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-10-26 13:28:05 +00:00
Mathias Bynens e4de6b3c30 Reland “Enable property-no-vendor-prefix stylelint check” 
This patch drops unnecessary -webkit- prefixes in CSS and enables
a lint check to enforce that prevent such properties from being
added in the future. Note that the use of vendor-prefixed CSS
properties is still accepted in cases where there is no standardized
and browser-supported alternative.

TBR=changhaohan@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1104187
Change-Id: Ibf36fe5a3802b5f3ac663b7ac873a4758e0fda14
Fixed: chromium:1031475
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2297386
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2297393
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-07-14 14:47:38 +00:00
Tim van der Lippe 2efbb1b802 Revert "Enable property-no-vendor-prefix stylelint check" 
This reverts commit 190803bad8.

Reason for revert: This breaks the icons in DevTools, which leaves gray backgrounds behind.

Original change's description:
> Enable property-no-vendor-prefix stylelint check
> 
> This patch drops unnecessary -webkit- prefixes in CSS and enables
> a lint check to enforce that prevent such properties from being
> added in the future. Note that the use of vendor-prefixed CSS
> properties is still accepted in cases where there is no standardized
> and browser-supported alternative.
> 
> Bug: chromium:1104187
> Change-Id: I29ae93d5a760c4f5037f20663754f448b5083235
> Fixed: chromium:1031475
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2297386
> Reviewed-by: Changhao Han <changhaohan@chromium.org>
> Commit-Queue: Mathias Bynens <mathias@chromium.org>

TBR=mathias@chromium.org,changhaohan@chromium.org

Change-Id: I5fe13b7afd8b71180163c7419092cc6a758903b6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1104187
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2297391
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-07-14 14:24:29 +00:00
Mathias Bynens 190803bad8 Enable property-no-vendor-prefix stylelint check 
This patch drops unnecessary -webkit- prefixes in CSS and enables
a lint check to enforce that prevent such properties from being
added in the future. Note that the use of vendor-prefixed CSS
properties is still accepted in cases where there is no standardized
and browser-supported alternative.

Bug: chromium:1104187
Change-Id: I29ae93d5a760c4f5037f20663754f448b5083235
Fixed: chromium:1031475
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2297386
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-07-14 13:23:06 +00:00
Alex Rudenko 0a3fe9219c Fix stylelint-config-standard issues in settings/settingsScreen.css 
Bug: chromium:1083142
Change-Id: I5009d74a7e1162dce67a9ad4d56a06b3aa390cd6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2272557
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2020-06-29 09:19:42 +00:00
Mathias Bynens ca9fa2d73f Consistently format CSS color and opacity values 
- Prefer the modern comma-free CSS color function syntax over the
  legacy syntax. [1]
- Explicitly use the `deg` suffix for angle values in colors, to
  clarify the range.
- Explicitly use the `%` suffix for percentages instead of formatting
  the value as a number, again to clarify the range.

[1]: https://twitter.com/mathias/status/1253242715304857601
[2]: https://goo.gle/devtools-css-color

Bug: chromium:1083142
Fixed: chromium:1073885
Change-Id: I8e1582a2dee3553a61df88564051ea84c2011d76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209091
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
 2020-05-19 16:50:26 +00:00
Mathias Bynens b0c1f4bce2 Fix stylelint-config-standard violations 
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-05-15 17:05:27 +00:00
Yang Guo 33e8f6fbe8 Show previously hidden experiments 
Previously, tapping shift 6 times when the experiments list is open
unlocks additional hidden experiments.

The new UI shows these experiments as unstable experiments below
regular ones like shown here: http://crbug.com/1048124#c5

R=mathias@chromium.org

Bug: 1048124
Change-Id: Iea0c9925c43b622f17c1b5b2ae4724d815eeb17e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2041439
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-02-06 14:27:47 +00:00
Chandani Shrestha 83bd7c9e05 Reland of "DevTools: Make Preferences Settings Pane Accessible" 
The original change was reverted because basic-a11y-test was timing out.
Original change had added axe test for preferences settings in basic-a11y-test.js which already had few other a11y tests to test other tool.
Here, the test for Preferences Settings pane is removed from basic-a11y-test.js it will be added seperately.

Original change: DevTools: Make Preferences Settings Pane Accessible https://chromium-review.googlesource.com/c/chromium/src/+/1600533
Reverted change: https://chromium-review.googlesource.com/c/chromium/src/+/1618170

Change-Id: I8b6174496ea931081edc751f1547dc7ead0ac7b5
Bug: 963183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635874
Commit-Queue: Chandani Shrestha <chshrest@microsoft.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668145}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9ec5dbfd5ea0ad22e672250f1d71b55870bc5ac6
 2019-06-11 21:21:59 +00:00
Joel Einbinder e1c93d9cb6 DevTools: Remove 20kb of unused CSS 
These css rules used classes that don't exist anywhere in the
javascript. A script was written to find them, but manually checking
is still needed because some scripts generate class names by
string concatenation like 'icon-' + iconType

Change-Id: I15c4f26451b9fa371b366a8977021e2af7eca449
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618043
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#661630}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e6f259d6e2834c9b0e2cbb0fdd7c9703e1fc6968
 2019-05-21 06:16:13 +00:00
Collin Baker 93654ad8c3 Revert "DevTools: Make Preferences Settings Pane Accessible" 
This reverts commit 0cf7d62e09abefc7c43185d49e98bb999ca1a58a.

Reason for revert: likely cause of WebKit MSAN failures: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20MSAN/14589

Original change's description:
> DevTools: Make Preferences Settings Pane Accessible
> 
> Preferences pane had following accessibility issues and is fixed as follows:
> - The top heading was in h3.
> 
> Fix: Updated h3 to h1
> - Subcategories was missing heading role of h2 and group roles for subcategories was missing
> Fix: Added role heading of level 2
> Fix: Added role group to each sub categories
> - Label for drop-downs were not linked with select element so, screen reader wasn't reading out for drop-downs.
> Fix: Added 'for' attribute in label with id value of drop-down select element
> Change-Id: I64d433522c814b8f65ced29958524ac175d987ac
> 
> Bug: 963183
> 
> Video showing Preferences pane after this change https://imgur.com/caUMd46
> 
> Change-Id: I64d433522c814b8f65ced29958524ac175d987ac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600533
> Reviewed-by: Erik Luo <luoe@chromium.org>
> Commit-Queue: Chandani Shrestha <chshrest@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#660890}

TBR=einbinder@chromium.org,luoe@chromium.org,jeffish@microsoft.com,jalissia@microsoft.com,ambake@microsoft.com,juxiao@microsoft.com,chshrest@microsoft.com

Change-Id: Ie904d53939015381c962e50e310f4ceaae484e49
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 963183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618170
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#661031}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e4ba0404d908936c6a3bbd21497fb9ef42d83d29
 2019-05-17 21:27:16 +00:00
Chandani Shrestha f681568771 DevTools: Make Preferences Settings Pane Accessible 
Preferences pane had following accessibility issues and is fixed as follows:
- The top heading was in h3.

Fix: Updated h3 to h1
- Subcategories was missing heading role of h2 and group roles for subcategories was missing
Fix: Added role heading of level 2
Fix: Added role group to each sub categories
- Label for drop-downs were not linked with select element so, screen reader wasn't reading out for drop-downs.
Fix: Added 'for' attribute in label with id value of drop-down select element
Change-Id: I64d433522c814b8f65ced29958524ac175d987ac

Bug: 963183

Video showing Preferences pane after this change https://imgur.com/caUMd46

Change-Id: I64d433522c814b8f65ced29958524ac175d987ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600533
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Chandani Shrestha <chshrest@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#660890}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0cf7d62e09abefc7c43185d49e98bb999ca1a58a
 2019-05-17 17:25:30 +00:00
Joel Einbinder 7fbe24c094 DevTools: Convert to Shadow DOM and Custom Elements v1 
Bug: 685385
Change-Id: I027e84d8003b7799492211d5fcf8348cd91fd799
Reviewed-on: https://chromium-review.googlesource.com/c/1422962
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#625513}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b00e6ea1c9b4db5d743c7c204b1f63abf89e0398
 2019-01-24 05:19:01 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2. 
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
 2018-04-07 15:32:37 +00:00