 Eric Leese
|
5790290bf4
|
Revert "Fix: no space at the bottom of the image in ImageView"
This reverts commit 6798d1b9dc.
Reason for revert: Tree is red, failing webkit_unit_tests_ng
Original change's description:
> Fix: no space at the bottom of the image in ImageView
>
> In addition:
> - The smaller height picture is centered vertically.
> - Fix toolbar text cannot be selected.
>
> After: https://i.imgur.com/osJszTj.png
>
> Bug: 1157466
> Change-Id: I415d24a96586030b726f6e4fa3cf22425aa99987
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2583955
> Reviewed-by: Changhao Han <changhaohan@chromium.org>
> Commit-Queue: Changhao Han <changhaohan@chromium.org>
TBR=changhaohan@chromium.org,yiorsi@gmail.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1157466
Change-Id: If969083af047af0d4f3adbaadaaa823850b17bce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2587730
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
|
2020-12-14 10:48:36 +00:00 |
|
|
Yisi
|
6798d1b9dc
|
Fix: no space at the bottom of the image in ImageView
In addition:
- The smaller height picture is centered vertically.
- Fix toolbar text cannot be selected.
After: https://i.imgur.com/osJszTj.png
Bug: 1157466
Change-Id: I415d24a96586030b726f6e4fa3cf22425aa99987
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2583955
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
|
2020-12-11 23:21:07 +00:00 |
|
|
Tim van der Lippe
|
3fa8654ce6
|
[DarkMode] Migrate files without color definitions
For all of these files, there was no occurrence of the word "color"
in them. Therefore, most of these files were complete noops.
There were two exceptions: some white backgrounds and a box shadow
used for image previews in the sources panel. For the latter, a new
CSS variable is extracted into themeColors.css
R=jacktfranklin@chromium.org
Bug: 1152736
Change-Id: I40f2f1e28cc3c7038b831003f1eb32cc923b411a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567113
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
|
2020-12-02 14:52:49 +00:00 |
|
|
Mathias Bynens
|
ca9fa2d73f
|
Consistently format CSS color and opacity values
- Prefer the modern comma-free CSS color function syntax over the
legacy syntax. [1]
- Explicitly use the `deg` suffix for angle values in colors, to
clarify the range.
- Explicitly use the `%` suffix for percentages instead of formatting
the value as a number, again to clarify the range.
[1]: https://twitter.com/mathias/status/1253242715304857601
[2]: https://goo.gle/devtools-css-color
Bug: chromium:1083142
Fixed: chromium:1073885
Change-Id: I8e1582a2dee3553a61df88564051ea84c2011d76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209091
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
|
2020-05-19 16:50:26 +00:00 |
|
|
Mathias Bynens
|
b0c1f4bce2
|
Fix stylelint-config-standard violations
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
|
2020-05-15 17:05:27 +00:00 |
|
|
Mathias Bynens
|
9680e2e8b0
|
Drop -webkit-user-select in favor of user-select
Bug: chromium:1031475
Change-Id: Ibbf222135c97e79ae3be816216fec9675d643952
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1953613
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
|
2019-12-06 10:31:53 +00:00 |
|
|
Blink Reformat
|
4c46d0969f
|
The Great Blink mv for source files, part 2.
Move and rename files.
NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true
Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
|
2018-04-07 15:32:37 +00:00 |
|
