zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-10 21:54:47 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
42 Commits
Author SHA1 Message Date
Vidal Guillermo Diazleal Ortega 83edb474b3 [Loc] Migrate Sources to Localization V2 
- Migrate sources to use Localization V2 APIs.
- Removed sources grdps

Tested with en-XL.json
https://imgur.com/a/vDrfTAv

Bug: 1136655
Change-Id: I01d4fcdc3f115e9edb3fae933c7d5c6b9ffb77c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692743
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-02-16 19:14:49 +00:00
Andres Olivares 70556d6ed6 [module.json extensions] sources actions & settings pt. 2 
Bug: 1134103
Change-Id: I12a29ca44adb676a93fc4c855cf326fdd70fd36f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2664771
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-02 19:12:49 +00:00
Tim van der Lippe 213266c175 Migrate trimMiddle to string-utilities 
R=szuend@chromium.org

Bug: 1050549
Change-Id: I4fd1a5051ca31270e28e53038f68ea79d0d03c4f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2631114
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-01-19 13:02:57 +00:00
Tim van der Lippe 05149e9772 Remove ls from legacy-defs 
This adds all missing imports for `ls` to all files. After this change,
all usages of `ls` will now properly be resolved to a LocalizedString
rather than a normal string.

R=jacktfranklin@chromium.org

No-Presubmit: True
Change-Id: Icf6d8c3b8bea1f9e66f4b6b58e4ae4c7f99e6f9c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2629554
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-15 12:53:50 +00:00
Songtao Xia 0a3264351b [DevTools Frontend] Resync debugger id after navigation 
DebuggerModel maintains a static table between debugger id and
DebuggerModel. This table is consulted by CallStackSidebarPane to
display call stack. If the mapping is not updated, call stack information
may not be displayed correctly, especially for async stack. There is a
need to resync the mapping, as a debugger id is mathematically based on
an isolate while a debugger model may work on different isolate.

Previously, we resync the mapping when we cannot find a debugger model
corresponding to an id. This change resync the id to model mapping when
responding to FrameNavigated event.

The work is based on conversation related to this CL:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2466642

Change-Id: I605e811b643ae154afb73024ea062f15b7872505
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2610136
Commit-Queue: Songtao Xia <soxia@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2021-01-14 07:52:26 +00:00
Tim van der Lippe bcd6b5c3ff Inline and remove isEnterKey 
R=szuend@chromium.org

Bug: 1050549
Change-Id: I7242fa3b0c2a69d2e4b4dd7c642ba09a5f4dc9bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2624713
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-13 13:02:42 +00:00
Wolfgang Beyer 2d976f379e Remove "blackbox" - refactor CallStackSidebarPane 
This patch replaces unwelcoming language with better terms.

Bug: 1152082
Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k

Change-Id: Iffd7fd0a354562f1428cde6070f8c1dbe795f792
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2593138
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-12-16 16:38:04 +00:00
Wolfgang Beyer cd5020ceee Rename LiveLocation's isBlackboxed() to isIgnoreListed() 
This patch replaces unwelcoming language with better terms.

Bug: 1152082
Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k

Change-Id: I9cc0c8c74ee0dbded3b1666d0205c72147611c76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2584979
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-16 09:17:49 +00:00
Wolfgang Beyer d8189e6236 Rename class BlackboxManager to IgnoreListManager 
This patch replaces unwelcoming language with better terms.

Bug: 1152082
Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k
Backend disable tests: https://crrev.com/c/2584848
Backend update tests: https://crrev.com/c/2587035

Change-Id: I2cf46113bb5e23b7dedfe6ebacd6efa0b56d0159
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2584978
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-12-16 08:37:19 +00:00
Wolfgang Beyer 87e3369110 Replace usage of 'blackbox' in UI 
This patch replaces unwelcoming language with better terms.

'Blacklist' is replaced with 'Ignore List'. These changes primarily
target user-facing strings, further usage of 'blackbox' will be removed
in follow-up CLs.

Screenshot: https://i.imgur.com/7WhyOjN.png
Bug: 1152082
Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k
Backend disable tests: https://crrev.com/c/2580885
Backend update tests: https://crrev.com/c/2581839


Change-Id: I30d1ac5900c375333327aafbcc17be80f85542e5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581542
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-12-11 11:50:37 +00:00
Tim van der Lippe e4d64e7ae0 Remove unrestricted from comments that include other annotations 
For all comments that contained both the unrestricted annotation
and any other potential annotation, remove only the unrestricted
annotation.

R=szuend@chromium.org

No-Presubmit: True
Bug: 1011811
Change-Id: I27dd67f657cdb1a9233d768eea81cabe2591f5f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569759
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-12-02 15:31:52 +00:00
Tim van der Lippe 70842f313f Replace title property setter with Tooltip install invocation 
ui/Tooltip.js overrides the HTMLElement prototype to override the
title property. Rather than using this property, we shoul be
calling Tooltip.install directly. This makes sure that new
components are not relying on the behavior of the legacy
prototype patching.

These usages have been manually audited using the following regexes:

Search: ([\S]+)\.title = ([^;]+);
Replace: UI.Tooltip.Tooltip.install($1, $2);

Note that there are classes in DevTools that also have a title
property. Most notably `TreeElement`. We should not be replacing
these, as they do not inherit from HTMLElement. Luckily, we are
running TypeScript to make sure we don't call `Tooltip.install`
with a non-HTMLElement.

A follow-up CL will clean up the getters.

R=jacktfranklin@chromium.org

Bug: 1150762
No-presubmit: True
Change-Id: I5928e75c70293531849e0576f4fb2a2a8b3e02d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2555060
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-11-23 17:16:46 +00:00
Andres Olivares 6ff6d04308 Refactor ui/Action.js into ui/ActionRegistration.js and update dependencies accordingly 
Bug: 1134103
Change-Id: I2ed7656af264f60c45f1a4143c14203afdbf6f68
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2521638
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-17 16:58:16 +00:00
Jack Franklin 71519f8efb Introduce enableLegacyPatching flag for CSS patching 
As part of the dark mode migration we are adding
`enableLegacyPatching:true` to all call sites of `appendStyle` (and
related methods). If a user passes `false` for that flag, no CSS colour
patching will occur.

This CL is therefore a no-op from a user's perspective as we pass `true`
on every call to maintain existing behaviour, but once we start
migrating we will turn the option to `false`. Long term, once all code
is migrated and the old patching is removed, we will remove this flag
entirely once again.

Bug: 1122511
Change-Id: I76b818e83b7d5ee0175e1548759373f53481e0ab
No-Presubmit: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2516345
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-11-03 14:11:46 +00:00
Songtao Xia d7cfd92902 Support page script in fetch handler 
The change is two-fold:
1) enable setAttachDebugStack CDP call(We may move the CDP
method in the future as it makes sense for it to always be
enabled). An explainer below provides the context of this work.
2) update the debugger id to debugger model mapping in the
frontend (explained below).

The frontend maintains a map between debugger ids and
corresponding debugger models. However, in the backend,
sometimes, a new (debugger id, model) pair is made. The
frontend does not actively update the map. As a result,
while the frontend may still have a valid model, it couldn't
locate the model using a debugger id sent from the backend.

When we print the asynchronous stack id in CallStackSidebarPane.
We need to resync on debugger ids. We use a existing CDP call
(Debugger.enable) to resync on debugger id. Future improvement
may use a different CDP call for this.

Screenshot: https://imgur.com/oU5wETQ

Explainer:https://tinyurl.com/y3zpcfdz

Corresponding backend change:
https://chromium-review.googlesource.com/c/chromium/src/+/2465285

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1137300
Change-Id: If88dd6b6c42421fe81b3d7fa9271a1d522dd27ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2466642
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Songtao Xia <soxia@microsoft.com>
 2020-11-03 07:36:28 +00:00
Benedikt Meurer 34423f2aee [sources] Add tooltip with method name in Call Stack sidebar. 
With C++ it's quite common to have very long method names and these will
not show fully in the sidebar. Add a tooltip with the full method name
to the list item.

Bug: chromium:1136484
Change-Id: I9f8ac5ba00879285dcbf8179a9c181da18724021
Fixed: chromium:1109709
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2474659
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-10-15 11:29:03 +00:00
Tim van der Lippe 13f6549d5a Typecheck sources/CallStackSidebarPane.js with TypeScript 
R=szuend@chromium.org

Bug: 1011811
Change-Id: I39a9a0550ce8398ca884216a43f077ef26f1bd06
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2445775
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-10-02 15:16:30 +00:00
Tim van der Lippe d87271d132 Remove usages of Runtime.sharedInstance 
For all classes that were retrieved via Runtime.sharedInstance,
migrate them to the singletong instance pattern. This removes
the indirection via Runtime and improves code navigation as
well as typechecking.

R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: Ifcf0b73be703308fbdbad0c585f0d945cee9b3b7
Fixed: 1131423
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2434340
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-29 10:59:08 +00:00
Tim van der Lippe 7f2002c598 [globals] self.runtime 
Migrate all usages of self.runtime to Root.Runtime.Runtime.instance().

This also requires various type updates, as now Closure/TypeScript
can better understand the code and discover issues.

R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: Ice07aa0ca959e61a6acdf4618b9a272d8c1096b8
Fixed: 1081614
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2434339
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-29 10:52:39 +00:00
Tim van der Lippe cc37f9b04b [globals] self.Persistence.persistence 
R=aerotwist@chromium.org

Bug: 1058320
Change-Id: I04e6fca49686bf445489719cad1b7bdfa16cc890
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2391246
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-09-08 15:01:39 +00:00
Tim van der Lippe d1a00aacb9 [globals] self.UI.context 
R=jacktfranklin@chromium.org

Bug: 1058320
Change-Id: Icc1d806782e7624fff02e719670a2cca59070ddd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2364594
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-08-19 16:24:38 +00:00
Jan Scheffler e1a1b0fbbf Migrate front_end/sources to devtools_entrypoint 
R=aerotwist@chromium.org, jacktfranklin@chromium.org

Bug: 1101738
Change-Id: I79bcbb35ccf48f6336cde80858f0177427703795
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332224
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
 2020-07-31 14:33:20 +00:00
Tim van der Lippe f49e23286b Replace single class invocations of createElementWithClass 
This applies the following replacement to the codebase:

(\S+) = createElementWithClass\('(\w+)', '([^'\s]+)'\);

to

$1 = document.createElement('$2');\n$1.classList.add('$3');

R=aerotwist@chromium.org

No-Presubmit: true
Bug: 1011811, 1077215
Change-Id: I0d76b39f1ed8cd4a44f18f94e398db934ba4b09c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2176112
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-05-01 16:54:52 +00:00
Paul Lewis 0609f5a4e5 [global] Remaps self.Bindings.blackboxManager 
Moves self.Bindings.blackboxManager to an instance() method.

Bug: 1058320
Change-Id: Idcd46ea17360cdadacc726d1bd520cc2d692efdd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107537
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-03-18 16:48:09 +00:00
Paul Lewis 23883e36f5 [global] Remaps self.Bindings.debuggerWorkspaceBinding 
Moves self.Bindings.debuggerWorkspaceBinding to an instance() method.

Bug: 1058320
Change-Id: Id9090073eb4a0b8715bba82ded470d15d718dcc6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107529
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-03-18 12:06:08 +00:00
Simon Zünd 29781ded1b Make live location update handlers async and properly await {uiLocation} 
Retrieving the {uiLocation} of a LiveLocation can involve source
mapping (via rawLocationToUILocation). As source mapping will be
async in the future we have to properly await {uiLocation} in these
LiveLocation update delegates.

Note that support for asynchronous LiveLocation updates has already
landed.

Bug: chromium:1032016
Change-Id: I81be755581b6347c8d510de3216503e32481e470
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077667
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-03-17 19:49:48 +00:00
Simon Zünd 0c46c55991 Prepare CallStackSidebarPane.js for asynchronous live locations 
R=mathias@chromium.org

Bug: chromium:1032016
Change-Id: I935c63da80286da9810470f46802dc1d34e08fce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2071887
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-03-02 11:46:26 +00:00
Tim van der Lippe fbbf981a34 Migrate sources/ to import cross-module 
Bug: 1006759
Change-Id: I9b91ba0c24a14ca4d30cf3dd4469d5e162bc96db
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2054548
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-13 17:11:00 +00:00
Paul Lewis 509e7a650a [Global] Update refs to Persistence.persistence 
Bug: 1006759
Change-Id: Ibd16fdca19f3ee21255c439aff360dc302676d92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019543
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-24 14:49:16 +00:00
Paul Lewis d990734442 [Global] Update refs to UI.context 
Bug: 1006759
Change-Id: I4a405fb1d80f6a384a311a3482c37f943238b73f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019137
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-24 14:25:48 +00:00
Paul Lewis 2ddc6313de [Global] Updates refs for bindings globals 
Bug: 1006759
Change-Id: Ib73c3ce4b014126da088851bfeccdff49d6ba0ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016754
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-01-23 13:37:40 +00:00
Paul Lewis 39944955e0 Migrates sources/ to ESM internally 
Bug: 1006759
Change-Id: Ie1ca01eaadde94191431217f297b108dde5e8adf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2002596
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-22 17:15:48 +00:00
Jack Lynch 7cd600f9d2 Reland: Make call stack keyboard navigable 
This is a reland of https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880515,
which was reverted at https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1961190
due to test failures that do not repro or appear to be related.

This PR makes the call stack sidebar pane in the Sources panel more
accessible by:
  - enabling keyboard navigation of the call frame list by managing call
  frame selection outside of ListControl as suggested by Joel in [2]
  - adding the aria-disabled attribute to unselectable call frames
  - adding an aria description to blackboxed call frames

This will break several web tests, so [3] must be merged first to
disable them.
Originally reviewed in [1], where the web test fixes for this CL now
live.

Video showing navigation: https://i.imgur.com/55tJy2k.mp4

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1715121
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1690089/11#message-3e9e158cce4628b01398d9cf84e37550b55b14c6
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1893117

Bug: 963183
Change-Id: I826e1c5c2f78c235823a71c956fde6ef73bcccac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1965855
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
 2020-01-13 23:13:35 +00:00
Tim van der Lippe 8987f8f14e Migrate sources/ to ESM 
Bug: 1006759
Change-Id: I509e05a6e4f4c974dbcdd8224f0439d7b1b98aec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1985672
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-06 12:57:13 +00:00
Simon Zünd 36acd549ae Revert "Make call stack keyboard navigable" 
This reverts commit 4c4f65cb9d.

Reason for revert: Suspected to causes layout tests to fail. Found via
a local bisect of the first failing roll CL: https://crrev.com/c/1961233
Example failure: https://ci.chromium.org/p/chromium/builders/try/linux-rel/264054 

Original change's description:
> Make call stack keyboard navigable
> 
> This PR makes the call stack sidebar pane in the Sources panel more
> accessible by:
>   - enabling keyboard navigation of the call frame list by managing call
>   frame selection outside of ListControl as suggested by Joel in [2]
>   - adding the aria-disabled attribute to unselectable call frames
>   - adding an aria description to blackboxed call frames
> 
> This will break several web tests, so [3] must be merged first to
> disable them.
> Originally reviewed in [1], where the web test fixes for this CL now
> live.
> 
> 
> Video showing navigation: https://i.imgur.com/55tJy2k.mp4
> 
> [1] https://chromium-review.googlesource.com/c/chromium/src/+/1715121
> [2] https://chromium-review.googlesource.com/c/chromium/src/+/1690089/11#message-3e9e158cce4628b01398d9cf84e37550b55b14c6
> [3] https://chromium-review.googlesource.com/c/chromium/src/+/1893117
> 
> Change-Id: I4b3f56fc300a2cd381798650c61afd1062430e57
> Bug: 963183
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880515
> Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
> Commit-Queue: Jack Lynch <jalyn@microsoft.com>

TBR=lomitch@microsoft.com,jalyn@microsoft.com

Change-Id: I3698f0eea8bcc00a092ce47eccb2d649169b8a32
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 963183
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1961190
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2019-12-11 09:02:14 +00:00
Jack Lynch 4c4f65cb9d Make call stack keyboard navigable 
This PR makes the call stack sidebar pane in the Sources panel more
accessible by:
  - enabling keyboard navigation of the call frame list by managing call
  frame selection outside of ListControl as suggested by Joel in [2]
  - adding the aria-disabled attribute to unselectable call frames
  - adding an aria description to blackboxed call frames

This will break several web tests, so [3] must be merged first to
disable them.
Originally reviewed in [1], where the web test fixes for this CL now
live.


Video showing navigation: https://i.imgur.com/55tJy2k.mp4

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1715121
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1690089/11#message-3e9e158cce4628b01398d9cf84e37550b55b14c6
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1893117

Change-Id: I4b3f56fc300a2cd381798650c61afd1062430e57
Bug: 963183
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880515
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
 2019-12-10 23:50:30 +00:00
Jack Lynch 805641cb96 ListControl ARIA improvements and opt-out 
This CL marks UI.ListControls as listboxes and their list items as
options, in accordance with the WAI-ARIA listbox pattern at [1]. In
order to allow ListControl users to opt out of this ARIA management,
it also adds a new updateSelectedItemARIA() method to UI.ListDelegate
which prevents ListControl from setting aria-selected on selected items.
Additionally, if the element returned by createElementForItem already
has a role, UI.ListControl will not change it. This allows users to mark
the items as list items instead of options, which is necessary for the
breakpoints panes.

Other changes:
- calls preventDefault in the keydown handler to prevent arrowing
through the list from unnecessarily scrolling
- throws an error instead of a string (requested by Joel in previous CL)

This CL breaks a test, so [2] should be merged first to disable it. The
fixes for the test are at [3].

Originally reviewed at https://chromium-review.googlesource.com/c/chromium/src/+/1690089

[1] https://www.w3.org/TR/wai-aria-practices/#Listbox
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1881715
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1690089

Bug: 963183
Change-Id: I2a81744371497d0e592556f65f0c8177826d7c19
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880309
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
 2019-12-07 07:00:29 +00:00
Tim van der Lippe 50cfa9b19d Migrate host/ to ESM 
Bug: 1006759
Change-Id: Ib72e0acbb20c4579e708cd79a67ffd0bc2073b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829102
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#701509}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b2641f7a9893b50ab7f74d8bc5b7ca7743b0a530
 2019-10-01 10:40:58 +00:00
Tim van der Lippe 1d6e57a0e3 Always add braces to single-line if-statements 
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.

This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.

Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
 2019-09-30 11:55:34 +00:00
Alexey Kozyatinskiy d0ece354d2 [DevTools] always activate first callFrame on pause 
R=lushnikov@chromium.org

Bug: none
Change-Id: Ifae8faddcd5d719011cd53289067d4f2f7ca958c
Reviewed-on: https://chromium-review.googlesource.com/1172706
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#582796}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4bacc71d009c1bd7668a067cddceae75bc579035
 2018-08-14 02:04:17 +00:00
Alexey Kozyatinskiy 1e07c7e5c0 [DevTools] migrate CallStackSidebarPane to live locations 
New CallStackSidebarPane tries to finally split model and view by using
live locations more.
With new implementation each item maintains own state based on live
location updates and schedule updates of correspond list item.

drive-by: removed BlackboxManager.isRawLocationBlackboxed method.

R=lushnikov@chromium.org

Bug: none
Change-Id: I19adde997652754e5f90869ee41ab41899bf8ec4
Reviewed-on: https://chromium-review.googlesource.com/1168384
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#582044}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bceaccd337d6198f92ccca0467752210480d3e86
 2018-08-10 04:00:21 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2. 
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
 2018-04-07 15:32:37 +00:00