zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-12 17:45:49 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
14 Commits
Author SHA1 Message Date
Tim van der Lippe 2e38eeaf9f Remove all comments with only the unrestricted annotation 
The unrestricted annotation is Closure-specific and can be removed.
This patch removes all comments with only the unrestricted annotation
in them.

R=szuend@chromium.org

No-Presubmit: True
Bug: 1011811
Change-Id: Iba0723644f53f5307c3077d341271af86becc32a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2569758
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-12-02 15:25:32 +00:00
Simon Zünd 3141f41937 [ts] Type-check ui/ResizerWidget.js with TypeScript 
R=jacktfranklin@chromium.org

Bug: chromium:1011811
Change-Id: I0cc4fcc06b33c715d1a8ee642c91b54e395f8b14
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2351781
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-08-12 12:54:57 +00:00
Sigurd Schneider 46da7db785 Remove unnecessary @unrestricted annotations from front_end/ui 
This CL removes 29 unnecessary @unrestricted annotations from
classes in front_end/ui.

Bug: chromium:1011811, chromium:1079233
Change-Id: I83c8898e7974db54dd156927cfe45d44c45a7fd7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209084
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-05-20 14:34:33 +00:00
Tim van der Lippe 403a88dd52 Add missing return types for function parameters in ui/ 
These are required for the upcoming TypeScript 3.9.2 upgrade.

R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: Ibb7000f4c70863549bf6ce160a9fb89cb163e6f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199122
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-13 14:09:01 +00:00
Tim van der Lippe ee97fa3e34 Add ts_library definitions and ts-nocheck for Karma tests 
In https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2102717
we are updating the Karma configuration to use the Ninja output for
all unittests. This CL includes all existing unittests in relevant
ts_library definitions and adds the corresponding (previously missed)
dependencies as ts_library as well.

Since most of these dependencies are actually not compiling with
the TypeScript compiler (the original intent of the CL linked above),
we are adding the @ts-nocheck annotation for now. Of course, we should
remove these annotations as soon as possible, but that is a bit more
work, as the tests involved are primarily UI driven.

R=jacktfranklin@chromium.org

# Windows presubmit breaks with large CLs
No-Presubmit: true
Bug: 1061125
Change-Id: Ic67dbbc805642eaa618340a67ea0975eaacffc24
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2162850
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-23 16:33:00 +00:00
Simon Zünd 5bbcd5c493 [utilities] Replace Array with Set in ResizerWidget 
This CL is part of the cleanup effort to get rid of Array#remove and
replace Arrays with Sets where appropriate.

R=mathias@chromium.org

Bug: chromium:1050549
Change-Id: Ia39f3281a6e307c8e4a2acadd5279e6acc44549d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2082373
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2020-03-02 09:51:36 +00:00
Paul Lewis 17e384ec75 Reland "Migrates refs to Common inside ui/ to ESM" 
This reverts commit e2db893b1d.

Reason for revert: Should be fixed now due to https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1981615

Original change's description:
> Revert "Migrates refs to Common inside ui/ to ESM"
> 
> This reverts commit 77e01616ea.
> 
> Reason for revert:
> https://bugs.chromium.org/p/chromium/issues/detail?id=1039577
> 
> Original change's description:
> > Migrates refs to Common inside ui/ to ESM
> > 
> > Bug: 1006759
> > Change-Id: I5967981a53e1f227270c112ce636c32f3c33d9e2
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1985676
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> 
> TBR=aerotwist@chromium.org,tvanderlippe@chromium.org
> 
> Change-Id: I62c1477175307b0b9a54f2cace5fa6ba5af9d667
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1006759, 1039577
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1989312
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

TBR=tikuta@chromium.org,aerotwist@chromium.org,tvanderlippe@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1006759, 1039577
Change-Id: I15f70155ba12d6d8d0fcfd8d0c956573839f4e97
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991501
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-08 16:06:56 +00:00
Takuto Ikuta e2db893b1d Revert "Migrates refs to Common inside ui/ to ESM" 
This reverts commit 77e01616ea.

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=1039577

Original change's description:
> Migrates refs to Common inside ui/ to ESM
> 
> Bug: 1006759
> Change-Id: I5967981a53e1f227270c112ce636c32f3c33d9e2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1985676
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

TBR=aerotwist@chromium.org,tvanderlippe@chromium.org

Change-Id: I62c1477175307b0b9a54f2cace5fa6ba5af9d667
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1006759, 1039577
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1989312
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2020-01-07 06:29:20 +00:00
Paul Lewis 77e01616ea Migrates refs to Common inside ui/ to ESM 
Bug: 1006759
Change-Id: I5967981a53e1f227270c112ce636c32f3c33d9e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1985676
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-06 17:28:33 +00:00
Paul Lewis 9950e186c4 Migrates internal refs of ui/ to esm 
Please note: ESLint and Closure have different opinions on the
necessity of imports, thus // eslint-disable-line no-unused-vars
was added to imports used only for Closure types.

Bug: 1006759
Change-Id: Idd32e12d23a636f1e0fdcb90742e4b706e3cef77
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1967134
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-12-16 16:52:27 +00:00
Tim van der Lippe 20b29c2646 Enforce newlines at end of files 
Trying to upload a CL with missing newlines at the end of files fails with the following warning:

These files should end in one (and only one) newline character:

Update the ESLint config to let the linter fix these errors.

Change-Id: Ia858b5864a1dc43144e0c6d81dedbf46376c2b8d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1897679
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2019-11-04 15:02:44 +00:00
Tim van der Lippe 0830b3daa4 Convert ui/ to ESM 
- ViewManager has been extracted from View
- Action has been extracted from ActionRegistry
- ContextFlavorListener has been extracted from Context

Bug: 1006759
Change-Id: Iff41f3a7db4dcbd6da90fd5752923e32af03bac8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827294
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#702390}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0ffd51ccac853da7c8ec3d91ae868bc61626b29b
 2019-10-03 13:20:07 +00:00
Tim van der Lippe 1d6e57a0e3 Always add braces to single-line if-statements 
The Chromium/Google style guides does not enforce curly braces for
single-line if-statements, but does strongly recommend doing so. Adding
braces will improve code readability, by visually separating code
blocks. This will also prevent issues where accidental additions are
pushed to the "else"-clause instead of in the if-block.

This CL also updates the presubmit `eslint` to run the fix with the
correct configuration. It will now fix all issues it can fix.

Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#701070}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e0bdbe2d7f9fc2386bfaefda3cc29c66ccc18f9
 2019-09-30 11:55:34 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2. 
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
 2018-04-07 15:32:37 +00:00