Jack Franklin
7cdd342471
[Dark Mode]: small CSS files
...
This CL updates CSS colors in five files:
* NodeConnectionsPanel
* TimelineOverviewPanel
* confirmDialog
* emptyWidget
* DOMlinkifier
These all had 1-2 colors to change so it felt OK to bundle them into
one.
Bug: 1152736
Change-Id: I5548fa1297589b775df45d8fbfbbab3d203cc69d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2575090
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2020-12-07 11:54:51 +00:00
Mathias Bynens
ca9fa2d73f
Consistently format CSS color and opacity values
...
- Prefer the modern comma-free CSS color function syntax over the
legacy syntax. [1]
- Explicitly use the `deg` suffix for angle values in colors, to
clarify the range.
- Explicitly use the `%` suffix for percentages instead of formatting
the value as a number, again to clarify the range.
[1]: https://twitter.com/mathias/status/1253242715304857601
[2]: https://goo.gle/devtools-css-color
Bug: chromium:1083142
Fixed: chromium:1073885
Change-Id: I8e1582a2dee3553a61df88564051ea84c2011d76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209091
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Auto-Submit: Mathias Bynens <mathias@chromium.org >
2020-05-19 16:50:26 +00:00
Mathias Bynens
b0c1f4bce2
Fix stylelint-config-standard violations
...
Bug: chromium:1083142
Change-Id: I5ea4cc5d0f83e52856383ba37a47472e33eb19a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204113
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Changhao Han <changhaohan@chromium.org >
Auto-Submit: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Changhao Han <changhaohan@chromium.org >
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
2020-05-15 17:05:27 +00:00
Michael Liao (WPT)
8b0cac5360
DevTools: removing header 2 tag from EmptyWidget and BackgroundServiceView
...
Reason:
- EmptyWidget elements should not be headers as they do not meet the criteria (https://www.w3.org/TR/WCAG20-TECHS/G141.html )
- Marking a non-header as a header will impede SR accessibility for the affected tools
Changes:
- Replacing <h2> tag from UI.EmptyWidget with <div>
- Removing <h2> tag from _showPreview(...) function with <div> in BackgroundServiceView.js (supposed to mimic UI.EmptyWidget element)
- Adding 'empty-bold-text' css in emptyWidget.css that mimics <h2> styling and adding the class to the <div> tags to retain h2 styling
Examples of UI.EmptyWidget use cases:
https://imgur.com/a/qpJeB2Y
BackgroundServiceView.js unique case:
https://imgur.com/cAW8Nu0
Change-Id: Iff3356f12b3dd1906141de4cfe9980b7b1d9c929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693808
Reviewed-by: Joel Einbinder <einbinder@chromium.org >
Commit-Queue: Michael Liao <michael.liao@microsoft.com >
Cr-Original-Commit-Position: refs/heads/master@{#678026}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 58d8c299b23fad86a6fe7e2b489f9cdded704011
2019-07-16 23:19:40 +00:00
Erik Luo
96fee7bbe2
DevTools: improve default UX in Sources sidebars
...
In Source's navigator sidebars, we now
- auto-expand the 'top' frame group
- add empty state text to inform users about the feature
Screenshot: https://imgur.com/a/wrQrZiI
Bug: 942634
Change-Id: I9dc8ae53e7293fcd3ab4be197ba858cb972a35c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637820
Commit-Queue: Erik Luo <luoe@chromium.org >
Reviewed-by: Joel Einbinder <einbinder@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#671195}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d790208e163b6f90b6b4950d6342aa59465bb63b
2019-06-21 04:30:29 +00:00
Blink Reformat
4c46d0969f
The Great Blink mv for source files, part 2.
...
Move and rename files.
NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true
Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org >
Commit-Queue: Blink Reformat <blink-reformat@chromium.org >
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
2018-04-07 15:32:37 +00:00
Jack Franklin