Previously, the SplitWidget was a scrollable container, which started
to cause issues in combination with our use of `scrollIntoView()` now
that https://crbug.com/34224 has been fixed.
Simply *not* forcing the SplitWidget to be a scrollable container
prevents the UI issues.
Bug: chromium:1066415
Fixed: chromium:1121930
Change-Id: I53488b82517438e72101ac99558534122db4f8ff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2381410
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
These css rules used classes that don't exist anywhere in the
javascript. A script was written to find them, but manually checking
is still needed because some scripts generate class names by
string concatenation like 'icon-' + iconType
Change-Id: I15c4f26451b9fa371b366a8977021e2af7eca449
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618043
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#661630}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e6f259d6e2834c9b0e2cbb0fdd7c9703e1fc6968
Previously, the sidebar and main widgets were arranged via css. This
caused the tab order to be wrong for keyboard navigation.
This patch puts the dom elements in the correct order, which lets us
remove the CSS hacks and fixes the tab order.
If the main widget and the sidebar widget both contain extension
iframes, we can't swap the widgets without destroying the extensions.
This is quite an exotic scenario though, and currently never happens
in DevTools.
Bug: 941182
Change-Id: I3a93d7f3e6fb52f5f7c1b1a8511f713d31ae07ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521798
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#640657}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8cd1b24aabce4a31a644db856351f3f9ef29dd92
Mathias Bynens