zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-08 04:44:04 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 44 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
1248 Commits
Author SHA1 Message Date
Jack Franklin fdf2a0cecd [TreeOutline] custom renderer support 
Adds the basic support for custom renderers to tree nodes.

Bug: chromium:1166669
Change-Id: Iaa271384ea1798c234d131b27cd08ecb8a49623d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696651
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-17 11:18:59 +00:00
Sigurd Schneider c65995a229 Roll protocol and adapt tests 
Corresponding back-end CL: https://crrev.com/c/2584499

DISABLE_THIRD_PARTY_CHECK=protocol update pending

Bug: chromium:1170548, chromium:1142606
Change-Id: Ied86cccacceb08db16deea512dafcbd7b5f5dbc2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2698829
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-02-17 09:03:39 +00:00
Kim-Anh Tran c4c1fba6f0 Revert "Add helper functions for adding breakpoints in sources" 
This reverts commit 2fe6522550.

Reason: Causing flaky tests on waterfall

Bug: chromium:1178804
Change-Id: I38e46d9e786467e9bbdcbbf7301da1e363bd0f57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2697200
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Almothana Athamneh <almuthanna@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
 2021-02-16 14:52:45 +00:00
Alex Rudenko 594bd00cb0 Refactor loading of child nodes in AccessibilityNode 
This CL contains the following changes:
- replaces children, numChildren, hasOnlyUnloadedChildren and
loadChildren() with children() and hasChildren() in the AXNode
interface.
- children will be loaded when the element is expanded, and then cached.
- the responsibility to expand preloaded nodes belongs to
AccessibilityTree now. I think previously it'd expand indefinitely
given that the nodes are preloaded.

Bug: 887173
Change-Id: I6c16ca169fa58be0554199c9367024b78b43fa09
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692207
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Meredith Lane <meredithl@chromium.org>
 2021-02-16 14:26:18 +00:00
Alex Rudenko 6755031e1b Use common setting types in Layout panel 
Bug: none
Change-Id: Id164a7fba185d16816ceb52e3cac81f6609b83ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696665
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-16 13:01:06 +00:00
Wolfgang Beyer d39b5ab0b6 [Issues] Add new issue types to UMA tracking 
Backend CL: https://crrev.com/c/2694408
Bug: 1072335
Change-Id: Id7ec58804e5bc5f88f5050c1825b011daefe9da2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692913
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-02-16 12:37:28 +00:00
Simon Zünd 29984780ba [settings] Use const enum for SettingType 
R=andoli@chromium.org, tvanderlippe@chromium.org

Bug: None
Change-Id: Ie5de59552683d2f2fdbf6aff03d302b74e445c7c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2696654
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-16 11:12:58 +00:00
Simon Zünd b7e27c6c87 [settings] Introduce true enum for SettingCategory 
The current code uses localized strings that serve as both enum values
as well as UI strings. This CL fixes this by introducing a true enum
for SettingCategory as well as a method that provides a translated UI
string given a SettingCategory enum value.

R=andoli@chromium.org, tvanderlipp@chromium.org

Bug: None
Change-Id: If0103c10cbea3f1aa5042999b108c30db4f6b591
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692910
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-16 07:02:03 +00:00
Alex Rudenko 49aa146a7a Integrate Flexbox editor into the Styles panel 
Screenshot: https://i.imgur.com/HblODzc.png
Design doc: https://goo.gle/devtools-flex-v2

Bug: chromium:1175699
Change-Id: I7699a8e1ec980c7eddc6d40ff3c88bf37db54988
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2690329
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-02-15 15:33:09 +00:00
Alex Rudenko afa17b48cf Disable flaky e2e tests 
Bug: 1178496, 1178497, 1145969
Change-Id: I5fab85bfbabb3073f99824242183668875a38d87
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2695571
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2021-02-15 15:23:00 +00:00
Jack Franklin c810f7b9f9 [TreeOutline] support lazy children 
Bug: chromium:1166669
Change-Id: Icf1cbb530be84d1ae5c5eb267bbf4881d0c19b9a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692152
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-15 14:59:13 +00:00
Sigurd Schneider 123977af32 Enforce naming convention in test/ 
Bug: chromium:1057042
Change-Id: Ib95f2640b1acf525cd12e377f0118377ddbe6077
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2695568
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-15 14:57:54 +00:00
Sigurd Schneider 4b024d2a06 Enforce naming convention in inspector_overlay 
Bug: chromium:1057042
Change-Id: Ia493669b771f16177933de28138a0064fa3cd8d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692783
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-15 14:09:54 +00:00
Sigurd Schneider 118e44db78 Cleanup IssueAggregator after JSDOC -> TS 
Bug: chromium:1072335
Change-Id: I7065122fb40a9a49ee1be8f38e2db96578469fa7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692772
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-15 11:48:13 +00:00
Sigurd Schneider 91147d8f00 Enforce camelCase for functions 
Bug: chromium:1057042
Change-Id: I6a3e3dcf810884129420e0deaf0e6d54874b5449
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692211
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
 2021-02-15 11:16:45 +00:00
Alex Rudenko bb0998752f Refactor attributes and DOM manipulation in AccessibilityNode 
This CL contains the following changes:
- moving direct DOM manipulations to a central place
- changing the API to be similar across the component
- removed hovered attribute

Bug: 887173
Change-Id: I879797a6265f67f8687afa2a62a4b6a19a443047
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2690339
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Meredith Lane <meredithl@chromium.org>
 2021-02-15 10:03:39 +00:00
Sigurd Schneider cb2d45671e Enforce naming convention for properties 
This CL enforces general camelCase naming for properties,
with the following exceptions:
  - public properties are allowed to have a leading underscore until
    we've migrated them (they were probably introduced by the
    JSDOC -> TS automated script).
  - static readonly class properties must use CONSTANT_CASE. For
    non-static readonly class properties camelCase is enforced,
    and I think this gives the right intuition.

Bug: chromium:1057042
Change-Id: I482b5b7cfe2b856e83fba8b78be222d60761db19
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692210
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-15 09:21:50 +00:00
Andres Olivares e753678c70 Add ViewLocation unit test 
This adds a new unit test to replace the layout test implemented in
http/tests/devtools/unit/view-location.js

Bug: none
Change-Id: I6fea270d3551dc17b8670682b22180f3546e6713
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2684126
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2021-02-12 16:09:06 +00:00
Simon Zünd 5fd7506a2e [e2e] Add host resolver rules for *.test domains 
This CL configures custom host resolver rules for the Chromium binary
that puppeteer is using to run e2e test.

With host resolver rules, all resources can now be loaded via
arbitrary '.test' domains while still being served from localhost.
E.g. an e2e test might navigate to 'devtools.test/foo.html' while
also including an iframe with Url 'bar.test/iframe.html', with both
files being served from localhost.

This unlocks testing for a whole class of features that was
previoulsy impossible to test.

This CL also adds a new helper 'goToResourceWithCustomHost', that
supplements the existing 'goToResource' with a modifiable host part.

R=aerotwist@chromium.org, sigurds@chromium.org

Bug: chromium:1177676
Change-Id: I1f51aa8419619e11352989457b24cc56cfc78e52
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692148
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-02-12 13:36:02 +00:00
Jack Franklin 5017c095f3 Bump Puppeteer to 7.1.0 
Doing so lets me remove some of my hacks for previously broken types.

DISABLE_THIRD_PARTY_CHECK=upgrading puppeteer

Bug: chromium:1176642
Change-Id: I141c6eadfe258ac2c8c31fa86c80f014362ee8ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692157
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-12 12:04:06 +00:00
Sigurd Schneider 71c7ce1f25 Show issue count in console status bar instead of as console message 
Design-doc: https://docs.google.com/document/d/17URPPpxSqSawyKKFpLfj_Tgo_fcop94rCmD9Lr3KnDI/edit
Bug: chromium:1140516
Change-Id: I0cf0e4c99824a82bf60907beb768b96290087a2c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2659020
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-12 11:56:22 +00:00
Jack Franklin ba62e5c033 Disable flakey wasm test. 
Causing waterfall redness:
https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Win/1768/overview

Bug: chromium:117714
Change-Id: I3936784083c78ee0e5e0a53805dacfefdcd448e9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692155
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-12 11:42:53 +00:00
Jack Franklin 2e898b232a Fix broken data-grid filtering 
The rendering logic for data-grid cells that calculated visible cells
did not take into account that a row might be hidden, and therefore had
0 height. Consequently filtering would mess up the data grid and its
scroll position. This CL changes the logic to first filter for the
visible rows and use that array for the rest of the scroll logic.

Additionally there was a bug where the data-grid would steal focus back
if you focused into it and then out to type into the filter box. This is
fixed by tracking if the user's focus is or is not within the data-grid,
and only trying to focus the cell after rendering if the user is within
the data-grid, else we do nothing.

Fixed: chromium:1177202, chromium:1177200, chromium:1176727
Change-Id: Id3e387f18b6d504b4b639254d79a447d84f7d55d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2690330
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-02-12 09:02:13 +00:00
Kim-Anh Tran 1834dd08b6 [extension] Remove evaluateVariable 
Evaluate variable is no longer supported nor used, so remove all
references of it.

Bug: chromium:1177644
Change-Id: If5c2a47a7e72992be15a943b7214a0431fb12d00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2690543
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
 2021-02-12 08:59:48 +00:00
Sigurd Schneider 982ec5a825 Add CORS RFC-1918 issue 
Bug: chromium:1128885
Change-Id: Ia4fc5ee0fd03ad568eccc374db787dc705ee3cef
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2687501
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-02-12 08:45:19 +00:00
Philip Pfaffe 2978b2200c Reenable and fix tests after chromium roll 
Fixed: chromium:1176663
Change-Id: I9db89f5ed223d4c51fc6d27b1c404ba2b2e4ac20
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2690327
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2021-02-11 11:34:18 +00:00
Alex Rudenko 822f5bcc2b Flexbox editor 
This CL implements Flexbox editor as a standalone web
component.

Screenshots:
- https://i.imgur.com/9kjuOiQ.png
- https://i.imgur.com/ulZb2Lm.png

Design doc: https://goo.gle/devtools-flex-v2

Bug: chromium:1175699
Change-Id: I9a7eef1ec445621f02d98ad10c20aa6e2fccbaff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2685121
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-02-11 09:58:14 +00:00
Annabel Zhou fcfa1e2cc0 Keyboard navigation for accessibility tree view panel 
This change complies with WAI-ARIA guidelines for a vertically oriented
tree https://www.w3.org/TR/wai-aria-practices/#keyboard-interaction-22.
The AccessibilityTree component is responsible for keyboard event
handlers, and each node now stores a reference to the tree. Sibling
nodes are navigated to through the parents.

This change is hidden behind experiment flag "fullAccessibilityTree".
Design doc: https://goo.gle/devtools-a11y-tree

Bug: 887173
Change-Id: Ib6cf9e70bf71dd42cf2c10dc0462edd4dbdfac37
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2661919
Commit-Queue: Annabel Zhou <annabelzhou@google.com>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Meredith Lane <meredithl@chromium.org>
 2021-02-11 00:25:24 +00:00
Yisi f551fd7a71 New: undefined CSS var() is set to gray 
The title is no longer displayed as Jump to definition. I don’t think it makes much sense. The underline usually means that it can be clicked.
There is no need to display these words in this critical position. It is more practical to display the actual value of the custom properties.

Screenshot: https://i.imgur.com/BjVx3So.png

Bug: 1124707
Change-Id: I33d8b37de2dc6911580f979e31ee61ebcd518e8f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2593294
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Reviewed-by: Peter Müller <petermueller@chromium.org>
 2021-02-10 22:24:06 +00:00
Philip Pfaffe 2e974061f2 Unblock chromium roll 
Bug: chromium:1176663
Change-Id: Ie7b3e4b5fbcffef3b82e8d783495b663e11bb627
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2687498
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-10 15:20:35 +00:00
Jack Franklin 60cc8ba371 Upgrade DevTools Frontend to Puppeteer 7.0.4 
DISABLE_THIRD_PARTY_CHECK=upgrading pptr

Bug: none
Change-Id: I3b0672d209bd6a35ab0eed7db7cc158cc40039dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678700
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-10 14:07:38 +00:00
Sigurd Schneider ad47ab8556 Generalize CounterButton component to IconButton component 
Bug: chromium:1140516
Change-Id: Ied4eefd029ed612e4e63e6de240e4c6ba0c64f56
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2684494
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-02-10 10:54:21 +00:00
Simon Zünd d4ba153d11 Show message instead of an empty table when no Trust Tokens are stored 
When no Trust Tokens have been issued, the Trust Token table in the
application pane is empty, which looks weird. This CL changes the pane
to show a message instead of an empty table.

Screenshot: https://imgur.com/a/366FLji

R=sigurd@chromium.org

Bug: chromium:1126824
Change-Id: I4177d058104de8b2402de0baa37b8956478070c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2687056
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-02-10 08:56:58 +00:00
Kim-Anh Tran 6af029de0d [Linkifier] Fall back to url for raw location if no script exists 
DebuggerModel.createRawLocationByScriptId will always succeed,
creating a raw location based on the script Id. The live location
that is created from that raw location will update all relevant
information required to open a link as soon as the script appears
in the debugger model.
However, some times a script is never resolved (no script parsed
event with that script id), and in this case we actually need to
find the correct script with a different scriptId using the url.

This adds a fall back in the Linkifier that considers to search for
a script using the url if the current raw location is not
linked to a script, but a script can be found via url.

Fixed: chromium:1173456
Change-Id: I5721bdc0549bb0516b07f285da32b3c688d2240d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678695
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2021-02-09 21:46:24 +00:00
chait pinnamaneni af2b54a52c Test fix for service worker network 
Bug:1172924
Change-Id: Ie4b3827f322b010c0042ae21a372a19d679d9f0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2682190
Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2021-02-09 18:36:20 +00:00
Almothana Athamneh 2fe6522550 Add helper functions for adding breakpoints in sources 
Bug: chromium:1169599, chromium:1112692
Change-Id: I80b2711a006b94b170d9e270cb7afb64a5a7e920
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2643505
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
 2021-02-09 15:42:01 +00:00
Philip Pfaffe 617ad539bd Reenable raw-wasm location test 
Fixed: chromium:1098707
Change-Id: Ia68298a7d6a10685a9f6d4e504d0803a06bcbf6f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678093
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
 2021-02-09 12:16:46 +00:00
Tim van der Lippe 71caf7c6e6 Port RemoteObject local values to unittest 
This ports http tests/devtools/unit/remote-object-from-local-expected.js
from a layout test to a DevTools frontend unit test.

R=andoli@chromium.org

Bug: none
Change-Id: I580e4e494d499528697d9cd3cd3f5f70853654cd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678691
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2021-02-09 12:15:40 +00:00
Alex Rudenko 3d1724d16d Add flex-wrap icons 
The icons rotate depending on flex-direction to indicate how
the wraping would work.

Bug: chromium:1175699
Change-Id: I0cbb32c6d810ac82ad3afc85209e38d857fab3b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678694
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-02-09 11:10:01 +00:00
Sigurd Schneider bca6aa5aa9 Show the resource's network IP address space in the network panel 
Note that the column is actually called 'Remote Address Space' for
historical reasons. This helps debugging CORS RFC 1918 related
problems.

Screenshot: https://imgur.com/a/v5poHud
Bug: chromium:1128885
Change-Id: Ib113817b1755991959f3650a730f9b32d6bad8df
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2681744
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-02-09 08:42:40 +00:00
Paul Lewis 32df74a3e3 Reland "[Test] Tweaks to test runners" 
This is a reland of 3124f1cbbc

Original change's description:
> [Test] Tweaks to test runners
>
> A couple of minor additions to unit test running.
>
> R=jacktfranklin@chromium.org
>
> Bug: None
> Change-Id: I06705d369bcc93802eb07aa5d15668c73c6bfa2a
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2681740
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Auto-Submit: Paul Lewis <aerotwist@chromium.org>

Bug: None
Change-Id: If68034b8bde178df4c8bcaeb51624f61daa08d5b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678689
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-02-08 16:36:46 +00:00
Philip Pfaffe 543570c2ba Patch Mocha's describe to include test names 
When tests fail, debugging the failure includes isolating the test
before opening it in debug mode or adding diagnostics to it. With the
current test output, opening the file is surprisingly tedious, since
there is no direct way to map test log output to the tests on the
filesystem. One has to grep the test directory for test names first.
This CL wraps Mocha's describe function to automatically include the
test filename into the test title in a format that can be copy-pasted
into the test runner's --test-file argument.

Bug: none
Change-Id: I172bd14f5026ec0041b933c64bcdcccf58536fb9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2681741
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
 2021-02-08 15:49:05 +00:00
Tim van der Lippe cc0a803840 Revert "[Test] Tweaks to test runners" 
This reverts commit 3124f1cbbc.

Reason for revert: It breaks `npm run auto-unittest` with the following stacktrace:

```
Traceback (most recent call last):
  File "scripts/test/run_auto_unittests.py", line 46, in <module>
    main()
  File "scripts/test/run_auto_unittests.py", line 42, in main
    args.coverage)
  File "devtools-frontend/scripts/test/run_unittests.py", line 86, in run_unit_tests_on_ninja_build_target
    cwd)
  File "devtools-frontend/scripts/test/run_unittests.py", line 28, in run_tests
    'unittests', 'karma.conf.js')
  File ".vpython-root/7aef5f/lib/python2.7/posixpath.py", line 70, in join
    elif path == '' or path.endswith('/'):
AttributeError: 'NoneType' object has no attribute 'endswith'
```

Original change's description:
> [Test] Tweaks to test runners
>
> A couple of minor additions to unit test running.
>
> R=​jacktfranklin@chromium.org
>
> Bug: None
> Change-Id: I06705d369bcc93802eb07aa5d15668c73c6bfa2a
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2681740
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Auto-Submit: Paul Lewis <aerotwist@chromium.org>

TBR=aerotwist@chromium.org,jacktfranklin@chromium.org

Change-Id: I1bbd636e1316659721db634261506428b06d9f99
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678688
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-08 15:41:46 +00:00
Jack Franklin b0c682302a Make TreeOutline renders scheduled 
Bug: chromium:1166669
Change-Id: Ieb7cbebf013c90577545f686f57f4dca04e19621
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2681736
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2021-02-08 15:21:25 +00:00
Peter Marshall 983f142ef2 [l10n] Add an e2e test for localized UI strings 
Bug: 1136655
Change-Id: Ic88c9ded284a56f5a0fe5d9748ac3bad6b62f083
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2666695
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-08 14:43:39 +00:00
Paul Lewis 3124f1cbbc [Test] Tweaks to test runners 
A couple of minor additions to unit test running.

R=jacktfranklin@chromium.org

Bug: None
Change-Id: I06705d369bcc93802eb07aa5d15668c73c6bfa2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2681740
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
 2021-02-08 12:20:39 +00:00
Wolfgang Beyer 8007db8370 [Frame Details] Add unit tests 
Add unit tests for FrameDetailsView custom component

Bug: 1165710
Change-Id: Iae786a0595dc4b611f569b7f8b58080493ab2ca1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678082
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-02-08 11:39:28 +00:00
Philip Pfaffe e3e5b7600a Deflake an LMI test 
Wait for the tree item to be expanded before trying to click its child.

Fixed: chromium:1166106
Change-Id: Id2e89e272220549afde4b97bf2264a745ca17dc8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678092
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
 2021-02-08 06:30:28 +00:00
Paul Lewis 5dffe71f67 [unit test] Add flag for expanded test name info 
In the typical case we run the unit tests with the `dot` reporter. This
CL allows the use of the karma-spec-reporter instead by setting the
EXPANDED_REPORTING environment variable.

Bug: 1175038
Change-Id: I6d5bf1207e8561ccf78bc83ee375952d646c66ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2564874
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-05 15:47:39 +00:00
Sigurd Schneider b54b602422 Rename ClearStorageView to StorageView 
This CL also converts the layout test storage-view-reports-quota.js
to an e2e test.

Bug: chromium:945786
Change-Id: I9ae73e41e564318474089e7ba312f3379893e847
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2667200
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
 2021-02-05 15:45:29 +00:00