Commit Graph
3 Commits
Author SHA1 Message Date
Mathias Bynens 0a48503ad6 Simplify test resources
Test resources should act as minimal repro cases: they should be as
small and simple as possible, without any unnecessary code that
distracts from what’s important.

This patch applies that thinking to the existing test resources, with
only a few exceptions for 1) descriptive <title>s and 2) the mandatory
license headers.

This came up during review of [1].

[1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107525

Change-Id: I1081bb06129d2b6ce98daf1349d20b2bf2fd9401
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2116445
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2020-03-24 12:55:22 +00:00
Paul Lewis e76848de18 [e2e] Adds licences; updates expectations
The existing e2e test resources did not have a license header. This CL
updates them so they do, and updates the expectations against line
numbers etc to match.

Change-Id: I5d6ae76fbf748dcdeabfcedc236d1e067d27b1c2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2084576
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
2020-03-03 12:46:05 +00:00
Tim van der Lippe 2ab3956295 Add remaining console startup tests
These tests verify error handling as well as frame navigations.

Bug: 1047671
Change-Id: Ic91c5db794b2628ce8235cd049970ff594adff1b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2038702
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-02-05 16:51:03 +00:00