zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-10 05:35:05 +08:00
Code Issues Packages Projects Releases Wiki Activity
7,706 Commits 45 Branches 79 Tags
fdf2a0cecd0116bc13e2c838b485e59cd6bfbc46
Commit Graph
18 Commits
Author SHA1 Message Date
Jack Franklin b0c682302a Make TreeOutline renders scheduled 
Bug: chromium:1166669
Change-Id: Ieb7cbebf013c90577545f686f57f4dca04e19621
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2681736
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2021-02-08 15:21:25 +00:00
Jack Franklin 9247e2d2b8 Fix DataGrid interaction test with bad assertions 
The CL that enabled this change landed just after another which updated
the resizing logic for the data-grid. That meant that once they both
landed, this test's assertions became out of date and it started
failing.

Bug: none
Change-Id: I6b77df3f0b2e14b2b2645a0ba2ec30d3a340b37e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2667196
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2021-02-02 11:14:18 +00:00
Jack Franklin 3e9f040e75 Allow decimal places when resizing data grid columns 
Bug: none
Change-Id: I1521945756c111b61810a291c007e274c95ebcbf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2662825
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-02-02 09:31:48 +00:00
Jack Franklin e38eae5801 Re-enable data-grid resizing test 
This was flaking on the waterfall; locally I have struggled to reproduce
but have added an extra check to the test which seems to help make it
more stable.

I tested it by running `it.repeat(50, ...)` in STRESS=1 and it didn't
fail once, so hopefully it will behave itself on the bots...

Bug: chromium:1172902
Change-Id: I25ad1572d63ff3e438df41bad1b0c62f38578d16
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2667189
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-02-02 09:09:28 +00:00
Kim-Anh Tran 786d84f106 [interaction-test] Disable flaky data grid test 
Bug: chromium:1172902
Change-Id: I71c30c69f7b997a66972ecd36fa637e8466ebd84
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2662816
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
 2021-02-01 09:00:34 +00:00
Jack Franklin e6dcd249e6 Inject inspectorStyle.css into the component docs 
The interaction tests that have new values needed the change as the
inspectorStyle CSS changed the margins on the `body` element so some of the
tests had slightly different pixel values required when testing resizing.

Bug: chromium:1167724
Change-Id: I6569210264471f96040512e7f55158dec5c28bfd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2635666
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-18 16:48:16 +00:00
Jack Franklin 4e3706155a Fix flakey data-grid-controller interaction tests on Mac 
Fixed: chromium:1164826
Change-Id: I75da6ced70391ab9f87628920908d8b30f1a8a11
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2619603
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-11 09:48:16 +00:00
Simon Zünd 9c46f2cb69 Skip flaky DataGridController interaction tests 
The tests seem to only flake/fail on MacOS bot.

Bug: chromium:1164826
Change-Id: Ib6cec75b4bfcbdcaad89d7da94a975700f7dee4e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2619601
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-01-11 06:25:36 +00:00
Jack Franklin 3fcecc1172 Add body context menu to data-grid 
This CL adds support for the context menu that appears when you right
click on the body row of the data-grid.

This menu shows columns you can sort by and you can toggle column
visibility via "Header Options" (the text is identical to the legacy
data grid). It also provides a hook for the user to customise and add
their own items to the context menu.

Bug: 1150793
Change-Id: I6a6d8c6c67156a575477c1e6d438261b85d9b034
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2610967
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-06 16:11:55 +00:00
Jack Franklin bb7bf72580 Fix sub menu context menu interaction tests on Mac 
The interaction tests that looked for submenu entry points in a context
menu would fail on Mac, because on Mac they have the ▶ symbol, whereas
on other platforms they do not.

This CL provides a helper to search for the item with and without the ▶
and ensures the tests pass on all platforms.

Change-Id: I619ff370fbc6388ec166d9fd4b7e944788dbbf6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2612991
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-01-06 11:59:35 +00:00
Jack Franklin 90b6613019 Reland "Add header context menu to data grid" 
This reverts commit c2ad98d783.

Reason for revert: fixed flakey test

Original change's description:
> Revert "Add header context menu to data grid"
>
> This reverts commit 6bdb3622bd.
>
> Reason for revert: Interaction tests started failing on mac.
>
> https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Mac/2514/overview
>
> Original change's description:
> > Add header context menu to data grid
> >
> > This CL adds a default header context menu to the data grid that lists visible
> > and sortable columns much like the legacy data grid.
> >
> > Bug: 1150793
> > Change-Id: I84a8a9cc511d6be9fee1f89ba41a6e8649df54ec
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2600723
> > Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
>
> TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
>
> Change-Id: Ic8ef16044716d922d3a37b6a8fb32e13a75dee72
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1150793
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2601962
> Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
> Commit-Queue: Jan Scheffler <janscheffler@chromium.org>

TBR=aerotwist@chromium.org,szuend@chromium.org,janscheffler@chromium.org,jacktfranklin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1150793
Change-Id: Ibd352be261d2cefee6fccc4b18b438faaad57631
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2610596
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-01-05 11:56:39 +00:00
Jan Scheffler c2ad98d783 Revert "Add header context menu to data grid" 
This reverts commit 6bdb3622bd.

Reason for revert: Interaction tests started failing on mac.

https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Mac/2514/overview

Original change's description:
> Add header context menu to data grid
>
> This CL adds a default header context menu to the data grid that lists visible
> and sortable columns much like the legacy data grid.
>
> Bug: 1150793
> Change-Id: I84a8a9cc511d6be9fee1f89ba41a6e8649df54ec
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2600723
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>

TBR=aerotwist@chromium.org,jacktfranklin@chromium.org

Change-Id: Ic8ef16044716d922d3a37b6a8fb32e13a75dee72
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1150793
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2601962
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
 2020-12-23 07:27:30 +00:00
Jack Franklin 6bdb3622bd Add header context menu to data grid 
This CL adds a default header context menu to the data grid that lists visible
and sortable columns much like the legacy data grid.

Bug: 1150793
Change-Id: I84a8a9cc511d6be9fee1f89ba41a6e8649df54ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2600723
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-12-22 15:43:47 +00:00
Jack Franklin 15ab1a3fc7 [DataGrid]: test to ensure resize persists as data is added 
I was wondering if this would work or not. Turns out it does (yay!) but
feels like the sort of thing that would be easy to break, so adding a
test for resizing, and then adding data, to ensure that adding data
doesn't reset the user's resize.

Change-Id: I0efb7def31119148e12e2c3decc726aaa8923425
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2593140
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-12-16 13:21:44 +00:00
Jack Franklin c08ee98db5 Tests and fix for data grid resizing with hidden column 
Whilst integrating the data-grid I found some bugs with resizing when there are
hidden columns. Some parts of the resize logic didn't take into account hidden
columns and as such indexes were off. This fixes it and adds more interaction
tests to cover the resizing functionality more thoroughly.

Fixed: 1158788
Change-Id: I302bd060bdc30e6739547b99b088541b5f36563e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2593134
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-15 17:00:48 +00:00
Jack Franklin 4747e2779d [DataGrid] allow columns to be resized by the mouse 
Bug: 1153066
Change-Id: Ica1b2f23479b091182507a8629e8f2ccb6eea901
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560753
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-12-14 16:25:11 +00:00
Jack Franklin a7c0819fcc Fix failing theme_color interaction test 
This test was failing as we have added more colors. This doesn't yet
matter as these tests are yet to run on CQ, but they will soon!

TBR=aerotwist@chromium.org

Change-Id: I7f1d709a0fbdc3c2d8b23f345a720cad9eb2d8d9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2571125
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2020-12-03 15:07:25 +00:00
Jack Franklin 3b3a782f3a Enable interaction tests 
This CL introduces the infrastructure and first test for what we're calling
"Interaction tests". These are tests that can be used to test component
behaviour that cannot be tested via Karma unit tests but don't require an e2e
test either.

The best example here is complex user interactions: clicking and dragging a
mouse, or doing multiple tabs to navigate through the UI.

Note that the one interaction test added here for theme_colors isn't the best
example of a complex test, but it's a test that's good enough for now whilst we
get everything set up on infrastructure and make sure it runs without flaking.

Bug: 1153281
Change-Id: Ifb37639a557c459974f703b8954ae68a93d5d368
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566808
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-12-03 10:44:22 +00:00