Jack Franklin
4e3706155a
Fix flakey data-grid-controller interaction tests on Mac
...
Fixed: chromium:1164826
Change-Id: I75da6ced70391ab9f87628920908d8b30f1a8a11
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2619603
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Simon Zünd <szuend@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
2021-01-11 09:48:16 +00:00
Simon Zünd
9c46f2cb69
Skip flaky DataGridController interaction tests
...
The tests seem to only flake/fail on MacOS bot.
Bug: chromium:1164826
Change-Id: Ib6cec75b4bfcbdcaad89d7da94a975700f7dee4e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2619601
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Simon Zünd <szuend@chromium.org >
2021-01-11 06:25:36 +00:00
Jack Franklin
3fcecc1172
Add body context menu to data-grid
...
This CL adds support for the context menu that appears when you right
click on the body row of the data-grid.
This menu shows columns you can sort by and you can toggle column
visibility via "Header Options" (the text is identical to the legacy
data grid). It also provides a hook for the user to customise and add
their own items to the context menu.
Bug: 1150793
Change-Id: I6a6d8c6c67156a575477c1e6d438261b85d9b034
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2610967
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2021-01-06 16:11:55 +00:00
Jack Franklin
bb7bf72580
Fix sub menu context menu interaction tests on Mac
...
The interaction tests that looked for submenu entry points in a context
menu would fail on Mac, because on Mac they have the ▶ symbol, whereas
on other platforms they do not.
This CL provides a helper to search for the item with and without the ▶
and ensures the tests pass on all platforms.
Change-Id: I619ff370fbc6388ec166d9fd4b7e944788dbbf6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2612991
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2021-01-06 11:59:35 +00:00
Jack Franklin
90b6613019
Reland "Add header context menu to data grid"
...
This reverts commit c2ad98d7836bdb3622bdhttps://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Mac/2514/overview
>
> Original change's description:
> > Add header context menu to data grid
> >
> > This CL adds a default header context menu to the data grid that lists visible
> > and sortable columns much like the legacy data grid.
> >
> > Bug: 1150793
> > Change-Id: I84a8a9cc511d6be9fee1f89ba41a6e8649df54ec
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2600723
> > Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org >
>
> TBR=aerotwist@chromium.org ,jacktfranklin@chromium.org
>
> Change-Id: Ic8ef16044716d922d3a37b6a8fb32e13a75dee72
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1150793
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2601962
> Reviewed-by: Jan Scheffler <janscheffler@chromium.org >
> Commit-Queue: Jan Scheffler <janscheffler@chromium.org >
TBR=aerotwist@chromium.org ,szuend@chromium.org ,janscheffler@chromium.org ,jacktfranklin@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1150793
Change-Id: Ibd352be261d2cefee6fccc4b18b438faaad57631
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2610596
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Jan Scheffler <janscheffler@chromium.org >
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
2021-01-05 11:56:39 +00:00
Jan Scheffler
c2ad98d783
Revert "Add header context menu to data grid"
...
This reverts commit 6bdb3622bdhttps://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Mac/2514/overview
Original change's description:
> Add header context menu to data grid
>
> This CL adds a default header context menu to the data grid that lists visible
> and sortable columns much like the legacy data grid.
>
> Bug: 1150793
> Change-Id: I84a8a9cc511d6be9fee1f89ba41a6e8649df54ec
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2600723
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
> Reviewed-by: Paul Lewis <aerotwist@chromium.org >
TBR=aerotwist@chromium.org ,jacktfranklin@chromium.org
Change-Id: Ic8ef16044716d922d3a37b6a8fb32e13a75dee72
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1150793
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2601962
Reviewed-by: Jan Scheffler <janscheffler@chromium.org >
Commit-Queue: Jan Scheffler <janscheffler@chromium.org >
2020-12-23 07:27:30 +00:00
Jack Franklin
6bdb3622bd
Add header context menu to data grid
...
This CL adds a default header context menu to the data grid that lists visible
and sortable columns much like the legacy data grid.
Bug: 1150793
Change-Id: I84a8a9cc511d6be9fee1f89ba41a6e8649df54ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2600723
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-12-22 15:43:47 +00:00
Jack Franklin