Adam Raine
a53fe498d6
[Lighthouse] Roll Lighthouse 7.0.1
...
Bug: 772558
Change-Id: I69ec0588084595a91ad797fb8bb2c994cf667c00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2650244
Commit-Queue: Adam Raine <asraine@google.com >
Reviewed-by: Connor Clark <cjamcl@chromium.org >
2021-01-28 22:35:22 +00:00
Connor Clark
3be8a6b938
[Lighthouse] Avoid reprocessing the same Network events.
...
Also adds test `lighthouse-block-url.js`, which passes
even without this change. I wanted confidence that any
future refactor here will retain the benefits of multi-client.
In short: DevTools is sending the "same" messages to Lighthouse
for the root session: one without a session id (good, expected, LH and
DT assumes this means it comes from the main target), and one also
for the main target but with an explicit sessionId (bad, we end
up double-processing things). This is an overlooked side effect of the
"multi client" work:
- https://chromium-review.googlesource.com/c/chromium/src/+/1743411
- https://chromium-review.googlesource.com/c/chromium/src/+/1838310
This CL is a rather narrow change, but it's important as we are
currently double-counting the size of most requests, which
is a big problem for accuracy. There are likely issues with other domains
sending multiple events. A more involved fix will require a closer
look at the protocol connection juggling going on here.
See https://github.com/GoogleChrome/lighthouse/issues/11415
Change-Id: Ife7296dbd08153784ef700e761d529ffe4b39272
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2607769
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Connor Clark <cjamcl@chromium.org >
2021-01-08 20:43:57 +00:00
Connor Clark
ca50c1ef5f
[Lighthouse] Roll Lighthouse 6.2.0
...
Bug: 772558
Change-Id: I2db72f6ceabb6a7de00f491d029fd75ef167e7ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2341956
Reviewed-by: Connor Clark <cjamcl@chromium.org >
Reviewed-by: Paul Irish <paulirish@chromium.org >
Commit-Queue: Paul Irish <paulirish@chromium.org >
2020-08-07 02:13:51 +00:00
Connor Clark
2bc3be29be
Reland "[Lighthouse] Rename Audits panel to Lighthouse"
...
This reverts commit 0651468562https://chromium-review.googlesource.com/c/chromium/src/+/2055398
Original change's description:
> Revert "[Lighthouse] Rename Audits panel to Lighthouse"
>
> This reverts commit 2ae53ef04dhttps://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/453 . It looks like the layout test expects audits not lighthouse in the name, so it's probably in need of a 3-way merge.
>
> Original change's description:
> > [Lighthouse] Rename Audits panel to Lighthouse
> >
> > Change-Id: Ia2ab175d2a3b6c8ded73aff8ff0f5582f5a8fa0c
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2044605
> > Commit-Queue: Connor Clark <cjamcl@chromium.org >
> > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
> > Reviewed-by: Paul Irish <paulirish@chromium.org >
>
> TBR=paulirish@chromium.org ,aerotwist@chromium.org ,tvanderlippe@chromium.org ,cjamcl@chromium.org
>
> Change-Id: Ia6d5f42a0e6ece4352696c51bf0de5754774cb0a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2051983
> Reviewed-by: Paul Lewis <aerotwist@chromium.org >
> Commit-Queue: Paul Lewis <aerotwist@chromium.org >
TBR=paulirish@chromium.org ,aerotwist@chromium.org ,tvanderlippe@chromium.org ,cjamcl@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1052111
Change-Id: I638ca9bd5cd94e02fb7318f2a7d7c66fca40e6c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056866
Reviewed-by: Connor Clark <cjamcl@chromium.org >
Reviewed-by: Paul Irish <paulirish@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Connor Clark <cjamcl@chromium.org >
2020-02-18 01:56:25 +00:00
Paul Lewis
0651468562
Revert "[Lighthouse] Rename Audits panel to Lighthouse"
...
This reverts commit 2ae53ef04dhttps://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/453 . It looks like the layout test expects audits not lighthouse in the name, so it's probably in need of a 3-way merge.
Original change's description:
> [Lighthouse] Rename Audits panel to Lighthouse
>
> Change-Id: Ia2ab175d2a3b6c8ded73aff8ff0f5582f5a8fa0c
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2044605
> Commit-Queue: Connor Clark <cjamcl@chromium.org >
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
> Reviewed-by: Paul Irish <paulirish@chromium.org >
TBR=paulirish@chromium.org ,aerotwist@chromium.org ,tvanderlippe@chromium.org ,cjamcl@chromium.org
Change-Id: Ia6d5f42a0e6ece4352696c51bf0de5754774cb0a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2051983
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
2020-02-12 11:06:32 +00:00
Connor Clark
2ae53ef04d
[Lighthouse] Rename Audits panel to Lighthouse
...
Change-Id: Ia2ab175d2a3b6c8ded73aff8ff0f5582f5a8fa0c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2044605
Commit-Queue: Connor Clark <cjamcl@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Irish <paulirish@chromium.org >
2020-02-11 22:43:22 +00:00
Adam Raine