Rob Paveza 027399473a DevTools: Don't scrollIntoView non-Element nodes
During search in the Elements pane, it's possible and likely
common that users might enter some search term that would match nodes
which may not be scrolled-to, such as CDATA nodes, comments, or other
types. That's because, as opposed to the "Scroll Into View" context
menu item which guards on the types of nodes, the searcher just
indiscriminately tells the page to scroll the node in. Rather than
addressing that issue in the caller, this change guards that from
happening by calling to the page.

Also: Presubmit check wants newline at EOF.
Change-Id: I6c6501b7a88c7de894a97957029be268aaa43753
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1871821
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Lorne Mitchell <lomitch@microsoft.com>
2019-10-21 23:20:24 +00:00
2019-10-21 08:08:56 +02:00
2019-10-21 08:08:56 +02:00
2019-10-21 13:02:51 +00:00
2019-10-21 08:08:56 +02:00
2019-10-21 08:08:56 +02:00
2019-10-21 08:08:56 +02:00
2019-10-21 08:08:56 +02:00
2019-10-21 08:08:56 +02:00
2019-10-21 08:08:56 +02:00
2019-10-21 08:08:56 +02:00
2019-10-21 08:08:56 +02:00
2019-10-21 08:08:56 +02:00
2019-10-21 08:08:56 +02:00
2019-10-21 08:08:56 +02:00
2019-10-21 13:02:51 +00:00
2019-10-21 12:59:51 +00:00
2019-10-21 08:08:56 +02:00

Chrome DevTools frontend

NPM package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Getting Started (Standalone)

As standalone project, Chrome DevTools front-end can be checked out and built independently from Chromium.

Checking out source

Get depot_tools first.

mkdir devtools
cd devtools
git clone https://chromium.googlesource.com/devtools/devtools-frontend
gclient config https://chromium.googlesource.com/devtools/devtools-frontend --unmanaged

Build

cd devtools-frontend
gclient sync
gn gen out/Default
autoninja -C out/Default

Run in Chromium (from M79 onwards)

To run the production build, use

<path-to-chrome>/chrome --custom-devtools-frontend=file://$(realpath out/Default/resources/inspector)

To run the debug build (directly symlinked to the original unminified source files), build both Chromium and DevTools frontend with the GN flag debug_devtools=true, and use

<path-to-chrome>/chrome --custom-devtools-frontend=file://$(realpath out/Default/resources/inspector/debug)

Getting Started (as part of Chromium)

DevTools frontend can also be developed as part of Chromium.

Follow instructions to check out Chromium. DevTools frontend can be found under chromium/src/third_party/devtools-frontend/src/.

Build as part of Chromium

Refer to instructions to build Chromium. To only build DevTools frontend, use devtools_frontend_resources as build target.

Hacking

Useful Commands

npm run format-py

Formats your Python code using yapf

Note: Yapf is a command line tool. You will have to install this manually, either from PyPi through pip install yapf or if you want to enable multiprocessing in Python 2.7, pip install futures

Development

NPM package

DevTools frontend is available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES2015 modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch

S
Description
No description provided
Readme BSD-3-Clause
1.1 GiB
Languages
TypeScript 88.2%
JavaScript 5.7%
CSS 3%
HTML 1.4%
Python 0.8%
Other 0.8%