Mandy Chen
436efc76eb
Currently, if an unsupported JS feature is used, localization presubmit checks will fail with the raw error message from esprima, the JS parsing library. This CL wraps a try-catch block around the parsing call and outputs a nice error message that specifies the file location and the reason. Before: Error: Line 9: Unexpected token = After: Error: DevTools localization parser failed: third_party\blink\renderer\devtools\front_end\security\SecurityPanel.js: Line 9: Unexpected token = This error is likely due to unsupported JavaScript features. Such features are not supported by eslint either and will cause presubmit to fail. Please update the code and use official JavaScript features. Bug: 941561 Change-Id: If945563f84224232155a7de7cf597c5395a0cbb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729729 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Original-Commit-Position: refs/heads/master@{#697675} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 2b4a1abab0661e491ab275768f8f174cf5686c46
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
- local_node - installs a local runtime of node.js
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_svg_images.py - manually run when changing svg images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.