Mandy Chen 436efc76eb DevTools: Improve localization presubmit file parsing error message ...

Currently, if an unsupported JS feature is used, localization presubmit
checks will fail with the raw error message from esprima, the JS parsing
library. This CL wraps a try-catch block around the parsing call and outputs
a nice error message that specifies the file location and the reason.

Before:
Error: Line 9: Unexpected token =

After:
Error: DevTools localization parser failed:
third_party\blink\renderer\devtools\front_end\security\SecurityPanel.js: Line 9: Unexpected token =
This error is likely due to unsupported JavaScript features. Such features
are not supported by eslint either and will cause presubmit to fail. Please
update the code and use official JavaScript features.


Bug: 941561
Change-Id: If945563f84224232155a7de7cf597c5395a0cbb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729729
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#697675}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2b4a1abab0661e491ab275768f8f174cf5686c46

2019-09-18 17:43:40 +00:00

..

check_localized_strings.js

DevTools: Improve localization presubmit file parsing error message

2019-09-18 17:43:40 +00:00

localization_utils.js

DevTools: Create a grdp file for shared strings to avoid confusion

2019-09-18 17:18:15 +00:00

md5.js

Reland of "DevTools: Added GRD/GRDP files for all localizable strings in the DevTools."

2019-05-28 23:35:03 +00:00