The rule looks up the 'name' attribute on the 'VariableDeclarator' node, which does not exist, instead of the 'name' attribute on the corresponding Identifier node. This CL fixes that by extracting the Identifier check into a common helper and adding a regression test. R=petermarshall@chromium.org Bug: chromium:1180760 Change-Id: If82b24fb27f12a4ebd665b99daf5dea747bc866b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2734617 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Chrome DevTools frontend
The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.
Source code
The frontend is available on chromium.googlesource.com.
Design guidelines
Please be aware that DevTools follows additional development guidelines.
Issue triage
The issue triage guidelines can be found in docs/triage_guidelines.md.
Workflows
Instructions to set up, use, and maintain a DevTools frontend checkout can be found in docs/workflows.md.
Additional references
- DevTools documentation: devtools.chrome.com
- Debugging protocol docs and Chrome Debugging Protocol Viewer
- awesome-chrome-devtools: recommended tools and resources
- Contributing to DevTools: bit.ly/devtools-contribution-guide
- Contributing To Chrome DevTools Protocol: docs.google.com
- DevTools Design Review Guidelines: design_guidelines.md
Source mirrors
DevTools frontend repository is mirrored on GitHub.
DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.
The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.
Getting in touch
-
All DevTools commits: View the log or follow @DevToolsCommits on Twitter
-
All open DevTools tickets on crbug.com
-
File a new DevTools ticket: new.crbug.com
-
Code reviews mailing list: devtools-reviews@chromium.org
-
@ChromeDevTools on Twitter
-
Chrome DevTools mailing list: groups.google.com/forum/google-chrome-developer-tools