Tim van der Lippe
7d4f6c4889
Prior to this fix, the wasmparser_worker entrypoint would include specific files from third_party/wasmparser. However, since the files were included as part of a separate package, rolling up the target could cause issues. They should have been part of the `sources` of the wasmparser_worker entrypoint, but they were instead included as `deps`. Even better would be to not include specific files from the wasmparser and instead use an entrypoint. In the specific case reported in crbug.com/1203165, the wasmparser implementation was updated. As such, GN reran `third_party/wasmparser` and determined that `entrypoints/wasmparser_worker:wasmparser_worker` required recompilation (since one if its dependencies were updated. However, since `entrypoints/wasmparser_worker:wasmparser_worker` wasn't producing a different output, GN would determine that it wouldn't have to run rollup. This conclusion is wrong and is an artifact of the inclusion of specific files of `third_party/wasmparser` by the entrypoint. To fix this, we should rollup all relevant sources in `third_party/wasmparser` instead. That way, whenever the wasmparser implementation is updated, it will properly roll up its content into its bundle, ready for consumption by the entrypoint. R=jacktfranklin@chromium.org Bug: 1203165 Change-Id: Ic29ddea0d1f8e953e11e71a6a0e4e65c5f0f1ad6 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2853559 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Chrome DevTools frontend
The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.
Source code
The frontend is available on chromium.googlesource.com.
Design guidelines
Please be aware that DevTools follows additional development guidelines.
Issue triage
The issue triage guidelines can be found in docs/triage_guidelines.md.
Workflows
Instructions to set up, use, and maintain a DevTools frontend checkout can be found in docs/workflows.md.
Additional references
- DevTools documentation: devtools.chrome.com
- Debugging protocol docs and Chrome Debugging Protocol Viewer
- awesome-chrome-devtools: recommended tools and resources
- Contributing to DevTools: bit.ly/devtools-contribution-guide
- Contributing To Chrome DevTools Protocol: docs.google.com
- DevTools Design Review Guidelines: design_guidelines.md
Source mirrors
DevTools frontend repository is mirrored on GitHub.
DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.
The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.
Getting in touch
-
All DevTools commits: View the log or follow @DevToolsCommits on Twitter
-
All open DevTools tickets on crbug.com
-
File a new DevTools ticket: new.crbug.com
-
Code reviews mailing list: devtools-reviews@chromium.org
-
@ChromeDevTools on Twitter
-
Chrome DevTools mailing list: groups.google.com/forum/google-chrome-developer-tools