mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-07 20:39:31 +08:00
Victor Porof
49dc72859c
This reverts commit 9febb0066d.
Reason for revert: test failures on multiple platforms, e.g.:
- https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8991/overview
- https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Win/5409/overview
Original change's description:
> [e2e] Use pre-allocated DevTools and target tabs
>
> This CL changes the conductor to use new DevTools frontend and target
> tabs for each individual test. A pool prepares a set of frontend/target
> tab pairs in the background so the conductor doesn't need to waste time
> resetting tabs in between tests.
>
> For debugging e2e tests we disable the pool and use on-demand tab
> creation instead. It would be annoying to deal with ~12 open tabs
> and trying to find the right ones in a debugging session.
>
> This CL also increases the general e2e test timeout from 5 to 10
> seconds. This is because of the more volatile nature of e2e tests
> now. In some edge cases a tab for the currently running test might
> not get enough CPU time to run in time. This can happen when a
> serious of short running tests deplete the pool and multiple
> Devtools frontend instances have to be prepared in the background.
>
> R=jacktfranklin@chromium.org
>
> Bug: 1297458
> Change-Id: I6b6c4a15e5d83f7e2bdc6082972993df179a5d87
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3461563
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>
Bug: 1297458
Change-Id: I63699956efb658a36d380870f940bb3a7a76dcc5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3477103
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Victor Porof <victorporof@chromium.org>