Tim van der Lippe
ab78bc61ba
The console prompt is one of two places (the other being the edit breakpoint prompt) that uses arguments hints. However, when the user would show the arguments hints and be finished with it (e.g. hitting escape or entering a command), they wouldn't properly hide. The functionality is implemented in `cursor_tooltip`, which defines the two view effects that trigger opening/closing the tooltip. However, there was no outside access to these effects and they were not hooked up to the corresponding view (in this case residing in `ConsolePrompt.ts`). To make sure that the ConsolePrompt doesn't learn too much about the inner workings of the text editor, we expose a separate function on the JavaScript functionality of the editor. It dispatches the close effect on the view, which ensures that the arguments hints tooltip is properly hidden. This is also true for entering a command, which is implemented in `handleEnter`. Lastly, update the internal cursor_tooltip plugin to use private methods, to clearly denote what is part of the public API (`update`) and what isn't (the rest). R=yangguo@chromium.org Fixed: 1299196, 1299186 Change-Id: I650c25f42564be8992a849b6b8deefff51ff7826 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3477109 Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org>
Chrome DevTools frontend
The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.
Source code
The frontend is available on chromium.googlesource.com.
Design guidelines
Please be aware that DevTools follows additional development guidelines.
Issue triage
The issue triage guidelines can be found in docs/triage_guidelines.md.
Workflows
Instructions to set up, use, and maintain a DevTools frontend checkout can be found in docs/workflows.md.
Additional references
- DevTools documentation: devtools.chrome.com
- Debugging protocol docs and Chrome Debugging Protocol Viewer
- awesome-chrome-devtools: recommended tools and resources
- Contributing to DevTools: bit.ly/devtools-contribution-guide
- Contributing To Chrome DevTools Protocol: docs.google.com
- DevTools Design Review Guidelines: design_guidelines.md
Source mirrors
DevTools frontend repository is mirrored on GitHub.
DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.
The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.
Getting in touch
-
All DevTools commits: View the log or follow @DevToolsCommits on Twitter
-
All open DevTools tickets on crbug.com
-
File a new DevTools ticket: new.crbug.com
-
Code reviews mailing list: devtools-reviews@chromium.org
-
@ChromeDevTools on Twitter
-
Chrome DevTools mailing list: groups.google.com/forum/google-chrome-developer-tools