mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-06 12:01:40 +08:00
Rob Paveza
7d28181e7d
Accessibility Insights identifies an issue in which the iframe which contains the HTML preview of network requests does not have a title, which could present a difficulty for assistive technology. Because, particularly among HTML content, it's highly likely that the HTML content is going to be presented on the web application, and the preview itself is not intended to be interactive, this change adds a role="presentation" attribute. This is intended to make the element semantically meaningless to assistive tech [1]. [1] https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_presentation_role Bug: 963183 Change-Id: I0f0fd02b13595f4787ebf0919abe8cf5a721884e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841940 Reviewed-by: Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> Cr-Original-Commit-Position: refs/heads/master@{#703997} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 6a8b79105be56245a0cf8c1a1fc779a728ecad1d
72 lines
2.6 KiB
JavaScript
72 lines
2.6 KiB
JavaScript
/*
|
|
* Copyright (C) 2011 Google Inc. All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are
|
|
* met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the following disclaimer
|
|
* in the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Google Inc. nor the names of its
|
|
* contributors may be used to endorse or promote products derived from
|
|
* this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
/**
|
|
* @unrestricted
|
|
*/
|
|
Network.RequestHTMLView = class extends UI.VBox {
|
|
/**
|
|
* @param {string} dataURL
|
|
*/
|
|
constructor(dataURL) {
|
|
super(true);
|
|
this.registerRequiredCSS('network/requestHTMLView.css');
|
|
this._dataURL = encodeURI(dataURL).replace(/#/g, '%23');
|
|
this.contentElement.classList.add('html', 'request-view');
|
|
}
|
|
|
|
/**
|
|
* @override
|
|
*/
|
|
wasShown() {
|
|
this._createIFrame();
|
|
}
|
|
|
|
/**
|
|
* @override
|
|
*/
|
|
willHide() {
|
|
this.contentElement.removeChildren();
|
|
}
|
|
|
|
_createIFrame() {
|
|
// We need to create iframe again each time because contentDocument
|
|
// is deleted when iframe is removed from its parent.
|
|
this.contentElement.removeChildren();
|
|
const iframe = createElement('iframe');
|
|
iframe.className = 'html-preview-frame';
|
|
iframe.setAttribute('sandbox', ''); // Forbid to run JavaScript and set unique origin.
|
|
iframe.setAttribute('src', this._dataURL);
|
|
iframe.setAttribute('tabIndex', -1);
|
|
UI.ARIAUtils.markAsPresentation(iframe);
|
|
this.contentElement.appendChild(iframe);
|
|
}
|
|
};
|