mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-03 02:21:05 +08:00
Jack Franklin
cf56966bc3
In crrev.com/c/3748106 we noticed that a CL was able to land that imported a file without the `.js` extension. This is because `.eslintignore` listed `front_end/third_party`, so that folder wasn't linted at all. This is an issue because whilst most of the code in that directory is not authored by us, the entry points usually are, and we want to apply our lint rules there. This CL removes the blanket ignore, instead preferring to ignore `third_party/X/package/`, and a few other special cases, ensuring that devtools-frontend authored files in `third_party/` do get linted. The CL updates the `es_modules_import` rule to not apply the import checks to files in `third_party` (as they cannot apply the same conventions we use in DevTools), but it will still check for file extensions on imports. The remaining changes are small stylistic changes to align to our ESLint rules. Fixed: 1342530 Change-Id: I4ce438499b8c9c77c3fe661576a58bad59d9b061 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3749191 Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).