Jack Franklin
cf56966bc3
In crrev.com/c/3748106 we noticed that a CL was able to land that imported a file without the `.js` extension. This is because `.eslintignore` listed `front_end/third_party`, so that folder wasn't linted at all. This is an issue because whilst most of the code in that directory is not authored by us, the entry points usually are, and we want to apply our lint rules there. This CL removes the blanket ignore, instead preferring to ignore `third_party/X/package/`, and a few other special cases, ensuring that devtools-frontend authored files in `third_party/` do get linted. The CL updates the `es_modules_import` rule to not apply the import checks to files in `third_party` (as they cannot apply the same conventions we use in DevTools), but it will still check for file extensions on imports. The remaining changes are small stylistic changes to align to our ESLint rules. Fixed: 1342530 Change-Id: I4ce438499b8c9c77c3fe661576a58bad59d9b061 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3749191 Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Chrome DevTools frontend
The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.
Source code
The frontend is available on chromium.googlesource.com.
Design guidelines
Please be aware that DevTools follows additional development guidelines.
Issue triage
The issue triage guidelines can be found in docs/triage_guidelines.md.
Workflows
Instructions to set up, use, and maintain a DevTools frontend checkout can be found in docs/workflows.md.
Additional references
- DevTools documentation: devtools.chrome.com
- Debugging protocol docs and Chrome Debugging Protocol Viewer
- awesome-chrome-devtools: recommended tools and resources
- Contributing to DevTools: bit.ly/devtools-contribution-guide
- Contributing To Chrome DevTools Protocol: docs.google.com
- DevTools Design Review Guidelines: design_guidelines.md
Source mirrors
DevTools frontend repository is mirrored on GitHub.
DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.
The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.
Getting in touch
-
All DevTools commits: View the log or follow @DevToolsCommits on Twitter
-
All open DevTools tickets on crbug.com
-
File a new DevTools ticket: new.crbug.com
-
Code reviews mailing list: devtools-reviews@chromium.org
-
@ChromeDevTools on Twitter
-
Chrome DevTools mailing list: groups.google.com/forum/google-chrome-developer-tools