mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-01 09:47:56 +08:00
Improves UX for adding client hints in device settings screen. Instead of adding semi-colon separated value for brands, users will be able to input in different fields. Also added the same form to network conditions panel, so users can easily change client hints from network conditions. In network conditions, user agent client hints gets automatically updated when user changes device from dropdown. Device settings: Before: https://i.imgur.com/sn3E1dV.png After: https://i.imgur.com/rBMNjQt.png Network conditions panel: https://i.imgur.com/Sk9k3Bb.png Bug:1215598 Change-Id: Ie9f75456c67e30bb133675bef756a828fa117719 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2933920 Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Brandon Walderman <brwalder@microsoft.com> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
Adding new icons:
-
Out of a spritesheet (if you have a separately saved icon already go to 2.):
- Open a spritesheet with the icon of interest, like
largeIcons.svgin Inkscape. - Make sure it's the
src/version of the spritesheet. - Copy-paste the icon to a new page. Make sure it preserved its original size and aspect ratio, and isn't otherwise altered.
- To make sure step (3) below doesn't destroy the icon, it might be necessary to resize it. Just select everything and use the elements in the top toolbar to resize the icon (make sure the aspect ratio is preserved).
- Set the size of the page to match the icon. You may use Inkscape's Edit>Resize Page to Selection command to accomplish this.
- If you chose to include padding in the icon, make sure the icon is centered within the page.
- Save the icon with
_icon.svgsuffix. For instancelist_icon.svg.
- Open a spritesheet with the icon of interest, like
-
Add respective entries to
.gnifiles.- Update the
devtols_image_fileslist inconfig/gni/devtools_image_files.gni. - Update the
grd_files_release_sourceslist inconfig/gni/devtools_grd_files.gni.
- Update the
-
Use Icon component in the DevTools front-end:
- Visit https://docs.google.com/document/d/1EA--IokG6YW51y7unS8dIKUx6EtyjETT0uglmvIpfsg/edit#heading=h.xgjl2srtytjt for more information on that.