mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-01 17:57:36 +08:00
Improves UX for adding client hints in device settings screen. Instead of adding semi-colon separated value for brands, users will be able to input in different fields. Also added the same form to network conditions panel, so users can easily change client hints from network conditions. In network conditions, user agent client hints gets automatically updated when user changes device from dropdown. Device settings: Before: https://i.imgur.com/sn3E1dV.png After: https://i.imgur.com/rBMNjQt.png Network conditions panel: https://i.imgur.com/Sk9k3Bb.png Bug:1215598 Change-Id: Ie9f75456c67e30bb133675bef756a828fa117719 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2933920 Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Brandon Walderman <brwalder@microsoft.com> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
211 lines
8.2 KiB
TypeScript
211 lines
8.2 KiB
TypeScript
/*
|
|
* Copyright (C) 2013 Google Inc. All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are
|
|
* met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the following disclaimer
|
|
* in the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Google Inc. nor the names of its
|
|
* contributors may be used to endorse or promote products derived from
|
|
* this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
/* eslint-disable rulesdir/no_underscored_properties */
|
|
|
|
import * as Common from '../../core/common/common.js';
|
|
import * as i18n from '../../core/i18n/i18n.js';
|
|
import * as UI from '../../ui/legacy/legacy.js';
|
|
|
|
import {Events, IsolatedFileSystemManager} from './IsolatedFileSystemManager.js';
|
|
import type {PlatformFileSystem} from './PlatformFileSystem.js';
|
|
|
|
const UIStrings = {
|
|
/**
|
|
*@description Text in Edit File System View of the Workspace settings in Settings
|
|
*/
|
|
excludedFolders: 'Excluded folders',
|
|
/**
|
|
*@description Text to add something
|
|
*/
|
|
add: 'Add',
|
|
/**
|
|
* @description Placeholder text for an area of the UI that shows which folders have been excluded
|
|
* from being show in DevTools. When the user has not yet chosen any folders to exclude, this text
|
|
* is shown.
|
|
*/
|
|
none: 'None',
|
|
/**
|
|
*@description Text in Edit File System View of the Workspace settings in Settings
|
|
*@example {file/path/} PH1
|
|
*/
|
|
sViaDevtools: '{PH1} (via .devtools)',
|
|
/**
|
|
*@description Text in Edit File System View of the Workspace settings in Settings
|
|
*/
|
|
folderPath: 'Folder path',
|
|
/**
|
|
*@description Error message when a file system path is an empty string.
|
|
*/
|
|
enterAPath: 'Enter a path',
|
|
/**
|
|
*@description Error message when a file system path is identical to an existing path.
|
|
*/
|
|
enterAUniquePath: 'Enter a unique path',
|
|
};
|
|
const str_ = i18n.i18n.registerUIStrings('models/persistence/EditFileSystemView.ts', UIStrings);
|
|
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
|
|
export class EditFileSystemView extends UI.Widget.VBox implements UI.ListWidget.Delegate<string> {
|
|
_fileSystemPath: string;
|
|
_excludedFolders: string[];
|
|
_eventListeners: Common.EventTarget.EventDescriptor[];
|
|
_excludedFoldersList: UI.ListWidget.ListWidget<string>;
|
|
_muteUpdate?: boolean;
|
|
_excludedFolderEditor?: UI.ListWidget.Editor<string>;
|
|
constructor(fileSystemPath: string) {
|
|
super(true);
|
|
this.registerRequiredCSS('models/persistence/editFileSystemView.css', {enableLegacyPatching: false});
|
|
this._fileSystemPath = fileSystemPath;
|
|
|
|
this._excludedFolders = [];
|
|
|
|
this._eventListeners = [
|
|
IsolatedFileSystemManager.instance().addEventListener(Events.ExcludedFolderAdded, this._update, this),
|
|
IsolatedFileSystemManager.instance().addEventListener(Events.ExcludedFolderRemoved, this._update, this),
|
|
];
|
|
|
|
const excludedFoldersHeader = this.contentElement.createChild('div', 'file-system-header');
|
|
excludedFoldersHeader.createChild('div', 'file-system-header-text').textContent =
|
|
i18nString(UIStrings.excludedFolders);
|
|
excludedFoldersHeader.appendChild(UI.UIUtils.createTextButton(
|
|
i18nString(UIStrings.add), this._addExcludedFolderButtonClicked.bind(this), 'add-button'));
|
|
this._excludedFoldersList = new UI.ListWidget.ListWidget(this);
|
|
this._excludedFoldersList.element.classList.add('file-system-list');
|
|
this._excludedFoldersList.registerRequiredCSS(
|
|
'models/persistence/editFileSystemView.css', {enableLegacyPatching: false});
|
|
const excludedFoldersPlaceholder = document.createElement('div');
|
|
excludedFoldersPlaceholder.classList.add('file-system-list-empty');
|
|
excludedFoldersPlaceholder.textContent = i18nString(UIStrings.none);
|
|
this._excludedFoldersList.setEmptyPlaceholder(excludedFoldersPlaceholder);
|
|
this._excludedFoldersList.show(this.contentElement);
|
|
|
|
this._update();
|
|
}
|
|
|
|
dispose(): void {
|
|
Common.EventTarget.EventTarget.removeEventListeners(this._eventListeners);
|
|
}
|
|
|
|
_getFileSystem(): PlatformFileSystem {
|
|
return IsolatedFileSystemManager.instance().fileSystem(this._fileSystemPath) as PlatformFileSystem;
|
|
}
|
|
|
|
_update(): void {
|
|
if (this._muteUpdate) {
|
|
return;
|
|
}
|
|
|
|
this._excludedFoldersList.clear();
|
|
this._excludedFolders = [];
|
|
for (const folder of this._getFileSystem().excludedFolders().values()) {
|
|
this._excludedFolders.push(folder);
|
|
this._excludedFoldersList.appendItem(folder, true);
|
|
}
|
|
}
|
|
|
|
_addExcludedFolderButtonClicked(): void {
|
|
this._excludedFoldersList.addNewItem(0, '');
|
|
}
|
|
|
|
renderItem(item: string, editable: boolean): Element {
|
|
const element = document.createElement('div');
|
|
element.classList.add('file-system-list-item');
|
|
const pathPrefix = editable ? item : i18nString(UIStrings.sViaDevtools, {PH1: item}) as string;
|
|
const pathPrefixElement = element.createChild('div', 'file-system-value');
|
|
pathPrefixElement.textContent = pathPrefix;
|
|
UI.Tooltip.Tooltip.install(pathPrefixElement, pathPrefix);
|
|
return element;
|
|
}
|
|
|
|
removeItemRequested(_item: string, index: number): void {
|
|
this._getFileSystem().removeExcludedFolder(this._excludedFolders[index]);
|
|
}
|
|
|
|
commitEdit(item: string, editor: UI.ListWidget.Editor<string>, isNew: boolean): void {
|
|
this._muteUpdate = true;
|
|
if (!isNew) {
|
|
this._getFileSystem().removeExcludedFolder(item);
|
|
}
|
|
this._getFileSystem().addExcludedFolder(this._normalizePrefix(editor.control('pathPrefix').value));
|
|
this._muteUpdate = false;
|
|
this._update();
|
|
}
|
|
|
|
beginEdit(item: string): UI.ListWidget.Editor<string> {
|
|
const editor = this._createExcludedFolderEditor();
|
|
editor.control('pathPrefix').value = item;
|
|
return editor;
|
|
}
|
|
|
|
_createExcludedFolderEditor(): UI.ListWidget.Editor<string> {
|
|
if (this._excludedFolderEditor) {
|
|
return this._excludedFolderEditor;
|
|
}
|
|
|
|
const editor = new UI.ListWidget.Editor<string>();
|
|
this._excludedFolderEditor = editor;
|
|
const content = editor.contentElement();
|
|
|
|
const titles = content.createChild('div', 'file-system-edit-row');
|
|
titles.createChild('div', 'file-system-value').textContent = i18nString(UIStrings.folderPath);
|
|
|
|
const fields = content.createChild('div', 'file-system-edit-row');
|
|
fields.createChild('div', 'file-system-value')
|
|
.appendChild(editor.createInput('pathPrefix', 'text', '/path/to/folder/', pathPrefixValidator.bind(this)));
|
|
|
|
return editor;
|
|
|
|
function pathPrefixValidator(
|
|
this: EditFileSystemView, _item: string, index: number,
|
|
input: UI.ListWidget.EditorControl): UI.ListWidget.ValidatorResult {
|
|
const prefix = this._normalizePrefix(input.value.trim());
|
|
|
|
if (!prefix) {
|
|
return {valid: false, errorMessage: i18nString(UIStrings.enterAPath)};
|
|
}
|
|
|
|
const configurableCount = this._getFileSystem().excludedFolders().size;
|
|
for (let i = 0; i < configurableCount; ++i) {
|
|
if (i !== index && this._excludedFolders[i] === prefix) {
|
|
return {valid: false, errorMessage: i18nString(UIStrings.enterAUniquePath)};
|
|
}
|
|
}
|
|
return {valid: true, errorMessage: undefined};
|
|
}
|
|
}
|
|
|
|
_normalizePrefix(prefix: string): string {
|
|
if (!prefix) {
|
|
return '';
|
|
}
|
|
return prefix + (prefix[prefix.length - 1] === '/' ? '' : '/');
|
|
}
|
|
}
|