zzos/react-native
1
0
Fork 0
mirror of https://github.com/react/react-native.git synced 2026-09-28 05:13:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use umbrella instead of a direct include in timing module (#58540)

Browse Source 
Summary:
Pull Request resolved: https://github.com/react/react-native/pull/58540

Changelog: [Internal]

Update the timing module to use `React/Debug.h` umbrella include instead of a direct one.

Reviewed By: cipolleschi

Differential Revision: D120137164

fbshipit-source-id: e6bf6a8b0b8b6684cb9ede64d4daef85879908b6
This commit is contained in:
Jakub Piasecki
2026-09-25 05:23:34 -07:00
committed by meta-codesync[bot]
parent 63a199f0a7
commit 5e12b391e3
5 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Package.swift
+2 -1
View File
@@ -136,7 +136,8 @@ let reactFeatureFlags = RNTarget(
let reactPerfLogger = RNTarget(
name: .reactPerfLogger,
path: "ReactCommon/reactperflogger",
excludedPaths: ["fusebox"]
excludedPaths: ["fusebox"],
dependencies: [.reactDebug, .reactNativeDependencies]
)
/// React-logger.podspec
packages/react-native/ReactCommon/jserrorhandler/CMakeLists.txt
+1
View File
@@ -22,6 +22,7 @@ target_link_libraries(jserrorhandler
folly_runtime
${mapbufferjni}
react_cxxstableapi
react_debug
react_featureflags
)
target_compile_reactnative_options(jserrorhandler PRIVATE)
packages/react-native/ReactCommon/jsitooling/CMakeLists.txt
+2 -1
View File
@@ -21,7 +21,8 @@ target_link_libraries(jsitooling
folly_runtime
glog
jsi
react_cxxstableapi)
react_cxxstableapi
react_timing)
target_compile_reactnative_options(jsitooling PRIVATE)
target_compile_options(jsitooling PRIVATE -Wpedantic)
packages/react-native/ReactCommon/react/timing/primitives.h
+1 -1
View File
@@ -9,7 +9,7 @@
#include <react/cxxstableapi/UmbrellaGuard.h>
#include <react/debug/flags.h>
#include <React/Debug.h>
#include <chrono>
#include <cmath>
#include <functional>
packages/react-native/scripts/cocoapods/utils.rb
+1
View File
@@ -424,6 +424,7 @@ class ReactNativePodsUtils
.concat(ReactNativePodsUtils.create_header_search_path_for_frameworks("PODS_CONFIGURATION_BUILD_DIR", "React-featureflags", "React_featureflags", []))
.concat(ReactNativePodsUtils.create_header_search_path_for_frameworks("PODS_CONFIGURATION_BUILD_DIR", "React-renderercss", "React_renderercss", []))
.concat(ReactNativePodsUtils.create_header_search_path_for_frameworks("PODS_CONFIGURATION_BUILD_DIR", "React-cxxstableapi", "React_cxxstableapi", []))
.concat(ReactNativePodsUtils.create_header_search_path_for_frameworks("PODS_CONFIGURATION_BUILD_DIR", "React-debug", "React_debug", []))
.each{ |search_path|
header_search_paths = self.add_search_path_if_not_included(header_search_paths, search_path)
}