mirror of https://github.com/react/react-native.git synced 2026-09-28 05:13:06 +08:00

Files

T

Alexander Kawrykow 56129fedcb Respect enum values for TurboModule c++ codegen (#56478 )

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/56478

Changelog: [General] [Fixed] - Respect enum values for TurboModule c++ codegen

Defining an enum like this:

```js
export enum CustomPropertyEditor {
  BitMask = 0,
  Entity = 1,
  Slider = 2,
  AudioEvent = 3,
  CollisionLayer = 4,
  MaterialComponentDeprecatedProperty = 5,
  MeshMaterialList = 6,
  Submesh = 7,
  // CoreUiLayout (8) removed — rendered identically to ClassOrList
  MaterialMapJson = 9,
  AnimationTable = 10,
  SkeletonAsset = 11,
  NavMeshAreaType = 12,
  VFXAsset = 13,
  Table = 14,
  VariableTable = 15,
  AudioBus = 16,
  LodSettings = 17,
  WorldSearch = 18,
  EntityMaterialList = 19,
  NpcId = 20,
  LightingModelVersion = 21,
  PlatformSelector = 22,
  ComponentReference = 23,
}
```
(notice number 8 ), will cause the generated enum to actually look like:
```
  enum class NativeEditableObjectModuleCustomPropertyEditor {
    BitMask, Entity, Slider, AudioEvent, CollisionLayer,
    MaterialComponentDeprecatedProperty, MeshMaterialList, Submesh,
    MaterialMapJson, AnimationTable, ...
  };
```

in other words, the values don't match up after the core ui value. This is quite dangerous and I'm surprised no one has ever noticed that

This diff fixes things such that if an integer value is explicitly assigned, the value is preserved in the generated enum.

Reviewed By: christophpurrer

Differential Revision: D101229471

fbshipit-source-id: 366ea2d16ac74e112f1b68c5ad3d0877dedb918c

2026-04-17 14:59:10 -07:00

e2e

Respect enum values for TurboModule c++ codegen (#56478 )

2026-04-17 14:59:10 -07:00

scripts

Replace glob@^7.0.0 with tinyglobby@^0.2.15 (#54737 )

2025-12-03 05:45:48 -08:00

src

Respect enum values for TurboModule c++ codegen (#56478 )

2026-04-17 14:59:10 -07:00

.babelrc

switch to hermes for react-native-codegen (#56024 )