mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-07 04:26:32 +08:00
Performance: Trace the default categories when Show All Events
experiment is enabled. Currently, this experiment reveals a few more events that were not allowlisted. But this change will expand the tracing category selection to all non-high-overhead categories. Driveby: fix undefined property exception. Change-Id: I236aad44e40724d82d8c37055686e03148059d2b Bug: 1321307 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3616460 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org>
This commit is contained in:
committed by
Devtools-frontend LUCI CQ
parent
a062a6afd7
commit
0567b73fec
@@ -1211,7 +1211,7 @@ export class TimelineModelImpl {
|
||||
|
||||
private processBrowserEvent(event: SDK.TracingModel.Event): void {
|
||||
if (event.name === RecordType.LatencyInfoFlow) {
|
||||
if (event.args.chrome_latency_info.trace_id) {
|
||||
if (event.args.chrome_latency_info?.trace_id) {
|
||||
this.knownInputEvents.add(event.args.chrome_latency_info.trace_id);
|
||||
}
|
||||
return;
|
||||
|
||||
@@ -90,7 +90,7 @@ export class TimelineController implements SDK.TargetManager.SDKModelObserver<SD
|
||||
// 'disabled-by-default-v8.cpu_profiler'
|
||||
// └ default: on, option: enableJSSampling
|
||||
const categoriesArray = [
|
||||
'-*',
|
||||
Root.Runtime.experiments.isEnabled('timelineShowAllEvents') ? '*' : '-*',
|
||||
TimelineModel.TimelineModel.TimelineModelImpl.Category.Console,
|
||||
TimelineModel.TimelineModel.TimelineModelImpl.Category.UserTiming,
|
||||
'devtools.timeline',
|
||||
|
||||
@@ -48,6 +48,7 @@ const REGISTERED_EXPERIMENTS = [
|
||||
'protocolMonitor',
|
||||
'sourcesPrettyPrint',
|
||||
'wasmDWARFDebugging',
|
||||
'timelineShowAllEvents',
|
||||
'timelineV8RuntimeCallStats',
|
||||
'timelineInvalidationTracking',
|
||||
'ignoreListJSFramesOnTimeline',
|
||||
|
||||
Reference in New Issue
Block a user