zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-10 05:35:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix Icon not showing on Source Tab RowInfo

Browse Source 
Although the icon was implemented it was not showing due to the use of "label" instead of span.

Screenshot: https://i.imgur.com/oyRkIkq.png
Bug:1151316
Change-Id: I37fc04575e60ba465f692a344cc571019e3ef7da
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2554571
Commit-Queue: Alfonso Castaño <alcastano@google.com>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
This commit is contained in:
Alfonso Castaño
2020-11-25 15:23:47 +00:00
committed by Commit Bot
parent b383a8e919
commit 2edbdcdba2
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
front_end/sources/UISourceCodeFrame.js
+1 -1
View File
@@ -691,7 +691,7 @@ export class RowMessage {
this.element = document.createElement('div');
this.element.classList.add('text-editor-row-message');
/** @type {!UI.UIUtils.DevToolsIconLabel} */
this._icon = /** @type {?} */ (this.element.createChild('label', '', 'dt-icon-label'));
this._icon = /** @type {?} */ (this.element.createChild('span', '', 'dt-icon-label'));
this._icon.type = /** @type {string} */ (iconClassPerLevel.get(message.level()));
/** @type {!UI.UIUtils.DevToolsSmallBubble} */
this._repeatCountElement =